* [PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number
@ 2022-10-21 17:14 Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
2022-10-22 16:08 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Reichel @ 2022-10-21 17:14 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, linux-rockchip,
linux-arm-kernel, devicetree, Sebastian Reichel, kernel
On RK3588 some power domains require multiple qos blocks to be
saved. The maximum required number for RK3588 is 8 (for VDPU).
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
.../devicetree/bindings/power/rockchip,power-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
index 0d5e999a58f1..cf0f2946fea1 100644
--- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
+++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
@@ -134,7 +134,7 @@ $defs:
pm_qos:
$ref: /schemas/types.yaml#/definitions/phandle-array
items:
- maxItems: 1
+ maxItems: 8
description: |
A number of phandles to qos blocks which need to be saved and restored
while power domain switches state.
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number
2022-10-21 17:14 [PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number Sebastian Reichel
@ 2022-10-21 19:11 ` Heiko Stübner
2022-10-22 16:08 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2022-10-21 19:11 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Rob Herring, Krzysztof Kozlowski, linux-rockchip,
linux-arm-kernel, devicetree, Sebastian Reichel, kernel
Am Freitag, 21. Oktober 2022, 19:14:05 CEST schrieb Sebastian Reichel:
> On RK3588 some power domains require multiple qos blocks to be
> saved. The maximum required number for RK3588 is 8 (for VDPU).
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number
2022-10-21 17:14 [PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
@ 2022-10-22 16:08 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-22 16:08 UTC (permalink / raw)
To: Sebastian Reichel, Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, linux-rockchip,
linux-arm-kernel, devicetree, kernel
On 21/10/2022 13:14, Sebastian Reichel wrote:
> On RK3588 some power domains require multiple qos blocks to be
> saved. The maximum required number for RK3588 is 8 (for VDPU).
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../devicetree/bindings/power/rockchip,power-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index 0d5e999a58f1..cf0f2946fea1 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -134,7 +134,7 @@ $defs:
> pm_qos:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> items:
> - maxItems: 1
> + maxItems: 8
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
You now require minItems 8. It's not what your commit msg is saying. You
miss here minItems: 1.
> description: |
> A number of phandles to qos blocks which need to be saved and restored
> while power domain switches state.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-22 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-21 17:14 [PATCH 1/1] dt-bindings: power: rockchip: Increase pm_qos number Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
2022-10-22 16:08 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).