From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 2/3] Documentation: bindings: add DT documentation for u2phy and u2phy grf Date: Fri, 03 Mar 2017 08:13:35 +0100 Message-ID: <1836183.aHLuUaOhIY@phil> References: <1488440945-27291-1-git-send-email-daniel.meng@rock-chips.com> <1488440945-27291-3-git-send-email-daniel.meng@rock-chips.com> <20170303062156.cofjy6sndxz3gch5@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170303062156.cofjy6sndxz3gch5@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Rob Herring Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org, martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kishon-l0cyMroinI0@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Meng Dongyang List-Id: devicetree@vger.kernel.org Am Freitag, 3. M=E4rz 2017, 00:21:56 CET schrieb Rob Herring: > On Thu, Mar 02, 2017 at 03:49:04PM +0800, Meng Dongyang wrote: > > Due to the u2phy registers are separated from general grf, we need to > > add u2phy grf node and place u2phy node in it. So this patch add u2phy > > grf node. > = > Similar comment on the subject. > = > > Changes in v2: > > - add u2phy grf specification > > = > > Signed-off-by: Meng Dongyang > > --- > > = > > Documentation/devicetree/bindings/soc/rockchip/grf.txt | 15 > > +++++++++++++++ > > 1 file changed, 15 insertions(+) > > = > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > b/Documentation/devicetree/bindings/soc/rockchip/grf.txt index > > 013e71a..6ac23f9 100644 > > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > @@ -7,6 +7,9 @@ From RK3368 SoCs, the GRF is divided into two sections, > > = > > - GRF, used for general non-secure system, > > - PMUGRF, used for always on system > > = > > +On RK3328 SoCs, the GRF is divided into three sections, > > +except GRF and PMUGRF, add a section for USB2PHYGRF, > > + > > = > > Required Properties: > > = > > - compatible: GRF should be one of the followings > > = > > @@ -19,6 +22,8 @@ Required Properties: > > - compatible: PMUGRF should be one of the followings > > = > > - "rockchip,rk3368-pmugrf", "syscon": for rk3368 > > - "rockchip,rk3399-pmugrf", "syscon": for rk3399 > > = > > +- compatible: USB2GRF should be one of the followings > > + - "rockchip,rk3328-usb2phy-grf", "syscon": for rk3328 > > = > > - reg: physical base address of the controller and length of memory > > mapped > > = > > region. > > = > > @@ -33,3 +38,13 @@ Example: GRF and PMUGRF of RK3399 SoCs > > = > > compatible =3D "rockchip,rk3399-grf", "syscon"; > > reg =3D <0x0 0xff770000 0x0 0x10000>; > > = > > }; > > = > > + > > +Example: USB2GRF of RK3328 SoCs > > + > > + usb2phy_grf: syscon@ff450000 { > > + compatible =3D "rockchip,rk3328-usb2phy-grf", "syscon", > > + "simple-mfd"; > = > simple-mfd is not documented. Do you have child nodes? Yes, this will have child nodes and I guess we don't really need the = additional example, that only differs in the compatible. > What makes this a syscon? It has non-PHY registers? It is still a "General Register Files" block in all of the socs manual and yes, that special area also contains registers not used by the phy driv= er. Heiko