From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 1/3] ARM: dts: Turn on USB host vbus on rk3288-evb Date: Wed, 30 Jul 2014 13:24:17 +0200 Message-ID: <1836225.xQCoI7eRWl@diego> References: <1406676273-20701-1-git-send-email-dianders@chromium.org> <1406676273-20701-2-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1406676273-20701-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: Kever Yang , Sonny Rao , Arnd Bergmann , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Am Dienstag, 29. Juli 2014, 16:24:31 schrieb Doug Anderson: > There is no phy driver that works on the Rockchip board for either USB > host port yet. For now just hardcode the vbus signal to be on all the > time which makes both the dwc2 host and the EHCI port work. > > Signed-off-by: Doug Anderson > --- > arch/arm/boot/dts/rk3288-evb.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi > b/arch/arm/boot/dts/rk3288-evb.dtsi index 749e20d..efd625e 100644 > --- a/arch/arm/boot/dts/rk3288-evb.dtsi > +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > @@ -35,6 +35,18 @@ > debounce-interval = <100>; > }; > }; > + > + /* This turns on vbus for both host0 (ehci) and host1 (dwc2) */ > + usb_host_vbus_regulator: usb-host-vbus-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio0 14 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_host_vbus>; > + regulator-name = "usb-host-vbus"; > + regulator-always-on; > + regulator-boot-on; > + }; > }; It seems I have a slightly outdated schematics pdf for the evb ... and only see the OTG vbus pin, on <&gpio0 12>, but am missing the whole host vbus. Could you think about finding another name for the handle? For example, in my incomplete evb-schematics the supply coming from the otg regulator is called vcc50_usb and there should be something similar for the host supply, so I'd like something like vcc50_usbhost: usb-host-vbus-regulator { /* or whatever it gets called */ ... }; simply to keep with the supply names defined in the schematics - makes reading easier. Heiko > > &i2c0 { > @@ -71,4 +83,10 @@ > rockchip,pins = <0 5 RK_FUNC_GPIO &pcfg_pull_up>; > }; > }; > + > + usb-host { > + usb_host_vbus: usb-host-vbus { > + rockchip,pins = <0 14 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html