From: Heiko Stuebner <heiko@sntech.de>
To: Zain <zain.wang@rock-chips.com>
Cc: zhengsq@rock-chips.com, hl@rock-chips.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
mturquette@baylibre.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
galak@codeaurora.org, linux@arm.linux.org.uk,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, eddie.cai@rock-chips.com
Subject: Re: [PATCH v3 2/4] clk: rockchip: set an ID for crypto clk
Date: Thu, 12 Nov 2015 09:40:53 +0100 [thread overview]
Message-ID: <1838616.4qxqO6ir89@phil> (raw)
In-Reply-To: <5643E7B0.2080901@rock-chips.com>
Am Donnerstag, 12. November 2015, 09:13:20 schrieb Zain:
>
> On 2015年11月12日 07:57, Heiko Stuebner wrote:
> > Am Mittwoch, 11. November 2015, 14:35:57 schrieb Zain Wang:
> >> Set an ID for crypto clk, so that it can be called in other part.
> >>
> >> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
> > this should go in together with patch4, the dts change, so an Ack from the
> > clock-maintainers would be nice :-)
> >
> >
> > Heiko
> Ok! Done!
> Thanks.
I'm not sure I understand that.
There is nothing to do for you here, I was merely stating the fact that
we will need to get an Acked-by from the clock maintainers, to allow
me to take both this and the devicetree patch :-)
Heiko
> >
> >> ---
> >>
> >> Changed in v3:
> >> - None
> >>
> >> Changed in v2:
> >> - None
> >>
> >> Changed in v1:
> >> - define SCLK_CRYPTO in rk3288-cru.h
> >> - use SCLK_CRYPTO instead of SRST_CRYPTO
> >>
> >> drivers/clk/rockchip/clk-rk3288.c | 2 +-
> >> include/dt-bindings/clock/rk3288-cru.h | 1 +
> >> 2 files changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> >> index 9040878..3fceda1 100644
> >> --- a/drivers/clk/rockchip/clk-rk3288.c
> >> +++ b/drivers/clk/rockchip/clk-rk3288.c
> >> @@ -295,7 +295,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
> >> RK3288_CLKGATE_CON(0), 4, GFLAGS),
> >> GATE(0, "c2c_host", "aclk_cpu_src", 0,
> >> RK3288_CLKGATE_CON(13), 8, GFLAGS),
> >> - COMPOSITE_NOMUX(0, "crypto", "aclk_cpu_pre", 0,
> >> + COMPOSITE_NOMUX(SCLK_CRYPTO, "crypto", "aclk_cpu_pre", 0,
> >> RK3288_CLKSEL_CON(26), 6, 2, DFLAGS,
> >> RK3288_CLKGATE_CON(5), 4, GFLAGS),
> >> GATE(0, "aclk_bus_2pmu", "aclk_cpu_pre", CLK_IGNORE_UNUSED,
> >> diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock/rk3288-cru.h
> >> index c719aac..30dcd60 100644
> >> --- a/include/dt-bindings/clock/rk3288-cru.h
> >> +++ b/include/dt-bindings/clock/rk3288-cru.h
> >> @@ -86,6 +86,7 @@
> >> #define SCLK_USBPHY480M_SRC 122
> >> #define SCLK_PVTM_CORE 123
> >> #define SCLK_PVTM_GPU 124
> >> +#define SCLK_CRYPTO 125
> >>
> >> #define SCLK_MAC 151
> >> #define SCLK_MACREF_OUT 152
> >>
> >
> >
> >
>
>
>
next prev parent reply other threads:[~2015-11-12 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 6:35 [PATCH v3 0/4] crypto: add crypto accelerator support for rk3288 Zain Wang
2015-11-11 6:35 ` [PATCH v3 1/4] crypto: rockchip/crypto - add DT bindings documentation Zain Wang
[not found] ` <1447223759-20730-2-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-11 20:24 ` Rob Herring
2015-11-12 1:15 ` Zain
2015-11-11 6:35 ` [PATCH v3 2/4] clk: rockchip: set an ID for crypto clk Zain Wang
2015-11-11 23:57 ` Heiko Stuebner
2015-11-12 1:13 ` Zain
2015-11-12 8:40 ` Heiko Stuebner [this message]
2015-11-13 6:53 ` Zain
2015-11-11 6:35 ` [PATCH v3 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288 Zain Wang
[not found] ` <1447223759-20730-4-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-12 12:32 ` Heiko Stuebner
2015-11-13 6:44 ` Zain
[not found] ` <564586DB.1020401-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-11-14 22:41 ` Heiko Stuebner
2015-11-16 1:49 ` Zain
2015-11-11 6:35 ` [PATCH v3 4/4] ARM: dts: rockchip: Add Crypto node " Zain Wang
2015-11-12 10:00 ` Heiko Stuebner
2015-11-12 9:56 ` [PATCH v3 0/4] crypto: add crypto accelerator support " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1838616.4qxqO6ir89@phil \
--to=heiko@sntech.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai@rock-chips.com \
--cc=galak@codeaurora.org \
--cc=herbert@gondor.apana.org.au \
--cc=hl@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=zain.wang@rock-chips.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).