From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Linux-sh list <linux-sh@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa@sang-engineering.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree)
Date: Fri, 18 Dec 2015 10:06:48 +0100 [thread overview]
Message-ID: <1839177.77Qt0RnI3v@wuerfel> (raw)
In-Reply-To: <20151218073531.GA1517@katana>
On Friday 18 December 2015 08:35:32 Wolfram Sang wrote:
> >
> > It seems to me that we have some consensus around:
> >
> > compatible = "renesas,r1ex24002", "24c02";
>
> Thinking again, "generic,24c02" or "generic-24c02" could also be an
> option.
>
> > Should this be added to Documentation/devicetree/bindings/eeprom/eeprom.txt ?
> > Or documented elsewhere?
>
> Probably we need a DT maintainers advice here? I don't mind vendor
> specific compatibles being documented, but I'm reluctant to add all
> these compatibles for the myriads of I2C eeproms to the at24 driver. 99%
> are covered by the generic case.
>
> Adding DT to CC.
I'd rather use some vendor string in addition to 24c02. Isn't this originally
an Atmel part? In that case, using "atmel,24c02" as the most generic string
would be appropriate, and IIRC the i2c framework will just match that with
the "24c02" entry in the i2c_device_id list.
Arnd
next prev parent reply other threads:[~2015-12-18 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1449802376-11301-1-git-send-email-horms+renesas@verge.net.au>
[not found] ` <1449802376-11301-4-git-send-email-horms+renesas@verge.net.au>
[not found] ` <566AB2A5.4090105@cogentembedded.com>
[not found] ` <20151214021110.GD13945@verge.net.au>
[not found] ` <20151214071103.GC1516@katana>
[not found] ` <CAMuHMdXWcyEmoVRZuCTM4yqfxXYjgZF1yP8uqCEU8Bj=pmkNYw@mail.gmail.com>
[not found] ` <20151218030239.GB10973@verge.net.au>
2015-12-18 7:35 ` I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree) Wolfram Sang
2015-12-18 9:06 ` Arnd Bergmann [this message]
2015-12-18 10:32 ` Wolfram Sang
2015-12-21 4:33 ` Simon Horman
2015-12-21 8:02 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1839177.77Qt0RnI3v@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).