From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.19 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795157524; b=oV/eFi9P0XtvBkCXU54Gg43eyAXmSs0xX6IFUOAffllCX7Vdx8gz6c2ymzRqcYt0fNxt 4Is8zgriaA6ySjDPPSIzu4aTOhTPDmrEyLMLgRSOB7HJYc/FqHixiWIad5HWHn7Kbo46M SB05OJ7FONvoOgiyg6GySQ3l2FhkRzZkpdirMR0VjqE/GkRtUShX33tygeMxD1KnPaZfX PS5BtNjVzKJF+NOX6QzZq5PFswahdqZZCA4KYLwXhS4Y0X+kDRp1b9ybnvL30wCvHrdzC eXieeug8YwF9NHBLGtt28aJmwPehnUANLg+pn5zEEgJTQebqfjetaeDTXRu0dSaBKaA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795157524; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=0z0AzJNanfrVB85wgMFdgJJ5GkqCfeRb/cYUccsjyJg=; b=UeU04o31UMHcW8CtVMRVMhaWkbqO3Bf9oNmDYXXUEz59r1ySARlsJriDw+bCeIBv/YHj mceD6BakpfQ+QNjTvaPhzs8Fq3lOiGFFMQawlgRxsmEovlK+ANq+MTTpktrxbSqDQUZQa ZNunWilPPjBTt0oHwuXyG1ze+Cp2b6bxxQWckGxChwfR2vCND6f6XP3lDTWhnxVAH9LY/ PAv/bqugPoqSJHAg+6g73i/eJG/OQEQT5DPLWWxAQiPkTOUu6EY8Ovh/oWx92xDtexhoY IYWzo3OlphI7MlTMVr8dTZzwlN+xy+64NIbUCus74VWwLVJuxEnmegnv07fBHf21/wA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=jcMVexTx; arc=none smtp.remote-ip=91.218.175.19 Received: from mta0.migadu.com (out-19.mta0.migadu.com [91.218.175.19]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06E2A606A325 for ; Fri, 20 Nov 2026 06:52:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 06E2A606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=jcMVexTx X-Envelope-To: devicetree@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=Ro9VE7XGMtGJmsM9mnH8HIatHqmwaoWhZDuLhhpiHfI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795157521; v=1; x=1795762321; b=jcMVexTxKDTegToAManw+obcFWicIYkyNWBbQ8bHPCWoQIHS8oeNmQEtnoc/bqLFcE+AsWYk E5gvqiIkV2ACvfJguuJ26FIkKntFy9f//Qh74GihVulthqtUrTbP1pAWX2XuMuoeTRR35PbGo5H /3N2qFbMT7WVqAGzErsSYReM= X-Envelope-To: devicetree@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id ef437e63efd8efa5; Fri, 20 Nov 2026 06:52:00 +0000 X-Mizu-Trace-ID: ef437e63efd8efa5 X-Migadu-Flow: FLOW_OUT Message-ID: <18426bef-b231-4685-bda7-665becfc6528@linux.dev> Date: Fri, 20 Nov 2026 07:51:58 +0100 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 10/24] net: dsa: rzn1-a5psw: Fix MDIO clock divider calculation To: Prabhakar , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Simon Horman , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: Florian Fainelli , Ralph Siemsen , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org References: <20261120002549.1908299-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20261120002549.1908299-11-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Language: en-US From: Clement Leger In-Reply-To: <20261120002549.1908299-11-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/20/26 01:25, Prabhakar wrote: > From: Lad Prabhakar > > The MDC frequency is hclk / (2 * CLKDIV + 1) on RZ/N1 as well as > RZ/T2H and RZ/N2H. The existing calculation uses the wrong divisor > formula and can set MDC above the requested clock-frequency. > > Calculate the smallest CLKDIV that keeps MDC at or below the requested > frequency. > > Fixes: 888cdb892b61 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver") > Cc: stable@vger.kernel.org > Signed-off-by: Lad Prabhakar > --- > v4->v5: > - New patch > --- > drivers/net/dsa/rzn1_a5psw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c > index 7fd2652813ac..df3b3f75b489 100644 > --- a/drivers/net/dsa/rzn1_a5psw.c > +++ b/drivers/net/dsa/rzn1_a5psw.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1104,7 +1105,7 @@ static int a5psw_mdio_config(struct a5psw *a5psw, u32 mdio_freq) > u32 cfgstatus; > > rate = clk_get_rate(a5psw->hclk); > - div = ((rate / mdio_freq) / 2); > + div = DIV_ROUND_UP(DIV_ROUND_UP(rate, mdio_freq) - 1, 2); > if (div > FIELD_MAX(A5PSW_MDIO_CFG_STATUS_CLKDIV) || > div < A5PSW_MDIO_CLK_DIV_MIN) { > dev_err(a5psw->dev, "MDIO clock div %ld out of range\n", div); LGTM, Reviewed-by: Clément Léger Thanks, Clément