From: Javier Martinez Canillas <javierm@redhat.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org
Cc: "Ondrej Jirman" <megi@xff.cz>,
"Robert Mader" <robert.mader@posteo.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Maya Matuszczyk" <maccraft123mc@gmail.com>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Martijn Braam" <martijn@brixit.nl>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel controller
Date: Tue, 27 Dec 2022 11:46:08 +0100 [thread overview]
Message-ID: <1848f28f-6c6e-4a1c-b58b-ccd52ae723f8@redhat.com> (raw)
In-Reply-To: <f47cab97-2c8c-a3d5-b362-774f970dffd3@linaro.org>
Hello Krzysztof,
On 12/27/22 08:44, Krzysztof Kozlowski wrote:
[...]
>> +required:
>> + - compatible
>> + - vcc-supply
>> + - iovcc-supply
>> + - port
>
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
Indeed. I did test in v1 but forgot to do it after addressing your
comments for v2. I have fixed the example snippet now and done it:
$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTEX Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dts
DTC_CHK Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dtb
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-12-27 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 13:49 [PATCH v2 0/4] Add PinePhone Pro display support Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel controller Javier Martinez Canillas
2022-12-26 18:23 ` Rob Herring
2022-12-27 7:44 ` Krzysztof Kozlowski
2022-12-27 10:46 ` Javier Martinez Canillas [this message]
2022-12-26 13:49 ` [PATCH v2 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1848f28f-6c6e-4a1c-b58b-ccd52ae723f8@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=ayufan@ayufan.eu \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pbrobinson@gmail.com \
--cc=robert.mader@posteo.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).