From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434BBC4332F for ; Tue, 27 Dec 2022 10:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbiL0KrL (ORCPT ); Tue, 27 Dec 2022 05:47:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbiL0KrF (ORCPT ); Tue, 27 Dec 2022 05:47:05 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27DA0767A for ; Tue, 27 Dec 2022 02:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672137978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7BDaLx2vlolGs3dmZXimAfrXQipJ0Z8+AKbW5eVyvk=; b=EK4U9vPiMSNI79BohFvLAA9buAp+24ffV90WCn+0GdClL+22vjJw2vtWv7y260ubItlfL7 gBuxTv1W7JVNXOYEvEa90xTD58yu3bvsFTLqvJ6r2jXE+6eiI8fifGnjNdcArsfqkUFbqS MXd+SiFalLO0tQzgZtAecsTqmFDf3I0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-493-oFq9MRInMVq5zk35yMGhfA-1; Tue, 27 Dec 2022 05:46:11 -0500 X-MC-Unique: oFq9MRInMVq5zk35yMGhfA-1 Received: by mail-wm1-f70.google.com with SMTP id fm17-20020a05600c0c1100b003d96f0a7f2eso6336838wmb.6 for ; Tue, 27 Dec 2022 02:46:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u7BDaLx2vlolGs3dmZXimAfrXQipJ0Z8+AKbW5eVyvk=; b=QIpqG2+Owo0N8h8y6EVBAevUtdV2m12LQoxtKCD5IrZceyvSk+sgw8jnSJSVfusp+k V4opQTmiHe7FlRCd1p10UdeNiS0VrQUVsETcwHuzwH1EPYrNpWnWDwxCJlD1Jlbwy5lp xMwj2dNZ+QlDlFcLc1GuMbzSTNygBusNfNgLwTxF8ualcbNgmiTO0xgBlzOHEUU1gh14 bIaHlMB1oEZRp6XCaxC9AdKn4jDzEXHq3/dv63W38AoIFaseZYllRy1pkiHBwA6aRMhZ C0vIVrjSpeeEOWS/oJAwkBsVY1Ovk3QWo6qYyQLZdyG99rmi7utJVUBVfScT4rRRg8CQ l+eA== X-Gm-Message-State: AFqh2krvp/ISshwBZt07VbjLqmL8lzokVlksih+IGBwh0vAD0rL/P1MV Vr1wv8DCUssTRdJLgzgHB7FbYXDPXAHcxkQVpF9J6qIEiDUVVOMHUpiBbN0+OayRblWBZ7irlvq YcdeftB4uuJ/pPvNUgRpwzg== X-Received: by 2002:a5d:460d:0:b0:242:69f4:cb6a with SMTP id t13-20020a5d460d000000b0024269f4cb6amr11958153wrq.9.1672137970233; Tue, 27 Dec 2022 02:46:10 -0800 (PST) X-Google-Smtp-Source: AMrXdXvQS7Awi2feDRmYhRXXpgGINwihRjB8yjUFZf6u1fv0XYA4KBECYdgHzXt8AN8JgFECUhOuKA== X-Received: by 2002:a5d:460d:0:b0:242:69f4:cb6a with SMTP id t13-20020a5d460d000000b0024269f4cb6amr11958131wrq.9.1672137970031; Tue, 27 Dec 2022 02:46:10 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id z13-20020adff74d000000b002366f9bd717sm14444667wrp.45.2022.12.27.02.46.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 02:46:09 -0800 (PST) Message-ID: <1848f28f-6c6e-4a1c-b58b-ccd52ae723f8@redhat.com> Date: Tue, 27 Dec 2022 11:46:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel controller Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Ondrej Jirman , Robert Mader , Sam Ravnborg , Maya Matuszczyk , =?UTF-8?Q?Kamil_Trzci=c5=84ski?= , Martijn Braam , Peter Robinson , Tom Fitzhenry , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Rob Herring , Thierry Reding , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20221226134909.2822179-1-javierm@redhat.com> <20221226134909.2822179-3-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Krzysztof, On 12/27/22 08:44, Krzysztof Kozlowski wrote: [...] >> +required: >> + - compatible >> + - vcc-supply >> + - iovcc-supply >> + - port > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Indeed. I did test in v1 but forgot to do it after addressing your comments for v2. I have fixed the example snippet now and done it: $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTEX Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dts DTC_CHK Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dtb -- Best regards, Javier Martinez Canillas Core Platforms Red Hat