From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AFCECAAD4 for ; Tue, 30 Aug 2022 09:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231538AbiH3JfQ (ORCPT ); Tue, 30 Aug 2022 05:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbiH3JeE (ORCPT ); Tue, 30 Aug 2022 05:34:04 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6A5E58B0 for ; Tue, 30 Aug 2022 02:33:06 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id w8so5651336lft.12 for ; Tue, 30 Aug 2022 02:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Sg21c2U2EDU591BTmReyYxGtxFU2rdWH4lXcz9Jl/oQ=; b=UwZYN0UUvos+DFIuMcMKB3/g70v3pn0hSXod2WnobjsosLlxM6kc3MnjSquBQ4YB01 C8+4FlN6dJKloZ6tAHIniVANNjj2S3Uj7hAfJ121LePeGSAg8R2qs82XPu3yrtSqV5uB 4lr3R3VIprm4JwhjyDgYyHRY8lN5UKqy2h/RzKb1+6pOdBz7CQ6EHJK1tdSWmRhBk86x 2oDZpP8yBcbncwsxoHSVZiyT1xccZcfZzLIHwL5rQC748fggv06LdR34ktXRtdB8COQI T9wVYQ59zQ9ui9T/fcB0oxAaBSZWz5A+hGMm5QcuTJUwey65/YnoUEwSDp1fDyMZzA5b gMMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Sg21c2U2EDU591BTmReyYxGtxFU2rdWH4lXcz9Jl/oQ=; b=q5VgYTZVtIgwI0QR3cZcyopnxi6KI3TEGMiNIcJ46G/6Zd9SjXm0a1g8VJIIqXRXF6 MHuz5Ss7/7wapPDrB90B6zrtu0n6ZQ8hK7tBIOA89p7Mvm34t/+Sq9S0j+qQQM1GMzIA Wi+E4pC5cR8vxhkX85ynP6IHpL6Ne5wUaoWhvNXwBkzFcgn7ijMzp/vbT2PmdxQT2nJV QLO7OHIve2+i22gf4L4kXwy+LStcDytAjoHqPA88JhjMwbZP5fO95TQ/bF4OgGRRPtUS X1FB77CNEM3yFib2EuP1A+Fyi7W0YnR6neFw+sUKYImWmzwJIWfG1ZfcKHbcF5InB8g2 99ag== X-Gm-Message-State: ACgBeo2HUxvuVzkF1UgWZpYhJzilmHc7t9N6geH0tQ/SpCxi/6lbU3KA O8aNvPTLojSZjeVhls1zPY0ZhQ== X-Google-Smtp-Source: AA6agR5yh8X5BmKU4wxxWdgpsp/W/CNveRawwlV8nLGSOyxDU0ID2dkfzy1lRZaQcQkOIti+Cy+hYQ== X-Received: by 2002:ac2:5462:0:b0:48b:2a7b:3c15 with SMTP id e2-20020ac25462000000b0048b2a7b3c15mr7783055lfn.489.1661851981612; Tue, 30 Aug 2022 02:33:01 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id a13-20020ac2520d000000b0048a9603399csm1556472lfl.116.2022.08.30.02.33.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 02:33:01 -0700 (PDT) Message-ID: <184d4ff5-e80c-6a24-8071-0b0a69710685@linaro.org> Date: Tue, 30 Aug 2022 12:32:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker Content-Language: en-US To: Sheng-Liang Pan , LKML Cc: mka@chromium.org, dianders@chromium.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220830053307.3997495-1-sheng-liang.pan@quanta.corp-partner.google.com> <20220830133300.1.I7dd7a79c4cc5fe91c3feb004473feb3b34b7b2d8@changeid> From: Krzysztof Kozlowski In-Reply-To: <20220830133300.1.I7dd7a79c4cc5fe91c3feb004473feb3b34b7b2d8@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/08/2022 08:33, Sheng-Liang Pan wrote: > Add a basic device tree for the herobrine evoker board. > > Signed-off-by: Sheng-Liang Pan > --- > > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/sc7280-herobrine-evoker-r0.dts | 333 ++++++++++++++++++ > 2 files changed, 334 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 1d86a33de528c..59c22ba54a366 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts > new file mode 100644 > index 0000000000000..ccbe50b6249ab > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts > @@ -0,0 +1,333 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Evoker board device tree source > + * > + * Copyright 2022 Google LLC. > + */ > + > +/dts-v1/; > + > +#include "sc7280-herobrine.dtsi" > + > +/ { > + model = "Google Evoker"; > + compatible = "google,evoker", "qcom,sc7280"; Undocumented compatible. Please run scripts/checkpatch.pl and fix reported warnings. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > +}; > + > +/* > + * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES What does it mean and why it's SCREAMING? > + * > + * Sort order matches the order in the parent files (parents before children). Why? Sorting should be rather alphabetical. Best regards, Krzysztof