Re: [PATCH 1/2] dt-bindings: remoteproc: Add C906L rproc for Sophgo CV1800B SoC

["Junhui Liu" <junhui.liu@pigmoral.tech>]

Hi Rob,
Thanks for your review.

On 25/06/2025 14:16, Rob Herring wrote:
> On Sun, Jun 08, 2025 at 10:37:39AM +0800, Junhui Liu wrote:
>> Add C906L remote processor for CV1800B SoC, which is an asymmetric
>> processor typically running RTOS.
>> 
>> Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
>> ---
>>  .../bindings/remoteproc/sophgo,cv1800b-c906l.yaml  | 68 ++++++++++++++++++++++
>>  1 file changed, 68 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/remoteproc/sophgo,cv1800b-c906l.yaml b/Documentation/devicetree/bindings/remoteproc/sophgo,cv1800b-c906l.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..455e957dec01c16424c49ebe5ef451883b0c3d4a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/remoteproc/sophgo,cv1800b-c906l.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/remoteproc/sophgo,cv1800b-c906l.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Sophgo C906L remote processor controller for CV1800B SoC
>> +
>> +maintainers:
>> +  - Junhui Liu <junhui.liu@pigmoral.tech>
>> +
>> +description:
>> +  Document the bindings for the C906L remoteproc component that loads and boots
>> +  firmwares on the CV1800B SoC.
>> +
>> +properties:
>> +  compatible:
>> +    const: sophgo,cv1800b-c906l
>> +
>> +  firmware-name:
>> +    $ref: /schemas/types.yaml#/definitions/string
> 
> Already has a type. You just need 'maxItems: 1'.

Will do.

> 
>> +    description:
>> +      The name of the firmware file to load for this remote processor, relative
>> +      to the firmware search path (typically /lib/firmware/).
> 
> That's the same for every 'firmware-name' instance. So drop.
> 
> Is there a default name?

The firmware name would be specified in the board device tree, and
there is no default value. For reference, an example value is provided
in the example DT.

> 
>> +
>> +  memory-region:
> 
>        maxItems: 1

I plan to add a description for the rpmsg-related regions in the next
version. Since the number of these regions may be flexible, I think I
will only add a minItems property to ensure the execution memory
region is specified.

> 
>> +    description:
>> +      Phandle to a reserved memory region that is used to load the firmware for
>> +      this remote processor. The remote processor will use this memory region
>> +      as its execution memory.
>> +
>> +  resets:
>> +    maxItems: 1
>> +
>> +  sophgo,syscon:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description:
>> +      A phandle to the SEC_SYS region, used for configuration of the remote processor.
>> +
>> +required:
>> +  - compatible
>> +  - firmware-name
>> +  - memory-region
>> +  - resets
>> +  - sophgo,syscon
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    reserved-memory {
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +        ranges;
>> +
>> +        c906l_mem: region@83f40000 {
>> +            reg = <0x83f40000 0xc0000>;
>> +            no-map;
>> +        };
>> +    };
> 
> Drop. No need to show how /reserved-memory works here.

Will do.

> 
>> +
>> +    c906l-rproc {
>> +        compatible = "sophgo,cv1800b-c906l";
>> +        firmware-name = "c906l-firmware.elf";
>> +        memory-region = <&c906l_mem>;
>> +        resets = <&rst 294>;
>> +        sophgo,syscon = <&sec_sys>;
>> +    };
>> 
>>

-- 
Best regards,
Junhui Liu