From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<kernel@pengutronix.de>
Subject: Re: [PATCH v3 1/3] ARM: dts: stm32: add STM32MP1-based Phytec SoM
Date: Tue, 21 Jun 2022 14:27:35 +0200 [thread overview]
Message-ID: <184f3802-79af-206b-5b59-e063b9d12868@foss.st.com> (raw)
In-Reply-To: <20220621101538.481143-1-s.trumtrar@pengutronix.de>
On 6/21/22 12:15, Steffen Trumtrar wrote:
> The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB eMMC,
> up to 16 MB QSPI and up to 128 GB NAND flash.
>
> As multiple default pinctrls are overwritten, collect them in one place
> in stm32mp157c-phycore-stm32mp15-pinctrl.dtsi.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> Changes since v2:
> - /delete-property/dmas
> - fix dtbs_checks warnings
> - remove problematic+unused nodes
>
>
> arch/arm/boot/dts/Makefile | 3 +-
> ...stm32mp157c-phycore-stm32mp15-pinctrl.dtsi | 317 +++++++++
> .../stm32mp157c-phycore-stm32mp15-som.dtsi | 634 ++++++++++++++++++
> 3 files changed, 953 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
> create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 184899808ee7..de5c3cadb01a 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1213,7 +1213,8 @@ dtb-$(CONFIG_ARCH_STM32) += \
> stm32mp157c-ev1.dtb \
> stm32mp157c-ev1-scmi.dtb \
> stm32mp157c-lxa-mc1.dtb \
> - stm32mp157c-odyssey.dtb
> + stm32mp157c-odyssey.dtb \
> + stm32mp157c-phycore-stm32mp1-3.dtb
> dtb-$(CONFIG_MACH_SUN4I) += \
> sun4i-a10-a1000.dtb \
> sun4i-a10-ba10-tvbox.dtb \
> diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
> new file mode 100644
> index 000000000000..b0b590df43b6
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
> @@ -0,0 +1,317 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (C) Phytec GmbH 2019-2020 - All Rights Reserved
> + * Author: Dom VOVARD <dom.vovard@linrt.com>.
> + */
> +#include "stm32mp15-pinctrl.dtsi"
> +
Why do you create a dedicated file for Phytec ? all other SOM providers
or board providers add their pinctrl groups in stm32mp15-pinctrl.dtsi file.
Apart that, Krzysztof did all the review :) (thanks for that)
Alex
prev parent reply other threads:[~2022-06-21 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 10:15 [PATCH v3 1/3] ARM: dts: stm32: add STM32MP1-based Phytec SoM Steffen Trumtrar
2022-06-21 10:15 ` [PATCH v3 2/3] ARM: dts: stm32: add STM32MP1-based Phytec board Steffen Trumtrar
2022-06-21 12:20 ` Krzysztof Kozlowski
2022-06-21 10:15 ` [PATCH v3 3/3] dt-bindings: arm: stm32: Add Phytec STM32MP1 board Steffen Trumtrar
2022-06-21 12:05 ` Krzysztof Kozlowski
2022-06-21 12:20 ` Krzysztof Kozlowski
2022-06-21 12:18 ` [PATCH v3 1/3] ARM: dts: stm32: add STM32MP1-based Phytec SoM Krzysztof Kozlowski
2022-06-21 12:27 ` Alexandre TORGUE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184f3802-79af-206b-5b59-e063b9d12868@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).