From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FCD3242B0 for ; Fri, 10 Jul 2026 10:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680904; cv=none; b=ZD608s93eBKjEc2J4zabsxAqWw854meP8ikyqUYrEe2wiqh+19shhzji46epgpbTi1TFKrTYR0Ukvl9U8B2BMEvoI8d2qnGo+vi38JGdd9pZYDPOwOK9s7Kh4CHUMYWgJDkZ7i4hxupzF0XwQWuRDokk8dzSokDf2ut8+d9VGmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783680904; c=relaxed/simple; bh=Jc+cyW0SAXe60JSqWOsvka8eUS3RRaYLEvEnsVaDZaU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YSN9fKT6/YoOgwwC168O/zWdP8DflNWOp9JjkJqfSCx8iotCngwmr84lJNKEUi33vIKmWrl+2ziZvAU8sSij/dJcm0VEMEcSk0qR8PXY6dOjnEvCO4AaYq/k8PMcl/bX666dG0YWvA8oOBOXQGORrqguduKjkVrzlfizCXm3vm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A2SHe7cY; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A2SHe7cY" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-848593533cbso548523b3a.3 for ; Fri, 10 Jul 2026 03:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783680902; x=1784285702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=534LbVPyjYMVPj0BO46vzk6oyGda1cLHKL7+ZYYErcI=; b=A2SHe7cYRsiwO1lIeI/WbX1PADypli+s3N78ZJU1WKIey34CeB3g+xIbE7J/nXieis y6tN7rGqtzwFGpjmttLcuSmvefIongiM/oQdV8dNCuFaORUCcD/oLM+7X0S7Wk7XrxST kBUkLD73dyeerZ/P+z29GdUqBCaWUVTyNnkbsRkW7GGK1Cbni3HS5TvmKzfs2nPn+NZw 5QmqHGr5ldusnDgeHIgKWH7tbKGIVthvviffzlQRyYimlq8kSRrpmFdyFmoK49wB5V/G Fl4Q4qrj7T6EAot06midMMUJ7Yhb8leqJV81/tjzXNUlmDAZdLnz7Zy4jUskXZX1FB3P 29xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783680902; x=1784285702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=534LbVPyjYMVPj0BO46vzk6oyGda1cLHKL7+ZYYErcI=; b=sodhMleUMzeNwQmjouX54sodSSrSjJ316FM0BIgFxrsClKBRQu4CK7C7vKT21BbcMY zl9/BiwFcK+502uxEu3odqTe6Mn2iHc9mTjQKDl+oQUStuDZkdu2WZvrDCWrvdMJU2Os nH/1Heroa3+kqAxVphPfP0Wxc+aSecC86fFmT7rkIb42y8bDUjzSDFd0exO3T6AlRrwp lvJCsJYlSlFd9i0wLUI/Hgem8TJr+8UhkF4KyN67qRCDDre8Zy2Y8FTd1tOJ0OdpkJwD 1YORuEjJnIf5U6Gfs8NQXUSRaTmyDuh8Aqk6uYSe9xEV8nuS2JCiF+NCg2AR4jUi8Y0K jrPQ== X-Forwarded-Encrypted: i=1; AHgh+RprVJ7k11YrFrU3GshPkpICH7HTLzn6wtEj0wNliKtxZ4QvNa4lBKe3WOogQoTgk/tWb0s8P7zs9oCq@vger.kernel.org X-Gm-Message-State: AOJu0Yz4Rl+l/XqU/hZzgEqfE1YxDFeFxU4DthxztkY/nHoNEjHCSYu5 bBB7mlAd4ItgkfCG01IjPxF1CykFkJ4cpOs+JkKG0/ArxUhXU0mo7uWo X-Gm-Gg: AfdE7ck3jfja+fNbCbZh2eIsoZtWJYOm03IS8CqhKjV/EvaGIIu+oVvuBxqkEesPNBV 09U6o18vALghB8aBjjpYqqScoxauXeLKOihl7CGQ3/YJI/mLpckwIDpw7m2bPfkxnxfNIlDatDq 2kBbiLNBQrJ5I2p85wPnVOdLerCWXcA5P/1AhW2+i6C2uAmnPSDQOM3ERovKuvHG7wYOIpR/y6n ij7vDYOMetsjago3rz93tFFlyNFH+DNF+CpZSfNf1ywYDH+UO9Z3d+YBEDoAxW5lEenzTLji/cf mL7e71OPEPCSTtj+GQXMPGzxp0uMeWu5hVYlofx19xMH+RNmhxshVg5RASrCT15SvI9e90+QJeT BWoESY2sAqDxCPtX3Ge4Nmz6cATDJbWD+bNPpd8cuWgGW/5RcBzl1Yv2ZHZ//oTRr6phxJqbYii Qs1pYSgdh8dhM9mjfR0vgPvhHK8h1Gr1I= X-Received: by 2002:a05:6a21:6b01:b0:3bf:baed:c797 with SMTP id adf61e73a8af0-3c0bd0fa3d7mr13220654637.49.1783680901822; Fri, 10 Jul 2026 03:55:01 -0700 (PDT) Received: from DESKTOP-TIT0J8O.dm.ae ([49.47.198.15]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659c8572sm40752937c88.9.2026.07.10.03.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:55:01 -0700 (PDT) From: Ahmed Naseef To: netdev@vger.kernel.org Cc: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , "Chester A. Unal" , "David S. Miller" , Andrew Lunn , AngeloGioacchino Del Regno , Conor Dooley , DENG Qingfang , Daniel Golle , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Landen Chao , Matthias Brugger , Paolo Abeni , Rob Herring , Russell King , Sean Wang , Vladimir Oltean , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Ahmed Naseef Subject: [PATCH net-next 2/2] net: dsa: mt7530: add EN7528 support Date: Fri, 10 Jul 2026 14:54:24 +0400 Message-Id: <1865eaedef97e593ba608764c7390209cae85b30.1783680864.git.naseefkm@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The EcoNet EN7528 SoC integrates an MT7530 switch (the chip revision register reads 0x7530), memory-mapped in the SoC register space and reached through the same MMIO glue used for the built-in switches of the MediaTek MT7988 and Airoha EN7581/AN7583 SoCs. Its reset sequence and its PHY indirect access registers are the same as on those switches, so add an ID_EN7528 variant bound with the "econet,en7528-switch" compatible, reusing mt7988_setup() and the indirect PHY accessors. The switch core, however, is an MT7530 and not an MT7531 derivative: it has no MT7531 CFC register, and the CPU port to trap frames to is set through the MT7530-style CPU_EN / CPU_PORT fields of the MFC register, so add it to the MT7530 handling in mt753x_conduit_state_change(). For the same reason the MT7530 mirror and force-mode register layouts already apply to it as the default of the MT753X_*() macros. The four user ports (1-4) are connected to integrated Gigabit PHYs at MDIO addresses 9-12 of the switch internal MDIO bus. The CPU port (port 6) is connected to the SoC Ethernet MAC at a fixed 1000 Mbps full duplex link, so the port capabilities cannot be shared with the MT7988 and EN7581 switches, whose CPU ports run at 10 Gbps. The LAN GPHYs advertise EEE by default, but negotiating EEE with some link partners results in an unstable link with dropped frames. Disable EEE advertisement on them at setup time, like mt7531_setup() does for the MT7531 switch PHYs. Signed-off-by: Ahmed Naseef --- drivers/net/dsa/mt7530-mmio.c | 1 + drivers/net/dsa/mt7530.c | 56 ++++++++++++++++++++++++++++++++++- drivers/net/dsa/mt7530.h | 1 + 3 files changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530-mmio.c b/drivers/net/dsa/mt7530-mmio.c index 1dc8b93fb51a..1065671bcdd1 100644 --- a/drivers/net/dsa/mt7530-mmio.c +++ b/drivers/net/dsa/mt7530-mmio.c @@ -13,6 +13,7 @@ static const struct of_device_id mt7988_of_match[] = { { .compatible = "airoha,an7583-switch", .data = &mt753x_table[ID_AN7583], }, { .compatible = "airoha,en7581-switch", .data = &mt753x_table[ID_EN7581], }, + { .compatible = "econet,en7528-switch", .data = &mt753x_table[ID_EN7528], }, { .compatible = "mediatek,mt7988-switch", .data = &mt753x_table[ID_MT7988], }, { /* sentinel */ }, }; diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 3c2a3029b10c..2aecad77af9a 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2912,6 +2912,30 @@ static void en7581_mac_port_get_caps(struct dsa_switch *ds, int port, } } +static void en7528_mac_port_get_caps(struct dsa_switch *ds, int port, + struct phylink_config *config) +{ + switch (port) { + /* Ports which are connected to switch PHYs. There is no MII pinout. */ + case 1 ... 4: + __set_bit(PHY_INTERFACE_MODE_INTERNAL, + config->supported_interfaces); + + config->mac_capabilities |= MAC_10 | MAC_100 | MAC_1000FD; + break; + + /* Port 6 is connected to SoC's GMAC at 1000 Mbps full duplex. There + * is no MII pinout. + */ + case 6: + __set_bit(PHY_INTERFACE_MODE_INTERNAL, + config->supported_interfaces); + + config->mac_capabilities |= MAC_1000FD; + break; + } +} + static void mt7530_mac_config(struct dsa_switch *ds, int port, unsigned int mode, phy_interface_t interface) @@ -3254,7 +3278,8 @@ mt753x_conduit_state_change(struct dsa_switch *ds, * forwarded to the numerically smallest CPU port whose conduit * interface is up. */ - if (priv->id != ID_MT7530 && priv->id != ID_MT7621) + if (priv->id != ID_MT7530 && priv->id != ID_MT7621 && + priv->id != ID_EN7528) return; mask = BIT(cpu_dp->index); @@ -3319,9 +3344,17 @@ static int mt753x_setup_tc(struct dsa_switch *ds, int port, } } +/* The EN7528 LAN ports are integrated GPHYs at MDIO addresses 9..12 (switch + * ports 1..4) on the switch internal MDIO bus, reachable only through the PHY + * indirect access registers. There is no mdiodev to derive the addresses from. + */ +#define EN7528_GPHY_BASE 9 +#define EN7528_NUM_GPHYS 4 + static int mt7988_setup(struct dsa_switch *ds) { struct mt7530_priv *priv = ds->priv; + int i; /* Reset the switch */ reset_control_assert(priv->rstc); @@ -3342,6 +3375,17 @@ static int mt7988_setup(struct dsa_switch *ds) /* Reset the switch PHYs */ mt7530_write(priv, MT7530_SYS_CTRL, SYS_CTRL_PHY_RST); + /* The EN7528 LAN GPHYs advertise EEE by default, but negotiating EEE + * with common link partners (e.g. Realtek GbE NICs) results in an + * unstable link with dropped frames. Disable EEE advertisement on + * them. + */ + if (priv->id == ID_EN7528) + for (i = EN7528_GPHY_BASE; + i < EN7528_GPHY_BASE + EN7528_NUM_GPHYS; i++) + mt7531_ind_c45_phy_write(priv, i, MDIO_MMD_AN, + MDIO_AN_EEE_ADV, 0); + return mt7531_setup_common(ds); } @@ -3459,6 +3503,16 @@ const struct mt753x_info mt753x_table[] = { .phy_write_c45 = mt7531_ind_c45_phy_write, .mac_port_get_caps = en7581_mac_port_get_caps, }, + [ID_EN7528] = { + .id = ID_EN7528, + .pcs_ops = &mt7530_pcs_ops, + .sw_setup = mt7988_setup, + .phy_read_c22 = mt7531_ind_c22_phy_read, + .phy_write_c22 = mt7531_ind_c22_phy_write, + .phy_read_c45 = mt7531_ind_c45_phy_read, + .phy_write_c45 = mt7531_ind_c45_phy_write, + .mac_port_get_caps = en7528_mac_port_get_caps, + }, }; EXPORT_SYMBOL_GPL(mt753x_table); diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h index dd33b0df3419..5f1e841f42c0 100644 --- a/drivers/net/dsa/mt7530.h +++ b/drivers/net/dsa/mt7530.h @@ -21,6 +21,7 @@ enum mt753x_id { ID_MT7988 = 3, ID_EN7581 = 4, ID_AN7583 = 5, + ID_EN7528 = 6, }; #define NUM_TRGMII_CTRL 5 -- 2.34.1