From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFECBC7EE22 for ; Mon, 8 May 2023 19:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232580AbjEHTzr (ORCPT ); Mon, 8 May 2023 15:55:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbjEHTzo (ORCPT ); Mon, 8 May 2023 15:55:44 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1556A7A for ; Mon, 8 May 2023 12:55:19 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-50bd37ca954so52236207a12.0 for ; Mon, 08 May 2023 12:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683575715; x=1686167715; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T6K8tZRHm3ktbeHIa7Lnv7wLaqb40G7qOij8yLE39M0=; b=HFQbA/Rp4/5v4RTxWhltNJ+enPCVmZ0mOdENcDnhdh75dD7SDjs9AS2C+A1dDEGEDM czgk20ZOaoEl+dmKGAWJ4hdxgsCNct9v2VHGNxrj8x/nfG2MdRHyErmkRfPI60itdcQD eduWo+/Egv3YtARV2Rkt5jitJxjbD5RrE7aFkG0RHCKeVB5LQNn/AWoWywuvFPMiUhAH gVCJN/zV+acQANIH3o83420zdctQZtpNl5uYi8SBi4L19BayPTcrXBEOtRWxwiC6s3Sj c2tRnOCGz++7c4MseTyioH63xRs2Jdy52lUPFemSRlSQcgsvnWrsGaYPPuGJnpOAuiCy AsZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683575715; x=1686167715; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T6K8tZRHm3ktbeHIa7Lnv7wLaqb40G7qOij8yLE39M0=; b=Ce1tJXtGn2wy7LbJ1bOYFGJnIcMb+Y4M4x/05X/vp2l6XxHCBIARG6zmKgpe7kgiwY uQYLmJnJGpxx/mQwWWnUIQ/w+hkun5NVJ+NEimLysRcKkwGsZU72iaD+7nOq8oRcWs80 Q7PRBIleUsRYq6JLRS6hGB4rgPFt/aw1d4DW4Jlaez4FoZQN8wE0oc3+/Cr9opPN4fQ1 Md0vvcHUoKQm1tCcVeqxGinSusXCxxpZ7FceQoCXGOUTaKvxUPBJYzO7afQw5c+D4EFV U8ueOW3u3fP9klvpFi2WVe9agQBRBHI7Q1XNXPACvfjTwDBl4kVzz9xopwed3/ZLPAoI DIbA== X-Gm-Message-State: AC+VfDyGpbXtcSl2hh3RJdJG35yslywBgwJiFeyQdoI1SI5lOGIGSRn+ lEGGS5UlawKv7d4Dq5+F4xCKBQ== X-Google-Smtp-Source: ACHHUZ7Jjn3I+hqyy58I0ppJxc2pCFSnM+O7DU4Mz6qp5o5RVfk+JoJq3v6bNCtOXITFMgbwEPsHsQ== X-Received: by 2002:a50:ed95:0:b0:50d:a804:423 with SMTP id h21-20020a50ed95000000b0050da8040423mr3155042edr.10.1683575714964; Mon, 08 May 2023 12:55:14 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d19b:4e0f:cfe4:a1ac? ([2a02:810d:15c0:828:d19b:4e0f:cfe4:a1ac]) by smtp.gmail.com with ESMTPSA id c19-20020aa7d613000000b0050488d1d376sm6461191edr.0.2023.05.08.12.55.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 12:55:14 -0700 (PDT) Message-ID: <186bc2b0-21e6-9fae-a273-ec71268bf95c@linaro.org> Date: Mon, 8 May 2023 21:55:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/7] dt-bindings: power: supply: max77658: Add ADI MAX77654/58/59 Charger Content-Language: en-US From: Krzysztof Kozlowski To: Zeynep Arslanbenzer , lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sre@kernel.org, lgirdwood@gmail.com, broonie@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Nurettin Bolucu References: <20230508131045.9399-1-Zeynep.Arslanbenzer@analog.com> <20230508131045.9399-3-Zeynep.Arslanbenzer@analog.com> <222ed4ee-4122-7ea8-5d94-69976f247599@linaro.org> In-Reply-To: <222ed4ee-4122-7ea8-5d94-69976f247599@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 21:45, Krzysztof Kozlowski wrote: > On 08/05/2023 15:10, Zeynep Arslanbenzer wrote: >> Add ADI MAX77654/58/59 power supply devicetree document. >> >> Signed-off-by: Nurettin Bolucu >> Signed-off-by: Zeynep Arslanbenzer >> --- >> .../power/supply/adi,max77658-charger.yaml | 53 +++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/adi,max77658-charger.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/supply/adi,max77658-charger.yaml b/Documentation/devicetree/bindings/power/supply/adi,max77658-charger.yaml >> new file mode 100644 >> index 000000000000..1b487d82cdbf >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/adi,max77658-charger.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/supply/adi,max77658-charger.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Battery charger for MAX77658 PMICs family from ADI >> + >> +maintainers: >> + - Nurettin Bolucu >> + - Zeynep Arslanbenzer >> + >> +description: | >> + This module is part of the MAX77658 MFD device. For more details >> + see Documentation/devicetree/bindings/mfd/adi,max77658.yaml. >> + >> + The charger is represented as a sub-node of the PMIC node on the device tree. >> + >> +properties: >> + compatible: >> + enum: >> + - adi,max77654-charger >> + - adi,max77658-charger >> + - adi,max77659-charger > > What are the differences between them? Driver suggests they are > compatible. Your match data is empty there. > >> + >> + adi,input-current-limit-microamp: >> + description: Input current limit value. > > Your description is an exact copy of property name. That's not helpful. > What do you limit? Total current? Charging current? Top-off current? > > You have default value, why it is not here? minimum/maximum? > BTW, this is duplicating constant-charge-current-max-microamp. If it has different meaning, you need to explain this in description, not just say what property name is saying. Best regards, Krzysztof