From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board Date: Sat, 22 Jun 2019 10:33:57 +0200 Message-ID: <1871177.hjLhdHVgcu@phil> References: <20190621180017.29646-1-katsuhiro@katsuster.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190621180017.29646-1-katsuhiro@katsuster.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Katsuhiro Suzuki Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, Am Freitag, 21. Juni 2019, 20:00:17 CEST schrieb Katsuhiro Suzuki: > This patch adds missing mdio and ethernet PHY nodes for rk3328 ASUS > tinker board. > > Signed-off-by: Katsuhiro Suzuki just for my understanding, which problem does this solve? Normally the gmac can establish connections just fine on the rk3288 by probing the phy in the automatic way. And I also don't see any additional properties like phy interrupt line below. Thanks Heiko > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi > index 293576869546..3190817e8d5d 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -117,6 +117,7 @@ > assigned-clocks = <&cru SCLK_MAC>; > assigned-clock-parents = <&ext_gmac>; > clock_in_out = "input"; > + phy-handle = <&phy0>; > phy-mode = "rgmii"; > phy-supply = <&vcc33_lan>; > pinctrl-names = "default"; > @@ -127,6 +128,17 @@ > tx_delay = <0x30>; > rx_delay = <0x10>; > status = "ok"; > + > + mdio0 { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy0: ethernet-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0>; > + }; > + }; > }; > > &gpu { >