From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vineeth Karumanchi <vineeth.karumanchi@amd.com>,
git@amd.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, harini.katakam@amd.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
michal.simek@amd.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: xilinx_gmii2rgmii: Add clock support
Date: Sun, 19 May 2024 19:33:20 +0200 [thread overview]
Message-ID: <18746508-f7d6-4a1c-9758-1e9e1fb35c64@kernel.org> (raw)
In-Reply-To: <20240517054745.4111922-2-vineeth.karumanchi@amd.com>
On 17/05/2024 07:47, Vineeth Karumanchi wrote:
> Add input clock support to gmii_to_rgmii IP.
> Add "clocks" bindings for the input clock.
Both sentences look like saying the same... confused.
>
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
> ---
> Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> index 0f781dac6717..672bff6dae28 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> @@ -31,6 +31,9 @@ properties:
> phy-handle:
> $ref: ethernet-controller.yaml#/properties/phy-handle
>
> + clocks:
> + description: 200/375 MHz free-running clock is used as input clock.
Missing constraints. Probably you wanted items above description.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-19 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 5:47 [PATCH net-next v2 0/2] net: xilinx_gmii2rgmii: Add clock support Vineeth Karumanchi
2024-05-17 5:47 ` [PATCH net-next v2 1/2] dt-bindings: " Vineeth Karumanchi
2024-05-19 17:33 ` Krzysztof Kozlowski [this message]
2024-05-17 5:47 ` [PATCH net-next v2 2/2] net: phy: xilinx-gmii2rgmii: Adopt " Vineeth Karumanchi
2024-05-17 19:25 ` [PATCH net-next v2 0/2] net: xilinx_gmii2rgmii: Add " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18746508-f7d6-4a1c-9758-1e9e1fb35c64@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).