From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9858FC433FE for ; Mon, 14 Nov 2022 10:06:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236067AbiKNKGc (ORCPT ); Mon, 14 Nov 2022 05:06:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236045AbiKNKGE (ORCPT ); Mon, 14 Nov 2022 05:06:04 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F60E1B7AA for ; Mon, 14 Nov 2022 02:05:23 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id x21so12451629ljg.10 for ; Mon, 14 Nov 2022 02:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cfRX3g/NtBq3w4tEHVjl1jodzyu5oFmoKHMbIbqQo4g=; b=d+ZTCaTPAU579Spu4kWghS5tq8TMv4picADoN4EGwO0AWo3xyGnrjnA7HUi9rassL6 HL7dwyOsqwVcuN73ZxWhpVCU6jQXwkt9QX7y4CDoVHHPs5N1s2Iv+7O+GfBg9RdKYvsG w4DkWFR2xX6SeQ3vhJhBpccHOKYh1d+jcxZ+0+pzfbOwTQYHAg9eMwsOUr9SoVFe2BGm oCf15R1heYXsCxZGpufLvfe/tU6ZEuiDkWKtU782J82MkESlz4NloXfwNth7e8rdQAUP zwrV73RgzSNGAdWcGBsjHAcO7devz9fhlkd3d+Dfl/tuGroB3WfwgjAf3rnh9AWUztuS 8I4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cfRX3g/NtBq3w4tEHVjl1jodzyu5oFmoKHMbIbqQo4g=; b=L4Z4pFwD+7jBdX03fbNYLy9TqluVl9VjjIzMoACj1fCpv3+KAKhX4X8PPXgGA7L71/ 40R5Xpp3ygkV0Q/da93O5ON+ybWlkQJGMtBVk1Sm5obH6gW+TVspC8FTco3BjdQvLvYK 006SS1YQEK2SmWz9g95Qgo6GvZR/gbgRTosaWcE8G/aakkswYfxSq4NGdn+xxc3VNJqX cvMbUzS2+ASNQLn0e7PrjQGb4cdm6osrYMdYp3tye8fwOb04Ju9qE64O99oxGqaxanZn PIE0Hu8ZnDvqnD8tti1l4IAJq7IqXAqFptvRZaJO/iskeiytXxb6Jn3YVK+CYqF9iY+x FWCA== X-Gm-Message-State: ANoB5pnAQgbBz9Abh+JvTGlL0/GBnSi4Ig0NLjGQa6oG/5NI8WWU2/R1 LN9XvW1SOu8oGxnTe2zpDJWXUQ== X-Google-Smtp-Source: AA0mqf7Gx9mFBfzDWdMSvmHbxk8CYP6QvpPOPCWZ7ID08Q044mOh49S4ncmgaLlDhh6p/Cpk/HeLrg== X-Received: by 2002:a2e:a9a7:0:b0:26e:5b4:52ee with SMTP id x39-20020a2ea9a7000000b0026e05b452eemr3622404ljq.460.1668420322022; Mon, 14 Nov 2022 02:05:22 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id d13-20020ac244cd000000b004ac980a1ba1sm1765646lfm.24.2022.11.14.02.05.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 02:05:21 -0800 (PST) Message-ID: <1877eadd-e1c9-c08b-4e47-8b902a8b7dd9@linaro.org> Date: Mon, 14 Nov 2022 11:05:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7 hardware for Exynos 3250 SoC Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221114054655.68090-1-aakarsh.jain@samsung.com> <20221114054655.68090-3-aakarsh.jain@samsung.com> <000001d8f80d$bdf7b320$39e71960$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <000001d8f80d$bdf7b320$39e71960$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/11/2022 10:44, Aakarsh Jain wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: 14 November 2022 13:22 >> To: Aakarsh Jain ; linux-arm- >> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; devicetree@vger.kernel.org >> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com; >> benjamin.gaignard@collabora.com; krzysztof.kozlowski+dt@linaro.org; >> stanimir.varbanov@linaro.org; dillon.minfei@gmail.com; >> david.plowman@raspberrypi.com; mark.rutland@arm.com; >> robh+dt@kernel.org; krzk+dt@kernel.org; andi@etezian.org; >> alim.akhtar@samsung.com; aswani.reddy@samsung.com; >> pankaj.dubey@samsung.com; smitha.t@samsung.com >> Subject: Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7 >> hardware for Exynos 3250 SoC >> >> On 14/11/2022 06:46, Aakarsh Jain wrote: >>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for >> >> Please run scripts/checkpatch.pl and fix reported warnings. >> > Do you mean warnings on "5441e9dafdfc6dc40fa" commit? Or on this patch? > > I am running like this : ./scripts/checkpatch.pl patch_file, it does not show any warnings. > > or am I missing anything while running checkpatch on the current patch? Eh, you're right... checkpatch does not catch it. You need to fix syntax - drop quotes, use proper commit title: https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/process/submitting-patches.rst#L100 Best regards, Krzysztof