From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms+renesas@verge.net.au>,
Magnus Damm <damm@opensource.se>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines
Date: Mon, 12 May 2014 21:48:59 +0200 [thread overview]
Message-ID: <1879564.Q0Zk545mJH@avalon> (raw)
In-Reply-To: <1399920573-30947-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Monday 12 May 2014 20:49:33 Geert Uytterhoeven wrote:
> R-Car M2 has two MSTP bits for SYS-DMAC, not one.
> Also bring the naming in sync with the documentation.
>
> This issue was introduced in v3.14, in commit
> 4d8864c9e94ec727f1c675b9f6921525c360334b ("ARM: shmobile: r8a7791: Add
> clock index macros for DT sources").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> I believe there are no users of the incorrect definition.
> ---
> include/dt-bindings/clock/r8a7791-clock.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/r8a7791-clock.h
> b/include/dt-bindings/clock/r8a7791-clock.h index
> 29b0f3355ffb..b050d18437ce 100644
> --- a/include/dt-bindings/clock/r8a7791-clock.h
> +++ b/include/dt-bindings/clock/r8a7791-clock.h
> @@ -43,7 +43,8 @@
> #define R8A7791_CLK_SCIFB1 7
> #define R8A7791_CLK_MSIOF1 8
> #define R8A7791_CLK_SCIFB2 16
> -#define R8A7791_CLK_DMAC 18
> +#define R8A7791_CLK_SYS_DMAC1 18
> +#define R8A7791_CLK_SYS_DMAC0 19
>
> /* MSTP3 */
> #define R8A7791_CLK_TPU0 4
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-05-12 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 18:49 [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines Geert Uytterhoeven
2014-05-12 19:48 ` Laurent Pinchart [this message]
2014-05-13 1:17 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1879564.Q0Zk545mJH@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=damm@opensource.se \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).