* [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines
@ 2014-05-12 18:49 Geert Uytterhoeven
2014-05-12 19:48 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-05-12 18:49 UTC (permalink / raw)
To: Laurent Pinchart, Simon Horman, Magnus Damm
Cc: linux-sh, devicetree, Geert Uytterhoeven
R-Car M2 has two MSTP bits for SYS-DMAC, not one.
Also bring the naming in sync with the documentation.
This issue was introduced in v3.14, in commit
4d8864c9e94ec727f1c675b9f6921525c360334b ("ARM: shmobile: r8a7791: Add
clock index macros for DT sources").
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
I believe there are no users of the incorrect definition.
---
include/dt-bindings/clock/r8a7791-clock.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/r8a7791-clock.h b/include/dt-bindings/clock/r8a7791-clock.h
index 29b0f3355ffb..b050d18437ce 100644
--- a/include/dt-bindings/clock/r8a7791-clock.h
+++ b/include/dt-bindings/clock/r8a7791-clock.h
@@ -43,7 +43,8 @@
#define R8A7791_CLK_SCIFB1 7
#define R8A7791_CLK_MSIOF1 8
#define R8A7791_CLK_SCIFB2 16
-#define R8A7791_CLK_DMAC 18
+#define R8A7791_CLK_SYS_DMAC1 18
+#define R8A7791_CLK_SYS_DMAC0 19
/* MSTP3 */
#define R8A7791_CLK_TPU0 4
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines
2014-05-12 18:49 [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines Geert Uytterhoeven
@ 2014-05-12 19:48 ` Laurent Pinchart
2014-05-13 1:17 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-12 19:48 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Simon Horman, Magnus Damm, linux-sh, devicetree
Hi Geert,
Thank you for the patch.
On Monday 12 May 2014 20:49:33 Geert Uytterhoeven wrote:
> R-Car M2 has two MSTP bits for SYS-DMAC, not one.
> Also bring the naming in sync with the documentation.
>
> This issue was introduced in v3.14, in commit
> 4d8864c9e94ec727f1c675b9f6921525c360334b ("ARM: shmobile: r8a7791: Add
> clock index macros for DT sources").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> I believe there are no users of the incorrect definition.
> ---
> include/dt-bindings/clock/r8a7791-clock.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/r8a7791-clock.h
> b/include/dt-bindings/clock/r8a7791-clock.h index
> 29b0f3355ffb..b050d18437ce 100644
> --- a/include/dt-bindings/clock/r8a7791-clock.h
> +++ b/include/dt-bindings/clock/r8a7791-clock.h
> @@ -43,7 +43,8 @@
> #define R8A7791_CLK_SCIFB1 7
> #define R8A7791_CLK_MSIOF1 8
> #define R8A7791_CLK_SCIFB2 16
> -#define R8A7791_CLK_DMAC 18
> +#define R8A7791_CLK_SYS_DMAC1 18
> +#define R8A7791_CLK_SYS_DMAC0 19
>
> /* MSTP3 */
> #define R8A7791_CLK_TPU0 4
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines
2014-05-12 19:48 ` Laurent Pinchart
@ 2014-05-13 1:17 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2014-05-13 1:17 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Geert Uytterhoeven, Magnus Damm, linux-sh, devicetree
On Mon, May 12, 2014 at 09:48:59PM +0200, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Monday 12 May 2014 20:49:33 Geert Uytterhoeven wrote:
> > R-Car M2 has two MSTP bits for SYS-DMAC, not one.
> > Also bring the naming in sync with the documentation.
> >
> > This issue was introduced in v3.14, in commit
> > 4d8864c9e94ec727f1c675b9f6921525c360334b ("ARM: shmobile: r8a7791: Add
> > clock index macros for DT sources").
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > I believe there are no users of the incorrect definition.
Thanks, I will queue this up.
As there are it does not seem to be very urgent so I will target
it at v3.16.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 1:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 18:49 [PATCH] ARM: shmobile: r8a7791: Correct SYS-DMAC clock defines Geert Uytterhoeven
2014-05-12 19:48 ` Laurent Pinchart
2014-05-13 1:17 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).