From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CF8C77B76 for ; Fri, 14 Apr 2023 21:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbjDNVsC (ORCPT ); Fri, 14 Apr 2023 17:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229895AbjDNVsB (ORCPT ); Fri, 14 Apr 2023 17:48:01 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34044212A for ; Fri, 14 Apr 2023 14:48:00 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-504eb1155d3so13506872a12.1 for ; Fri, 14 Apr 2023 14:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681508878; x=1684100878; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3EVZPS7cfZtkMpVcoeHTNj5NWFzlcFiikQhX7e7eo7s=; b=oIKjcQ5bA3LZIj+MtHEU4gp7gZWetvnXUBlEDfdBhf7gL5Wvs1HRCG4FPxaBqH8pso 3zrd/j511kb7/GQPqGXt3D0rqQs66pkRdbbuW/7dg9EMolAo0k2q2HuU3oqzxbdWV1vH zQtK1kl2NepczBZdGgiesQcpnBqc03G4wnYMZy54qu3cI59KWI98u+w+tCFH360uBQ+L 71+vf6AESb5obKm+RLh1gPoDojrdB564W6QtGpu42eRNOmzAoHSSwjFKJ3PwAuBA5+UC kdm6pGp14QECBMnHonGDtPmgSX+/YDkKsqDlSZ6sLueUzF9e0e7kzgSbOLBDnzxjUVdH R6YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681508878; x=1684100878; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3EVZPS7cfZtkMpVcoeHTNj5NWFzlcFiikQhX7e7eo7s=; b=J6BfV5prxnFzM+xIorH+kl3cuKujTfksAQul/N0Evhs2p02iwrAIORojcQgYrjZrXH INSB+CmA78ZRL3gvvDutdZRoFfutn4n2WPAuSrMd55GnrGswpoPKnJZOX2O395YB5lH9 ewnXCDtwKVB+P2vNgt3gbfgNnnBbTxvyZLZORwfzkjkpzv8okynSW4D697AtA9C+0etC 5wgojCgT7yVpsmnHGlEMcena6Jg/Jc2fT1oVbYMSwxHPjVxnhHKRDCQTZ3HOr6KD6ZxI ekRUpOXdviJ/ETw/txoFEtB7p5qAnM/yyT0uw9FCgfXKxl7j70IJwdtPPfJtgYLfeYQ1 TvGg== X-Gm-Message-State: AAQBX9dhG4Wbi+XebsUGFduYhmXi19OZqe5NRptOHhl5Rz6aMJdQW8Ne OGgMYDcVNNvbyuX4/o7aZsxIxg== X-Google-Smtp-Source: AKy350Zd7mIwQhRcrPhJL46mGi+B2WmInMBjqPo7ce+h/92m7V5Dbt/VUSCHLDLUeD0k87Zjl8iA/w== X-Received: by 2002:a05:6402:114e:b0:504:9e79:e86f with SMTP id g14-20020a056402114e00b005049e79e86fmr7272505edw.18.1681508878492; Fri, 14 Apr 2023 14:47:58 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ffae:8aab:ae5a:4688? ([2a02:810d:15c0:828:ffae:8aab:ae5a:4688]) by smtp.gmail.com with ESMTPSA id c18-20020aa7c752000000b00501d73cfc86sm2562459eds.9.2023.04.14.14.47.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 14:47:58 -0700 (PDT) Message-ID: <187d51b3-6fec-7a25-e472-3d9020c12db5@linaro.org> Date: Fri, 14 Apr 2023 23:47:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 01/10] dt-bindings: thermal: tegra: Document throttle temperature Content-Language: en-US To: Thierry Reding , Daniel Lezcano , "Rafael J . Wysocki" , Rob Herring , Krzysztof Kozlowski Cc: Amit Kucheria , Zhang Rui , Jon Hunter , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org References: <20230414125721.1043589-1-thierry.reding@gmail.com> <20230414125721.1043589-2-thierry.reding@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230414125721.1043589-2-thierry.reding@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2023 14:57, Thierry Reding wrote: > From: Thierry Reding > > Each throttling configuration needs to specify the temperature threshold > at which it should start throttling. Previously this was tied to a given > trip point as a cooling device and used the temperature specified for > that trip point. This doesn't work well because the throttling mechanism > is not a cooling device in the traditional sense. > > Instead, allow device trees to specify the throttle temperature in the > throttle configuration directly so that the throttle doesn't need to be > exposed as a cooling device. > > Signed-off-by: Thierry Reding > --- > .../bindings/thermal/nvidia,tegra124-soctherm.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.yaml b/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.yaml > index 4677ad6645a5..37dac851f486 100644 > --- a/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.yaml > +++ b/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.yaml File does not exist in next and no dependency is mentioned, so tricky to review and figure out context. Without context the comment is: > @@ -120,6 +120,13 @@ properties: > # high (85%, TEGRA_SOCTHERM_THROT_LEVEL_HIGH) > - 3 > > + temperature: > + $ref: /schemas/types.yaml#/definitions/int32 Use -millicelsius suffix instead: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml > + minimum: -273000 > + maximum: 200000 > + description: The temperature threshold (in millicelsius) that, > + when crossed, will trigger the configured automatic throttling. Don't you want some hysteresis? Or is it already using trips binding? But in that case you should skip the $ref and maximum - they come from thermal-zones, don't they? Best regards, Krzysztof