From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Ganapatrao Kulkarni
<gkulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Will.Deacon-5wv7dgnIgG8@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
steve.capper-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jchandra-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [RFC PATCH v4 3/4] arm64:thunder: Add initial dts for Cavium's Thunder SoC in 2 Node topology.
Date: Thu, 22 Jan 2015 19:26:09 +0100 [thread overview]
Message-ID: <1885509.Z0Gm3e3FlX@wuerfel> (raw)
In-Reply-To: <2882934.brFyhkGPyE@wuerfel>
On Thursday 22 January 2015 17:47:13 Arnd Bergmann wrote:
>
> This seems wrong still: The clusters and cores do not have unique
> numbers. I believe the code will not work correctly, and it won't
> be compliant with the binding from patch 2.
>
> I think the right way here would be to use
>
> arm,associativity = <0 2 47>;
>
> for cpu@20f, and
>
> arm,associativity = <1 3 48>;
>
> for cpu@10000. Your previous version used the numbers from
> the reg property, which should be fine as well if that helps:
>
>
> arm,associativity = <0x0 0x200 0x20f>;
>
> arm,associativity = <0x10000 0x10000 0x10000>;
>
> which should have the same effect as above, as long as the code
> can handle the numbers not being consecutive.
>
>
Upon further consideration, I think your patch is correct after
all, but let me check again on PowerPC machines.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-22 18:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 11:05 [RFC PATCH v4 0/4] arm64:numa: Add numa support for arm64 platforms Ganapatrao Kulkarni
[not found] ` <1421924755-26029-1-git-send-email-gkulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2015-01-22 11:05 ` [RFC PATCH v4 1/4] arm64: defconfig: increase NR_CPUS range to 2-4096 Ganapatrao Kulkarni
2015-01-22 11:05 ` [RFC PATCH v4 2/4] Documentation: arm64/arm: dt bindings for numa Ganapatrao Kulkarni
2015-01-22 11:05 ` [RFC PATCH v4 3/4] arm64:thunder: Add initial dts for Cavium's Thunder SoC in 2 Node topology Ganapatrao Kulkarni
[not found] ` <1421924755-26029-4-git-send-email-gkulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2015-01-22 16:47 ` Arnd Bergmann
2015-01-22 18:26 ` Arnd Bergmann [this message]
2015-01-23 12:37 ` Ganapatrao Kulkarni
[not found] ` <CAFpQJXUvux+b9hYx_ZY-1hor0HRFFgh=e4vCYyJiDHrDC9Y=tQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 8:52 ` Ganapatrao Kulkarni
[not found] ` <CAFpQJXXkXatxRcfpA1DjuuiUf3vup3DV+dACyGxT=TDkrO8rNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 8:42 ` Ganapatrao Kulkarni
[not found] ` <CAFpQJXVc5c=YRLw3uS5RiSR13veo_SUiM-aV6hf+diQuWxdfYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-18 4:02 ` Ganapatrao Kulkarni
[not found] ` <CAFpQJXWL-NM+WndfB5pLj6TmdVngACR9YCr_ahaUTqAO3DaX1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-18 10:00 ` Will Deacon
[not found] ` <20150318100004.GC18951-5wv7dgnIgG8@public.gmane.org>
2015-03-18 10:39 ` Ganapatrao Kulkarni
[not found] ` <CAFpQJXWzhn=sFKOdbPGXGfQNr5outJodTH72RoC1VVYqt8jmdQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-18 10:47 ` Will Deacon
2015-06-29 10:57 ` [RFC PATCH v4 0/4] arm64:numa: Add numa support for arm64 platforms Ganapatrao Kulkarni
[not found] ` <CAFpQJXXZc0sop601wrmTe5Ng0SiSGfT9AA2Dpf=X9bgGN9srrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30 14:01 ` Will Deacon
[not found] ` <20150630140123.GL27725-5wv7dgnIgG8@public.gmane.org>
2015-06-30 14:22 ` Ganapatrao Kulkarni
2015-01-22 11:05 ` [RFC PATCH v4 4/4] arm64:numa: adding " Ganapatrao Kulkarni
[not found] ` <1421924755-26029-5-git-send-email-gkulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2015-02-27 9:08 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1885509.Z0Gm3e3FlX@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=Will.Deacon-5wv7dgnIgG8@public.gmane.org \
--cc=al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gkulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jchandra-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=steve.capper-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).