From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region
Date: Wed, 5 Jul 2023 08:13:15 +0200 [thread overview]
Message-ID: <18869133-ceec-f6db-8ac1-6b4d3b83a297@linaro.org> (raw)
In-Reply-To: <20230705053914.9759-2-quic_kbajaj@quicinc.com>
On 05/07/2023 07:39, Komal Bajaj wrote:
> Add missing reserved regions as described in QDU1000 memory map.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 1d22f87fd238..3f5512ec0a90 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -448,6 +448,32 @@ &qupv3_id_0 {
> status = "okay";
> };
>
> +&reserved_memory{
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
Drop, you should not neeed it.
> +
> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{
That's not correct style. Missing space after ':', no underscores in
node names. reg is first property, not second.
Please open existing files and look how it is done there. Srsly, just
open qdu1000.dtsi which you are extending.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-05 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 5:39 [PATCH 0/2] arm64: dts: qcom: qdu1000: Update reserved memory region Komal Bajaj
2023-07-05 5:39 ` [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: " Komal Bajaj
2023-07-05 5:49 ` Dmitry Baryshkov
2023-07-05 7:06 ` Komal Bajaj
2023-07-05 9:42 ` Dmitry Baryshkov
2023-07-05 11:02 ` Komal Bajaj
2023-07-05 11:08 ` Konrad Dybcio
2023-07-05 14:19 ` Krzysztof Kozlowski
2023-07-05 6:13 ` Krzysztof Kozlowski [this message]
2023-07-05 5:39 ` [PATCH 2/2] arm64: dts: qcom: qru1000-idp: " Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18869133-ceec-f6db-8ac1-6b4d3b83a297@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).