From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: claudiu beznea <claudiu.beznea@tuxon.dev>,
<Mihai.Sain@microchip.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<alexandre.belloni@bootlin.com>, <andre.przywara@arm.com>,
<Andrei.Simion@microchip.com>, <Jerry.Ray@microchip.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <Cristian.Birsan@microchip.com>
Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board
Date: Mon, 11 Sep 2023 18:01:39 +0200 [thread overview]
Message-ID: <18943157-a1fb-0fda-e3d4-e0478d18a849@microchip.com> (raw)
In-Reply-To: <9ce18601-02d8-686e-ebe0-04c5dc29f6c9@tuxon.dev>
Hi Mihai, Claudiu,
First of all, thanks a lot for your help on this board DT, that's great!
On 03/08/2023 at 11:09, claudiu beznea wrote:
> Hi, Mihai,
>
> On 02.08.2023 15:19,Mihai.Sain@microchip.com wrote:
>>> +&macb0 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + phy-mode = "rmii";
>>> + status = "disabled";
>> Should any phy/mdio container be placed here? Also, any reason this node is disabled?
>> The board has no phy.
>> We will add external phy boards to macb interface and they will be present in dt-overlay.
>>
> Then remove the macb0 node from here and keep it in overlay.
What about choosing a phy and making it enabled by default. Because I
doubt people will use this board without a phy under Linux, honestly.
Overlays would remove this "by default" node and add the replacing phy
if hardware plugged-in is different.
By doing this we avoid having difficult situations where the most used
phy with this board is disabled or non existant and that we absolutely
need an overlay for such a basic thing as having Ethernet working
out-of-the-box...
Just my $0.02, but it might simplify our life in the long run...
Best regards,
Nicolas
next prev parent reply other threads:[~2023-09-11 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:11 [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity Mihai Sain
2023-08-01 11:11 ` [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board Mihai Sain
2023-08-02 4:40 ` claudiu beznea
2023-08-02 12:19 ` Mihai.Sain
2023-08-03 9:09 ` claudiu beznea
2023-09-11 16:01 ` Nicolas Ferre [this message]
2023-09-12 11:01 ` claudiu beznea
2023-08-02 5:02 ` claudiu beznea
2023-08-02 11:59 ` Mihai.Sain
2023-08-01 15:35 ` [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity Conor Dooley
2023-08-02 12:42 ` Mihai.Sain
2023-08-02 15:39 ` Conor Dooley
2023-09-11 15:03 ` Nicolas Ferre
2023-09-11 15:57 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18943157-a1fb-0fda-e3d4-e0478d18a849@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Andrei.Simion@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Jerry.Ray@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).