From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] soc: qcom: socinfo: Fix soc_id order
Date: Mon, 9 Jan 2023 10:30:05 +0100 [thread overview]
Message-ID: <189e5ced-fea2-177b-fb7b-9bfc89b18d50@linaro.org> (raw)
In-Reply-To: <20230104115348.25046-2-stephan@gerhold.net>
On 04/01/2023 12:53, Stephan Gerhold wrote:
> The soc_id array is mostly ordered by the numeric "msm-id" defined in
> qcom,ids.h but some recent entries were added at the wrong place.
>
> While it does not make a functional difference it does make it harder
> to regenerate the entire array after adding a bunch of new IDs.
>
> Fixes: de320c07da3d ("soc: qcom: socinfo: Add MSM8956/76 SoC IDs to the soc_id table")
> Fixes: 147f6534b8ff ("soc: qcom: socinfo: Add SM8550 ID")
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> drivers/soc/qcom/socinfo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 10efdbcfdf05..7258527816b0 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -257,8 +257,6 @@ static const struct soc_id soc_id[] = {
Can you in the same or new patch add a comment that list is ordered by
numerical ID, not by model name?
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-09 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 11:53 [PATCH 0/4] soc: qcom: socinfo: Add a bunch of older SoCs Stephan Gerhold
2023-01-04 11:53 ` [PATCH 1/4] soc: qcom: socinfo: Fix soc_id order Stephan Gerhold
2023-01-09 9:30 ` Krzysztof Kozlowski [this message]
2023-01-04 11:53 ` [PATCH 2/4] dt-bindings: arm: qcom,ids: Add QRD board ID Stephan Gerhold
2023-01-08 21:36 ` Rob Herring
2023-01-04 11:53 ` [PATCH 3/4] dt-bindings: arm: qcom,ids: Add a bunch of older SoCs Stephan Gerhold
2023-01-08 21:40 ` Rob Herring
2023-01-08 22:20 ` Dmitry Baryshkov
2023-01-09 9:39 ` Stephan Gerhold
2023-01-09 8:43 ` Stephan Gerhold
2023-01-11 19:42 ` Bjorn Andersson
2023-01-12 21:08 ` Rob Herring
2023-01-04 11:53 ` [PATCH 4/4] soc: qcom: socinfo: " Stephan Gerhold
2023-01-18 23:55 ` [PATCH 0/4] " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=189e5ced-fea2-177b-fb7b-9bfc89b18d50@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).