From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DC8C54EBE for ; Mon, 9 Jan 2023 09:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbjAIJbh (ORCPT ); Mon, 9 Jan 2023 04:31:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237038AbjAIJbA (ORCPT ); Mon, 9 Jan 2023 04:31:00 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 656396461 for ; Mon, 9 Jan 2023 01:30:08 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id j16-20020a05600c1c1000b003d9ef8c274bso1751157wms.0 for ; Mon, 09 Jan 2023 01:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gGEMDHLHYnrcaFvEu4QvBpxD5CV8NRVf54KR4uCbrnM=; b=TqFn7SMxQJax+AzzmJ4lJdlgRdocs+VQr+DEn84XE2DU55VzWMtF6K+UHbT/VxzBRp uuhn2WXj1/QeQp9dX/9ba5IZ+eoOvQqzZbUEYHDdPE+1jQdH1wa7A9oAZIKJ9AGMeR6P tabYUA+02Pu9ZNYnOa1b+4sWQ956+Tz7p/RuKKrmbkx49/7zD5zKtFPsAZy0MIGGu59w ss5rCP/swOMVk2XGuJQX85+cxnh5zORJMDLNpo64JBzBXNxGDmb1tMHfY3RpUwXH8ub6 UafOIOXFkGCCFx87y4K/RnvVJP7bXRNjUpvztoLy0a0SLQz61Pk60whE/SivI1uRWQyO E5ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gGEMDHLHYnrcaFvEu4QvBpxD5CV8NRVf54KR4uCbrnM=; b=496agIiLynX6S9bu8EV6qq0OzI1NhHlZqQV8uDirslDSe8GmLM+vgl7LfhYGHPrAdx tBJsnXQbMXCWInvn2P3y6bPra1qSEefYzt1epirVgpMRKBi8IFw7Ys8RU5SbnrzOd4yO mCcTudAbID6ZzgOyHc/7cOfjy4vqvghvZXlxf1fslL5PtcUn3m3tAqDEA6bo/t67/PE3 odCZSCWjPwEfHG/cmugKDLgH/TvqUayDoGUbG4fVY8a1o8NfBCnY9vMa3KClIbIrj6Pe 0KCOVWpAVn49gYQS5gysU7BNJLXTlxAf+PVHxoDg9EpMRfgiv5uWdWlWjvZ/niFpC1DW QE7w== X-Gm-Message-State: AFqh2krigQs3xzDKvd0bJi7X3NJlf/I3Nf4hS12KCDMS1LWTWQclhiPQ 9HiJKbEWHsS1tK4wMYM9LgE60Q== X-Google-Smtp-Source: AMrXdXspbWYZM83aPs7JQqmVF2zwjegRK3gDtccETa05r62+3m/rLfGTF/MWLDmtzoOoF2a491DtRg== X-Received: by 2002:a05:600c:601b:b0:3d3:56ce:5693 with SMTP id az27-20020a05600c601b00b003d356ce5693mr45201138wmb.17.1673256607024; Mon, 09 Jan 2023 01:30:07 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id p9-20020a05600c358900b003cffd3c3d6csm11509655wmq.12.2023.01.09.01.30.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 01:30:06 -0800 (PST) Message-ID: <189e5ced-fea2-177b-fb7b-9bfc89b18d50@linaro.org> Date: Mon, 9 Jan 2023 10:30:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/4] soc: qcom: socinfo: Fix soc_id order Content-Language: en-US To: Stephan Gerhold , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20230104115348.25046-1-stephan@gerhold.net> <20230104115348.25046-2-stephan@gerhold.net> From: Krzysztof Kozlowski In-Reply-To: <20230104115348.25046-2-stephan@gerhold.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/01/2023 12:53, Stephan Gerhold wrote: > The soc_id array is mostly ordered by the numeric "msm-id" defined in > qcom,ids.h but some recent entries were added at the wrong place. > > While it does not make a functional difference it does make it harder > to regenerate the entire array after adding a bunch of new IDs. > > Fixes: de320c07da3d ("soc: qcom: socinfo: Add MSM8956/76 SoC IDs to the soc_id table") > Fixes: 147f6534b8ff ("soc: qcom: socinfo: Add SM8550 ID") > Signed-off-by: Stephan Gerhold > --- > drivers/soc/qcom/socinfo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index 10efdbcfdf05..7258527816b0 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -257,8 +257,6 @@ static const struct soc_id soc_id[] = { Can you in the same or new patch add a comment that list is ordered by numerical ID, not by model name? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof