devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@denx.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com,
	linux-pm@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v7 1/3] dt-bindings: thermal-zones: Document critical-action
Date: Fri, 08 Sep 2023 14:37:25 -0300	[thread overview]
Message-ID: <18b23d536827559f113ebae99c859cfc@denx.de> (raw)
In-Reply-To: <CAJZ5v0jKmxxFMO5TkHujEtdSjeEqKqEOwRyXAXbaeRQUTythdg@mail.gmail.com>

Hi Rafael,

On 07/09/2023 13:23, Rafael J. Wysocki wrote:

> So one more question here: Why is this a property of a thermal zone
> and not the property of the whole system?
> 
> Presumably, on a system where the platform integrator prefers to
> reboot on critical temperature, it would be necessary to add this
> property to every thermal zone.
> 
> Also, what if this property has different values for different thermal 
> zones?

I got your point and I can make the 'critical-action' property to be 
valid
for the whole thermal system.

Originally, I have been doing like this:

	thermal-zones {
		cpu-thermal {
			critical-action = "reboot";
			polling-delay-passive = <250>;
			polling-delay = <2000>;
			thermal-sensors = <&tmu>;

			trips {
				cpu_alert0: trip0 {
					temperature = <85000>;
					hysteresis = <2000>;
					type = "passive";
				};

I can change it to be:


	thermal-zones {
		critical-action = "reboot";

		cpu-thermal {
			polling-delay-passive = <250>;
			polling-delay = <2000>;
			thermal-sensors = <&tmu>;

			trips {
				cpu_alert0: trip0 {
					temperature = <85000>;
					hysteresis = <2000>;
					type = "passive";
				};

Thanks,

Fabio Estevam

  reply	other threads:[~2023-09-08 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 13:02 [PATCH v7 1/3] dt-bindings: thermal-zones: Document critical-action Fabio Estevam
2023-08-31 13:02 ` [PATCH v7 2/3] reboot: Introduce hw_protection_reboot() Fabio Estevam
2023-08-31 13:02 ` [PATCH v7 3/3] thermal: thermal_core: Allow rebooting after critical temp Fabio Estevam
2023-09-07 16:23 ` [PATCH v7 1/3] dt-bindings: thermal-zones: Document critical-action Rafael J. Wysocki
2023-09-08 17:37   ` Fabio Estevam [this message]
2023-09-08 18:01     ` Rafael J. Wysocki
2023-09-12 15:14       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18b23d536827559f113ebae99c859cfc@denx.de \
    --to=festevam@denx.de \
    --cc=amitk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).