From: PeterYin <peteryin.openbmc@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
patrick@stwcx.xyz, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: cosmo.chou@quantatw.com, potin.lai@quantatw.com, daniel-hsu@quantatw.com
Subject: Re: [PATCH v4 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC
Date: Tue, 5 Sep 2023 17:55:25 +0800 [thread overview]
Message-ID: <18b78489-6a12-a09f-620d-985be747f9da@gmail.com> (raw)
In-Reply-To: <b9cbe9be-b03e-6c7a-d06c-b75b012b5b25@linaro.org>
On 8/30/23 17:44, Krzysztof Kozlowski wrote:
> On 30/08/2023 11:02, peteryin wrote:
>> Add linux device tree entry related to
>> Minerva specific devices connected to BMC SoC.
>>
>> Signed-off-by: peteryin <peteryin.openbmc@gmail.com>
> To clarify: your full name or known identity is "peteryin"?
>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> .../boot/dts/aspeed-bmc-facebook-minerva.dts | 385 ++++++++++++++++++
>> 2 files changed, 386 insertions(+)
>> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 9e1d7bf3cff6..edb0b2105333 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>> aspeed-bmc-facebook-wedge400.dtb \
>> aspeed-bmc-facebook-yamp.dtb \
>> aspeed-bmc-facebook-yosemitev2.dtb \
>> + aspeed-bmc-facebook-minerva.dtb \
> Nothing improved here.
>
>> aspeed-bmc-ibm-bonnell.dtb \
>> aspeed-bmc-ibm-everest.dtb \
>> aspeed-bmc-ibm-rainier.dtb \
>
>> + "","","","","","","","",
>> + /*O0-O3 line 224-231*/
>> + "","","","","","","","",
>> + /*O4-O7 line 232-239*/
>> + "","","","","","","","",
>> + /*P0-P3 line 240-247*/
>> + "","","","","","","","",
>> + /*P4-P7 line 248-255*/
>> + "","","","","","","","";
>> +};
>> +
> Nor here.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
Could you please clarify for me?
Are you asking if the last line should not have a blank line, or I can't
set a comment for the sgpio line like this:
/*P4-P7 line 248-255*/
> Thank you.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-09-05 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 9:02 [PATCH v4 0/2] ARM: dts: aspeed:Minerva: peteryin
2023-08-30 9:02 ` [PATCH v4 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC peteryin
2023-08-30 9:44 ` Krzysztof Kozlowski
2023-09-05 9:55 ` PeterYin [this message]
2023-09-05 10:38 ` Krzysztof Kozlowski
2023-09-05 15:19 ` PeterYin
2023-08-30 9:02 ` [PATCH v4 2/2] dt-bindings: arm: aspeed: add Meta Minerva board peteryin
2023-08-30 9:45 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18b78489-6a12-a09f-620d-985be747f9da@gmail.com \
--to=peteryin.openbmc@gmail.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=cosmo.chou@quantatw.com \
--cc=daniel-hsu@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patrick@stwcx.xyz \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).