From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child
Date: Mon, 28 Aug 2023 19:17:27 +0200 [thread overview]
Message-ID: <18b8b8b8-7f42-8e8c-1bfd-36d04eba7c40@linaro.org> (raw)
In-Reply-To: <2bec39b1001732de60c1521d78e44a45ff94d6b6.1693218539.git.zhoubinbin@loongson.cn>
On 28/08/2023 14:38, Binbin Zhou wrote:
> The reboot and poweroff features are actually part of the Power
> Management Unit system controller, thus allow them as its children,
> instead of specifying as separate device nodes with syscon phandle.
>
> required:
> - compatible
> - reg
> @@ -44,10 +56,25 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
>
> - power-management@1fe27000 {
> + pmc: power-management@1fe27000 {
Drop the label.
> compatible = "loongson,ls2k1000-pmc", "syscon";
> reg = <0x1fe27000 0x58>;
> interrupt-parent = <&liointc1>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> loongson,suspend-address = <0x0 0x1c000500>;
> +
> + syscon-reboot {
> + compatible ="syscon-reboot";
> + regmap = <&pmc>;
No, why? It does not make much sense and is deprecated.
> + offset = <0x30>;
> + mask = <0x1>;
> + };
> +
> + syscon-poweroff {
> + compatible ="syscon-poweroff";
Missing space.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-28 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 12:38 [PATCH 0/5] soc: loongson: Fix some issues about loongson_pm2 Binbin Zhou
2023-08-28 12:38 ` [PATCH 1/5] soc: loongson: loongson_pm2: add dependency for INPUT Binbin Zhou
2023-08-28 17:25 ` Krzysztof Kozlowski
2023-08-28 20:50 ` Randy Dunlap
2023-08-28 12:38 ` [PATCH 2/5] dt-bindings: soc: loongson,ls2k-pmc: Add missing compatible for Loongson-2K2000 Binbin Zhou
2023-08-28 15:49 ` Conor Dooley
2023-08-29 3:21 ` Binbin Zhou
2023-08-29 6:29 ` Krzysztof Kozlowski
2023-08-29 6:42 ` Conor Dooley
2023-08-29 6:52 ` Binbin Zhou
2023-08-31 16:39 ` Rob Herring
2023-08-28 12:38 ` [PATCH 3/5] soc: loongson: loongson_pm2: " Binbin Zhou
2023-08-28 15:32 ` Conor Dooley
2023-08-29 6:28 ` Krzysztof Kozlowski
2023-08-28 12:38 ` [PATCH 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child Binbin Zhou
2023-08-28 17:17 ` Krzysztof Kozlowski [this message]
2023-08-29 2:15 ` Binbin Zhou
2023-08-28 12:39 ` [PATCH 5/5] soc: loongson: loongson_pm2: Populate children syscon nodes Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18b8b8b8-7f42-8e8c-1bfd-36d04eba7c40@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).