From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B04C433EF for ; Thu, 14 Jul 2022 10:50:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238503AbiGNKug (ORCPT ); Thu, 14 Jul 2022 06:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238448AbiGNKue (ORCPT ); Thu, 14 Jul 2022 06:50:34 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A0B3550AD for ; Thu, 14 Jul 2022 03:50:32 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id c15so1745339ljr.0 for ; Thu, 14 Jul 2022 03:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Z7MLNfS7kpF23MkCCTVtj5YNhoPMRTO751pyRtCbFcs=; b=oET52dqA3ro7HwCzr2WcBcKO6o1/fBPd/rcBiOt9K2M5jPMq4rMwltCwIvWbavm28h ccDK8+zQgmZudlq4j+GdwJgXIWeewY6n/Iy1QMITPTmwcJRxQMJIekmV08IqhErEKdPY SVZZjIDNwKae4bA4MaGJNQesOrWCfsQhKCSKzBPTNwuxsANFEYpAt/ClUtET/BSezuYs W8HtUx5g0Kiyco6n/mVJEKcWJka9DXieT/GIHFeSwUCQ0f4dngjT87kDV5HmsDZp6f2S JaJ8Vw9qgAmgwn6+fHzt0+yYNNDPP6rRmQpiIcCJR8bWddVa/ZF1A7ASGPQNE+D346eC xaWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z7MLNfS7kpF23MkCCTVtj5YNhoPMRTO751pyRtCbFcs=; b=grkukOS1Nzd6yCHWoLqSfd+vnZD6P3K1jVc2TuGZlOCVOgmoiQcQwZQRQeAKsfRkDG N8ff3dePQWMpn8dO2tE+PPu2Fjxvqv9+zT8GSZp6p3PGPKLQP2k3WpH050wxPVWXD1OU ZqWyVC5kB3eG1oLQRlJkb+EWmLs2UT7yYMHK7JhCUPb6JlVZRH2f7lm8WY5uyZ8JB7FX QKCLMgp0xDMK7r3Qm3ToNy9orjXkMVgdivxCWYDGW5aOSzFD+FZf4Uen0oN2LXmo4oYS 4rPCQIkgY8VoG2siiISfGDTa6+hg+JLfteNbDzCya8lhQ7KR8j1o7dHXr/mErlZTi1C2 JIyg== X-Gm-Message-State: AJIora+rksGeUHGKTDKygjBiLo12amPpS1rf/I+d1h22gI4o0a7s8IxV H3n166NsKMq2mS74pvH54mXnIg== X-Google-Smtp-Source: AGRyM1sQ37UwVB00AS/TuBt9WhFKv6nkOywtjL2/GJD2YMpDoX5RAV3WYiT85/7MfbOftTAHsEvD3A== X-Received: by 2002:a05:651c:1061:b0:25d:6302:68a2 with SMTP id y1-20020a05651c106100b0025d630268a2mr4091981ljm.212.1657795830591; Thu, 14 Jul 2022 03:50:30 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id y10-20020a0565123f0a00b00489ec0d7636sm292350lfa.110.2022.07.14.03.50.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 03:50:29 -0700 (PDT) Message-ID: <18d4d8f6-ae5d-382c-e23f-1630bda42c37@linaro.org> Date: Thu, 14 Jul 2022 12:50:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/7] dt-bindings: usb: qcom,dwc3: refine interrupt requirements Content-Language: en-US To: Johan Hovold , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220713131340.29401-1-johan+linaro@kernel.org> <20220713131340.29401-3-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220713131340.29401-3-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/07/2022 15:13, Johan Hovold wrote: > Not all platforms have all of the four wakeup interrupts currently > described by the bindings. > > Specifically, MSM8953/6/8 and SDM660 do not use the DP/DM interrupts, > while the SS PHY interrupt is optional on SDM660 and SC7280. > > Note that no devicetree in mainline specify any wakeup interrupts for > > - qcom,ipq4019-dwc3 > - qcom,ipq6018-dwc3 > - qcom,ipq8064-dwc3 > - qcom,ipq8074-dwc3 > - qcom,msm8994-dwc3 > - qcom,qcs404-dwc3 > > but let's keep the schema warnings about that for now. > > Signed-off-by: Johan Hovold > --- > .../devicetree/bindings/usb/qcom,dwc3.yaml | 60 +++++++++++++++++-- > 1 file changed, 55 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index c991d9103f87..fea3e7092ace 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -94,9 +94,11 @@ properties: > - const: apps-usb > > interrupts: > + minItems: 1 > maxItems: 4 > > interrupt-names: > + minItems: 1 > maxItems: 4 > > qcom,select-utmi-as-pipe-clk: > @@ -333,14 +335,9 @@ allOf: > - qcom,ipq6018-dwc3 > - qcom,ipq8064-dwc3 > - qcom,ipq8074-dwc3 > - - qcom,msm8953-dwc3 > - qcom,msm8994-dwc3 > - - qcom,msm8996-dwc3 > - - qcom,msm8998-dwc3 > - qcom,qcs404-dwc3 > - qcom,sc7180-dwc3 > - - qcom,sc7280-dwc3 > - - qcom,sdm660-dwc3 > - qcom,sdm845-dwc3 > - qcom,sdx55-dwc3 > - qcom,sdx65-dwc3 > @@ -369,6 +366,59 @@ allOf: > - const: dm_hs_phy_irq > - const: dp_hs_phy_irq > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,msm8953-dwc3 > + - qcom,msm8996-dwc3 > + - qcom,msm8998-dwc3 > + then: > + properties: > + interrupts: > + maxItems: 2 > + interrupt-names: > + items: > + - const: hs_phy_irq > + - const: ss_phy_irq > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sdm660-dwc3 > + then: > + properties: > + interrupts: > + minItems: 1 > + maxItems: 2 > + interrupt-names: > + minItems: 1 > + items: > + - const: hs_phy_irq > + - const: ss_phy_irq > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7280-dwc3 > + then: > + properties: > + interrupts: > + minItems: 3 > + maxItems: 4 > + interrupt-names: > + minItems: 3 > + items: > + - const: hs_phy_irq > + - const: dp_hs_phy_irq > + - const: dm_hs_phy_irq > + - const: ss_phy_irq OK, I see now that you used SC8280XP order matching this one. Reviewed-by: Krzysztof Kozlowski > + > - if: > properties: > compatible: Best regards, Krzysztof