From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Andrej Picej <andrej.picej@norik.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, upstream@phytec.de
Subject: Re: [PATCH 2/2] ARM: dts: imx6: pfla02: Fix SD card reboot problem
Date: Wed, 5 Jul 2023 10:26:50 +0200 [thread overview]
Message-ID: <18d8a6d4-78fb-7046-b796-86f527d074f6@pengutronix.de> (raw)
In-Reply-To: <02d491bb-2a40-4909-ebc3-be2e183cfcbb@norik.com>
Hi Andrej,
[Restoring Cc-list]
On 05.07.23 10:18, Andrej Picej wrote:
> Hi Ahmad,
>
> On 4. 07. 23 10:15, Ahmad Fatoum wrote:
>> Hello Andrej,
>>
>> On 04.07.23 10:03, Andrej Picej wrote:
>>> If regulator is not marked as always-on the regulator gets disabled on
>>> reboot breaking the next boot.
>>
>> While this is ok as a fix, the real issue is that your system reset doesn't
>> restore PMIC rails to a good state. Are you perhaps doing a SoC-internal
>> reset only or have the PMIC misconfigured?
>
> yes I would agree, this is just a fix since system reset doesn't reset the PMIC, leaving the configuration as it is in a misconfigured state. The i.MX6 reset is done with imx watchdog.
If PMIC doesn't have own watchdog, i.MX watchdog can be configured to toggle
WDOG_B line, which may be routed to PMIC.
But fix is ok for now:
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cheers,
Ahmad
>
> Best regards,
> Andrej
>
>>
>> Cheers,
>> Ahmad
>>
>>>
>>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>>> ---
>>> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>>> index 80adb2a02cc9..25d6a036d5b8 100644
>>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>>> @@ -192,6 +192,7 @@ vdd_3v3_pmic_io_reg: ldo6 {
>>> vdd_sd0_reg: ldo9 {
>>> regulator-min-microvolt = <3300000>;
>>> regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> };
>>> vdd_sd1_reg: ldo10 {
>>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-07-05 8:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 8:03 [PATCH 0/2] PHYTEC i.MX6 device-tree fixes Andrej Picej
2023-07-04 8:03 ` [PATCH 1/2] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
2023-07-04 8:03 ` [PATCH 2/2] ARM: dts: imx6: pfla02: Fix SD card reboot problem Andrej Picej
2023-07-04 8:15 ` Ahmad Fatoum
[not found] ` <02d491bb-2a40-4909-ebc3-be2e183cfcbb@norik.com>
2023-07-05 8:26 ` Ahmad Fatoum [this message]
2023-07-04 8:17 ` Marco Felsch
2023-07-05 8:28 ` Andrej Picej
2023-07-05 8:30 ` Ahmad Fatoum
2023-07-05 8:40 ` Andrej Picej
2023-07-05 10:39 ` Andrej Picej
2023-07-05 12:06 ` Ahmad Fatoum
2023-07-07 9:28 ` Andrej Picej
2023-07-12 8:54 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d8a6d4-78fb-7046-b796-86f527d074f6@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=andrej.picej@norik.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).