From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ty <zonyitoo@gmail.com>, "Heiko Stübner" <heiko@sntech.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
DHDAXCW <lasstp5011@gmail.com>
Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
Date: Wed, 21 Dec 2022 13:15:06 +0100 [thread overview]
Message-ID: <18f4b0f8-a11c-a706-aafd-063cd6af9e3f@linaro.org> (raw)
In-Reply-To: <CAMmci2XoF0M81mVt8zko3D3G2oTHq0ia_nZ9CPX9Xz20j92c9Q@mail.gmail.com>
On 21/12/2022 13:12, ty wrote:
> Hi, Kozlowski and Stübner,
>
> Thank you very much for pointing me in the right direction.
>
>> So how did you solve the comment "Does not look like properly ordered.
>> Don't add stuff at the end of files/lists."? What did you change to
>> solve it?
>
>> for context sorting order in that file is alphabetical by description
>
> I finally got it. It should be put right after the "Elgin RV1108 R1".
>
>> You do not wrap at 75, but at some other place. Just put it to editor
>> and check where is wrapping (count characters).
>
> The original message was:
>
>> from: DHDAXCW <lasstp5011@gmail.com>
>>
>> LubanCat 1 is a Rockchip RK3566 SBC based
>> is developed by EmbedFire Electronics Co., Ltd.
>> Mini Linux Card Type Cheap Computer Development Board
>>
>> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
>> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>
> The longest line is "Mini Linux Card Type Cheap Computer Development
> Board", which has 53 characters. Or ... I should use the whole line as
> much as possible? Then I see why I was doing wrong. It will be fixed
> in the PATCH v5.
Yes,
because
such
commit
msg
is
also
within
75
characters
but
it
is
not
correct,
right?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-21 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 5:46 [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 Yuteng Zhong
2022-12-21 5:52 ` [PATCH v4 2/2] dt-bindings: arm: " Yuteng Zhong
2022-12-21 8:16 ` Krzysztof Kozlowski
2022-12-21 10:46 ` ty
2022-12-21 11:41 ` Krzysztof Kozlowski
2022-12-21 11:44 ` Heiko Stübner
2022-12-21 12:12 ` ty
2022-12-21 12:15 ` Krzysztof Kozlowski [this message]
2022-12-21 8:15 ` [PATCH v4 1/2] arm64: dts: " Krzysztof Kozlowski
2022-12-21 9:44 ` ty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18f4b0f8-a11c-a706-aafd-063cd6af9e3f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lasstp5011@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zonyitoo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).