From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96406C4332F for ; Wed, 21 Dec 2022 12:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbiLUMPQ (ORCPT ); Wed, 21 Dec 2022 07:15:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbiLUMPM (ORCPT ); Wed, 21 Dec 2022 07:15:12 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE94423149 for ; Wed, 21 Dec 2022 04:15:09 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id j4so23293653lfk.0 for ; Wed, 21 Dec 2022 04:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ei2wiph6SuRSCb268ohc3SeGTY4BbHhEXYgk9wMq0ZE=; b=fOkt1qwQiyPyHPtxLQ/9osQZSDaOkjnadjiEydP8euo7M/ZodaIOHRLtnihPWzqHIx GkmmhxQTrEMfUF28TNtEMmpjdU2fFZvGVDUyd6rLD+G2lq3ESGQ+vvIFaLZ/lMclV9PF Zh90I4pN1TwrIBt3FNHSDIU/gy7RGWo+EaqXFAX9R82di/I6NzAbuqZ4z+YfgkRUp4jk T/vQVnvVcKwTJUXnkEywjlgaahRF8oaQCsqEyQF67EFc2fk1fG95OXd3ABq6lj1Z6h0U BeAlN8b5P6Y9jKuVi5016yudZ254mCZ+ycCFGJgF7nN+bcoON76MU+RGxcHwN132cO4X YxFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ei2wiph6SuRSCb268ohc3SeGTY4BbHhEXYgk9wMq0ZE=; b=yYw3t5mYDjdWvvwyMVf2mu6SabsdX00qHN2JeD3BrRUkMWPhJQ+m2XPw8xtMda/Jfy ShuGF9+5iqkc7L/WF/IZ+GIX+9RoExIcEVGZ4/Vz32cbYXhr/QK3JaDMmiOAYCQ0CaBn WbUEt+aWwkgVn+w6x52z28f3RFrbS1IB71c7XAYSkkWuf3PvKudMD0ayePJNQNB5yAYD NHoErr8OuSUGE58sLJLkriboFPFObDAiX5hnQ9ZA7kr1mhRz9tcRbHEWzRb9I/9w0T5f 6asEusvw8Rr0A6qVcsgzP3CvKH61sJ6TI1CGVFAhHl4eMmLD/UD5Mr+wxJOgEnO3ekrv TGlA== X-Gm-Message-State: AFqh2kqkUUsmOFDdU82mXqDGtXqQ+pbmKwvcl+hA0zi2oHZ7iNIb48CB hIvPbnB+L6fl7c5huEIfLd5TwA== X-Google-Smtp-Source: AMrXdXvEIYapVwokYBeZ8T+UxGWSaE8AFmfC4fVrwgrdJTaZsXGiJjcvZGYGHW9hnz/52waurzdcJw== X-Received: by 2002:a05:6512:2a8e:b0:4b6:e4b3:d82d with SMTP id dt14-20020a0565122a8e00b004b6e4b3d82dmr568449lfb.7.1671624908350; Wed, 21 Dec 2022 04:15:08 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u23-20020a196a17000000b004b5774726dcsm1817293lfu.236.2022.12.21.04.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 04:15:07 -0800 (PST) Message-ID: <18f4b0f8-a11c-a706-aafd-063cd6af9e3f@linaro.org> Date: Wed, 21 Dec 2022 13:15:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1 Content-Language: en-US To: ty , =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: Rob Herring , Peter Geis , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, DHDAXCW References: <5a7907e3-f79e-5de9-ed1b-ec24ea52c437@linaro.org> <2673859.iZASKD2KPV@diego> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/12/2022 13:12, ty wrote: > Hi, Kozlowski and Stübner, > > Thank you very much for pointing me in the right direction. > >> So how did you solve the comment "Does not look like properly ordered. >> Don't add stuff at the end of files/lists."? What did you change to >> solve it? > >> for context sorting order in that file is alphabetical by description > > I finally got it. It should be put right after the "Elgin RV1108 R1". > >> You do not wrap at 75, but at some other place. Just put it to editor >> and check where is wrapping (count characters). > > The original message was: > >> from: DHDAXCW >> >> LubanCat 1 is a Rockchip RK3566 SBC based >> is developed by EmbedFire Electronics Co., Ltd. >> Mini Linux Card Type Cheap Computer Development Board >> >> Signed-off-by: Yuteng Zhong >> Signed-off-by: DHDAXCW > > The longest line is "Mini Linux Card Type Cheap Computer Development > Board", which has 53 characters. Or ... I should use the whole line as > much as possible? Then I see why I was doing wrong. It will be fixed > in the PATCH v5. Yes, because such commit msg is also within 75 characters but it is not correct, right? Best regards, Krzysztof