From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2B9013A245; Tue, 18 Jun 2024 07:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718697104; cv=none; b=GMKQyGK+To/5VzUjXIN9sSkwOLuIq2L2OyFKvTkC9ArrGmxzVkRDCY8p4kEITzgZEYo6u9Sz7Z09lZPguzcAUsO2AG62+6/KWhFj137eCfElviWFUjVVhTL++QsHvg4q7LtfcSUfQ3v+0Dqtsu9ldZSVTuDitvsww/Vb/Ye8BT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718697104; c=relaxed/simple; bh=C3wdJD72r78Egc9KFUBjVcSgYoNuhaM/wcJvoiKPVzw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TvC56MexqYQ+1AoSNQEaPtGViHhp99EdZlzLpEe/D2QTVQz02NJ51ZC8X4BGCJKAcw7gGgpFJNw/TGzgbo8npVYs5IyeWzQr/jm1aPEhf4EctGYQjtkt0MDrwqxJfjfC0rDoiE93zAWzNxqhWIjhba8qSdHeMUwnEfwoJUTQJpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e8616c2.versanet.de ([94.134.22.194] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJTco-0006Ly-DP; Tue, 18 Jun 2024 09:51:30 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Vinod Koul , Kishon Vijay Abraham I , Algea Cao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cristian Ciocaltea Cc: kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] phy: phy-rockchip-samsung-hdptx: Enable runtime PM at PHY core level Date: Tue, 18 Jun 2024 09:51:28 +0200 Message-ID: <19099161.fAMKPKieAE@diego> In-Reply-To: <20240618-rk3588-hdmiphy-clkprov-v1-2-80e4aa12177e@collabora.com> References: <20240618-rk3588-hdmiphy-clkprov-v1-0-80e4aa12177e@collabora.com> <20240618-rk3588-hdmiphy-clkprov-v1-2-80e4aa12177e@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Montag, 17. Juni 2024, 23:48:10 CEST schrieb Cristian Ciocaltea: > When a new PHY is created via [devm_]phy_create(), the runtime PM for it > is not enabled unless the parent device (which creates the PHY) has its > own runtime PM already enabled. > > Move the call to devm_pm_runtime_enable() before devm_phy_create() to > enable runtime PM at PHY core level. > > With this change the ->power_on() and ->power_off() callbacks do not > require explicit runtime PM management anymore, since the PHY core > handles that via phy_pm_runtime_{get,put}_sync() when phy_power_on() and > phy_power_off() are invoked. > > Hence drop the now unnecessary calls to pm_runtime_resume_and_get() and > pm_runtime_put() helpers. > > Signed-off-by: Cristian Ciocaltea checked against phy_create() Reviewed-by: Heiko Stuebner