From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C7991B9B5C for ; Wed, 14 Aug 2024 16:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723654034; cv=none; b=HlC7I2abxAAfduZs/hr3n/r5jl8HCa4iYrPQlPqHy3XythNO/IO8yp06qPmZxDskBuFMP9zN5NeKOrCfF03m0rvydiMlF9IROmUEERZhRY2H5XRPWd/JoJPyXQHjhNcMjHIgvK8SUsE5pWNeN3IDWUt17nlxQAvEORchgSJaIXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723654034; c=relaxed/simple; bh=GTTdsljCHP48BKxOxQ6j1dEfFE2+NMQn7BEF6Jymyp0=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=tyqTSUVorq/Qr1LZfD62Vl66r8DhGC+LMNWbMyuu2SlkDsVmQEAa9Nszn46b2SOMuO2iDVPD4BgvhesW0qIr9P9T9Wohl4NbGGgvQDmAECxDTNBeh5omKXX9R2l3/DcGgq0SEMd8gmakD7isVl6JZn8GR3E1LEDzEJ2uDR6EWyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=N24OdOki; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="N24OdOki" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7a1dcc7bc05so1685185a.0 for ; Wed, 14 Aug 2024 09:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1723654031; x=1724258831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=0LOkC2hr5mjD/XmAuAJdpJW2ttXWug85zZK1Co9ZjIE=; b=N24OdOkifX7HRQa5eXwZdZnM80f8nsictuYml8WBYV2E9mWUbxpB+lOY75Xi1eKaWS BXtozyFebq2M/Jo4GaJZVw/eCKKzoZ0e00tQ1AEYGJJSCl30ASnL9FvYVsfyoQtV7qTO LinKSGB4wjRH8U+DFnOVF7nBaJtX41sZjigb0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723654031; x=1724258831; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0LOkC2hr5mjD/XmAuAJdpJW2ttXWug85zZK1Co9ZjIE=; b=IdhXnZaaQGLXKyt6EYlwHXWw+nZb2EVPcBDRvl0wpNIwPotUzVyWK+NxBYGww7OqYS vyrILcpW7p/XtjwSgU5DYvAXuuhjl9xQ8P4kuRoW5nTVPChX6gEiiOTSz1VjVxgsvxw8 3Axg7mtaqJ96nYiyB0KIMrNZm7k34koj/nUsz8HphbSVdIZRJfjyDnOXxAneDJlb7rNd JtIrhSuQlcJQwJRWnQHs4bahVDJwvGhjwQhNAWaVqPBDBqz28b2J+G/RvaJmqD331ORq QYV2w3FnycJ5pWaKYT+rYzujjqzrLKjOfNy3sH7wliw6A+IRbwNsrK+GlbKet7L6rEKD KZaw== X-Forwarded-Encrypted: i=1; AJvYcCWcQYDa1e6KVJ0nUUbbguw1+G/z+VoWqQ9j5icNs9Fm7dlmYfeo8pwVTAQh3NoOVTNHOXQaOTWIuAxX7zUFcFc0LZ46f5inUF+lsQ== X-Gm-Message-State: AOJu0YwxNM3eCaCFOE7FdgGHG/TsRCxm4gETNTuwi/23nIX9LFnwT33Q YkXMweSFHt2hJiKWYxzapnJzWUOccZVfuiHYeoJAnKaZSRujU6WB1zuIdoL5cA== X-Google-Smtp-Source: AGHT+IHTM4N5IaCtzNPE7RF5w4uRXrZaZMciTBo9YGWGeU+4Fzw/BBwdcOTRcfKTQ2pPneokkJCaEA== X-Received: by 2002:a05:620a:404b:b0:79f:12e9:1e71 with SMTP id af79cd13be357-7a4ee26d137mr414754385a.0.1723654031043; Wed, 14 Aug 2024 09:47:11 -0700 (PDT) Received: from [192.168.178.38] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d6494esm454743585a.2.2024.08.14.09.47.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2024 09:47:10 -0700 (PDT) From: Arend Van Spriel To: Krzysztof Kozlowski , Krzysztof Kozlowski , Jacobe Zang , , , , , , , , , CC: , , , , , , , , , , , , , , , , Date: Wed, 14 Aug 2024 18:47:04 +0200 Message-ID: <19151c92b40.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20240813082007.2625841-1-jacobe.zang@wesion.com> <20240813082007.2625841-2-jacobe.zang@wesion.com> <1914cb2b1a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <062d8d4e-6d61-4f11-a9c0-1bbe1bfe0542@broadcom.com> <1e442710-a233-4ab2-a551-f28ba6394b5b@linaro.org> <180f7459-39fa-4e96-83d6-504e7802dc94@broadcom.com> User-Agent: AquaMail/1.51.5 (build: 105105504) Subject: Re: [PATCH v10 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On August 14, 2024 4:08:52 PM Krzysztof Kozlowski wrote: > On 14/08/2024 13:15, Krzysztof Kozlowski wrote: >> On 14/08/2024 12:59, Arend van Spriel wrote: >>> On 8/14/2024 12:39 PM, Krzysztof Kozlowski wrote: >>>> On 14/08/2024 12:08, Arend van Spriel wrote: >>>>> On 8/14/2024 10:53 AM, Krzysztof Kozlowski wrote: >>>>>> On 13/08/2024 19:04, Arend Van Spriel wrote: >>>>>>> On August 13, 2024 10:20:24 AM Jacobe Zang wrote: >>>>>>> >>>>>>>> It's the device id used by AP6275P which is the Wi-Fi module >>>>>>>> used by Rockchip's RK3588 evaluation board and also used in >>>>>>>> some other RK3588 boards. >>>>>>> >>>>>>> Hi Kalle, >>>>>>> >>>>>>> There probably will be a v11, but wanted to know how this series will be >>>>>>> handled as it involves device tree bindings, arm arch device tree spec, and >>>>>>> brcmfmac driver code. Can it all go through wireless-next? >>>>>> >>>>>> No, DTS must not go via wireless-next. Please split it from the series >>>>>> and provide lore link in changelog for bindings. >>>>> >>>>> Hi Krzysztof, >>>>> >>>>> Is it really important how the patches travel upstream to Linus. This >>>>> binding is specific to Broadcom wifi devices so there are no >>>>> dependencies(?). To clarify what you are asking I assume two separate >>>>> series: >>>>> >>>>> 1) DT binding + Khadas Edge2 DTS -> devicetree@vger.kernel.org >>>>> reference to: >>>>> https://patch.msgid.link/20240813082007.2625841-1-jacobe.zang@wesion.com >>>>> >>>>> 2) brcmfmac driver changes -> linux-wireless@vger.kernel.org >>>> >>>> No. I said only DTS is separate. This was always the rule, since forever. >>>> >>>> Documentation/devicetree/bindings/submitting-patches.rst >>> >>> I am going slightly mad (by Queen). That documents says: >>> >>> 1) The Documentation/ and include/dt-bindings/ portion of the patch >>> should >>> be a separate patch. >>> >>> and >>> >>> 4) Submit the entire series to the devicetree mailinglist at >>> >>> devicetree@vger.kernel.org >>> >>> Above I mentioned "series", not "patch". So 1) is a series of 3 patches >>> (2 changes to the DT binding file and 1 patch for the Khadas Edge2 DTS. >>> Is that correct? >> >> My bookmark to elixir.bootling does not work, so could not paste >> specific line. Now it works, so: >> >> https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L79 >> >> The rule was/is: >> 1. Binding for typical devices always go via subsystem tree, with the >> driver changes. >> There can be exceptions from above, e.g. some subsystems do not pick up >> bindings, so Rob does. But how patches are organized is not an exception >> - it is completely normal workflow. >> >> 2. DTS *always* goes via SoC maintainer. DTS cannot go via any other >> driver subsystem tree. There is no exception here. There cannot be an >> exception, because it would mean the hardware depends on driver, which >> is obviously false. > > In case my message was not clear: we talk here about organizing > patchsets, not individual patches. If you ask about patches, then DTS, > bindings and driver are all separate patches. This set already is split > like that, so this was fine and I did not comment on it. Only through > whom the DTS patch goes - separate tree. I used the "series" which is my term for "patchset". Sorry for confusion. So "[PATCH 3/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2" should be submitted to rockchip soc related tree and the rest can go through the wireless-next tree. Got it. Regards, Arend --- $ ./scripts/get_maintainer.pl -f arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Conor Dooley (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Heiko Stuebner (maintainer:ARM/Rockchip SoC support,commit_signer:11/11=100%,authored:1/11=9%,removed_lines:1/1=100%) Muhammed Efe Cetin (commit_signer:10/11=91%,authored:10/11=91%,added_lines:685/685=100%) Dragan Simic (commit_signer:1/11=9%) devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support) linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) linux-kernel@vger.kernel.org (open list) > > And just in case: this is neither specific to wireless nor to Broadcom. > This is for entire Linux kernel. > > Best regards, > Krzysztof