From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81453DE439 for ; Thu, 11 Jun 2026 11:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781177250; cv=none; b=O/SOeBhFOzi/kBs0ZY748D/0wWgApIyBOs6KcOLPj/mBucUyQu7ocQ3rV0VIy6DlF7lbrbDVF/Tlf9rEp8O9SBaYZEQj4LxCl6QK7ym1H1d10oojk+Q2wAB2W9oTm+JbJgKPyVCUn0jLyCOUh/KPCatj9viPhL/YmtzTvDjYv7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781177250; c=relaxed/simple; bh=D1vttMUOCxgS8k3W32i9Sy4wDCvNW5OarMF4qqZbhLM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cD3ms/cPGeG1SvleroEN7N/nMvt/d/CvbzpoA+33ESlJA7DS3T7edNePtY7cqk3HHpwdsKMaiP71QKFBymwNtnI7/CB4L2WXOXQDhm8RJhIT93WF791KRa1t7DP+6JcZh/m3e7JEiuFrFmkxfL9pn2Eg0Afq3wC0VVJZxgyE1Oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Sg/dl8Cf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ob+zodsg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Sg/dl8Cf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ob+zodsg" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B9xJtx2890192 for ; Thu, 11 Jun 2026 11:27:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v0xd9hfOGsaWtfUYWuk6OyywseKClLK713g5AG71WD0=; b=Sg/dl8CfWRHzEir6 Y10RSfzRycsFABVnelDS+RhEAQICmo3HJEHuldz+Kr8uYkUWpXULpF3JAgWnbpIY W/3e/w6HOwFufeX3dNMRfXJY1i3qFs27VAi+6I6/pHmGOCLHY0QJNM7PPPY5PwGA nUik2Mizf4WCinriED39TvF+oW2VdAxQLHKD/TJox32eHOHNw3adKv7biPm6BXSx VCURM3tpA1Zxkul6JoqzHeTRTzbcYYhk3d0GqzIR6ynPm5vBMamn5MM8Hq1KZlae Pm5BALXcQklWg+kkHboNCxYxXAa2mzQLwRZdl/KJ+xIzq3NZqoXo9kzwBBZ2Sk+q ydJwsQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe79k3q9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 11:27:29 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5178ac43d27so21949731cf.0 for ; Thu, 11 Jun 2026 04:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781177248; x=1781782048; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v0xd9hfOGsaWtfUYWuk6OyywseKClLK713g5AG71WD0=; b=Ob+zodsgDcsgxGgDbJZoH9Vl37Tkjvs6hsj2hMyTn+jgPF2KJe5n7fbc224jMU9Oez XVPSsoRhOFe/rHFNwirYJ0AMyA0xXTkSpEkLZDl2ExQHlpUHRKHTVPpbJqqDsGExmJfO EFWGLmikll97du2D/TJyBII5SolnEmoIAtN7G3LK1mFbwxvZoHjgrEfJbaonh1eQHFFs oKFCOJIQ1FW/V6ZIdYPX3ScPrwZG/v1+ddtD1zdulKCLf9KD3y4M1uQJx5Why/dybRNd Lls9M8JXcIp1xWic5jHH5lVcuy67nEUjkhG9nL2J+ZrohcvKI85EwpHo0x7bSJYOkkHz eJiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781177248; x=1781782048; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v0xd9hfOGsaWtfUYWuk6OyywseKClLK713g5AG71WD0=; b=peVLw70CFF8Del7TympnAEVJRmJMij1I84tQaot/EyDtbpCnmU/mypQC8w4cvlAlUg ixtmGYpwyrURkV+T8nFdYK4jmdQDBXUp02JMZje8D++dnrgSe1U30YIToiWvFK6kahMv GtmTYvTS87EfsWUjQzsoJWaZdp8I2BkjYxOwFGzQ+7PNWLZ+yicWpoA7yiBU4pPVqNQ3 B7XPf/Lw/eVXHOnwohH/jBZYBaKOoyzRRAs4qqU5IKgb7c5z0C+6in53pB3XltxpiqDJ UZApWWCtp3DuSVyY2LZRXYerj8jTblD45H21x3wzviKV5+dFEuDpe6ahOPyCuC2neNBp bazA== X-Forwarded-Encrypted: i=1; AFNElJ8qZGcM1ubqumyNpz4F8lOiUwbmhqgQ+79maSVr8caDEAtn3PtyzYMKxeQPA7FpNk7yHNr04NPNZKwr@vger.kernel.org X-Gm-Message-State: AOJu0Yx6V2ERTnVpNBXdPq3zePqj6O1LnJAe3pRu77C8C2d0O3aGWNCv NrQu31aMSxnVpfFn5DIvF1eE/O8OvDGEMGPB7XRjwKFAYgHyJtFe7424LjF51aRQuWpecvBmMF+ K/g0D0rZ2JzfPdF8HUCZinzNcXaBxMfbar1O1qIouVCfp/7394ntdf1608fj2ZKoY X-Gm-Gg: Acq92OHQ/+zUea9CErvI1qLz9ii0Rrmr2Cc/W2ojM4riBYCLoQG54C7/7x4HbI4vQux x0omwYAJHKOY+2JM8dFKZvTGSzB0wsa6PJ1ybZS7V4yKj5fgBWFj9PBfdIFgvQrbznkrjKk1QP0 AE13zucDJw1YaMaO9BZ9197cVUgcX2tWYff7+fk/cAgBkSjkXtUmrldb7KSWxQUFAVAAY0mwMMU ZREvqJXcnbDV98y/5eB5BB0/Y4X45pnlmfhnJDqC0HWDHVoEudS0hH2Yyyj2Aqm3BPXllR01q0D qffvS5w0q0WlH5uxjHeoi99PixFGH4ATjn2Iy4BDb+UtFXSUqjlqyJcbYCOzwDmLEscAOR3RkzU eEW1wfaTvw9YDgAaoGbEDIlFqW0Q6J8FtL1qu4YVSBF/wQIXDyDBaaXiF X-Received: by 2002:ac8:7f42:0:b0:517:5d21:9899 with SMTP id d75a77b69052e-517ee2161c0mr24244591cf.5.1781177248073; Thu, 11 Jun 2026 04:27:28 -0700 (PDT) X-Received: by 2002:ac8:7f42:0:b0:517:5d21:9899 with SMTP id d75a77b69052e-517ee2161c0mr24244311cf.5.1781177247470; Thu, 11 Jun 2026 04:27:27 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfd4024058dsm7715966b.38.2026.06.11.04.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 04:27:26 -0700 (PDT) Message-ID: <191c4b05-7d66-4338-8321-ebc593379f73@oss.qualcomm.com> Date: Thu, 11 Jun 2026 13:27:23 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC To: Imran Shaik , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260605-shikra-audiocorecc-v1-0-7ee6b5f2d928@oss.qualcomm.com> <20260605-shikra-audiocorecc-v1-3-7ee6b5f2d928@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260605-shikra-audiocorecc-v1-3-7ee6b5f2d928@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 75tuHyAriurEwXAgZGi1_Sncg_8TL8AX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDExNCBTYWx0ZWRfX53I1wUNvuvqr G4oPA4nMZLLJwThsYcMXnDa2oF4iKf4kQ8NibxAHjymKqa8NsebceQnElIPuDA35UfQ78Tiaipg JU7zIVzrcX3slRK9PPxKpxLldQGC1+u8inT2lzZiU0URscWW7Vw3Jyaeam5IsQ1G0erBaNJo7Jd WH/MVOk+4GLoeIc7MaeQsENOHlYgfHu3GFOvRHaBNgzNd5Ido+LJSP4W+28jSZu21dRljh0ntjR 2Y4XYV9srXfeDuTtdA65Nm2P0JdYr07/9us138j2MZNQ8ymL6t5SQ7SPpLTUkRMjHGW+j6u4Jk+ Q7c2DNaf4sKxpSa5m7AhA0088SeAtJcIfNzPxhoBwLcWktkdpVStaWF9p2dpGdIsjU7k2EEKJzl aERPR/4w5YZWcae1CSoTS64w5pDl3hrLyOeMKI/9lWOr9bBY8x+VawNZFlDWeKdFsxs8Ya7zor/ klOE4a+SUQ1SAstiMqg== X-Proofpoint-GUID: 75tuHyAriurEwXAgZGi1_Sncg_8TL8AX X-Authority-Analysis: v=2.4 cv=fbydDUQF c=1 sm=1 tr=0 ts=6a2a9ba1 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=3t_MHGgHUfuoA-dEAxsA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDExNCBTYWx0ZWRfXxOnFVFaM4wvM fUqP5l9LKC0373WzoIIYnojdyw/d3/gaCPuJaS6ptzHDPQykEpUfZSq5IQgO4oCDAf4p2qBCSYz MRuUBc3cce+1CIS2Pz7OFZaG24WiLQY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110114 On 6/5/26 1:26 PM, Imran Shaik wrote: > Add support for Audio Core Clock Controller (AUDIOCORECC) on Qualcomm > Shikra SoC. The AUDIOCORECC clocks and resets support differs based on > Audio subsystem enablement. In the CQM variant, both clocks and resets > are required as Audio is on APPS, while in the CQS variant only reset > control is required since Audio is handled on Modem. Handle these > requirements using variant specific compatibles. > > Signed-off-by: Imran Shaik > --- [...] > +static const struct qcom_reset_map audio_core_cc_shikra_resets[] = { > + [AUDIO_CORE_CSR_RX_SWR_CGCR] = { 0x1c }, > + [AUDIO_CORE_CSR_TX_SWR_CGCR] = { 0x30 }, So these are not "real resets", but for the sake of existing art, we can keep pretending they are bit 1 is HW_CTL (1->hw controlled) and bit 0 is taken into account only if 1 is cleared existing drivers toggle the HW_CTRL bit (meaning it's an maybe-on/surely-on switch rather than off/on).. do we need to rectify that somehow? Konrad