From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540D6C05027 for ; Fri, 17 Feb 2023 09:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229504AbjBQJI1 (ORCPT ); Fri, 17 Feb 2023 04:08:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbjBQJIY (ORCPT ); Fri, 17 Feb 2023 04:08:24 -0500 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 908F15FDD; Fri, 17 Feb 2023 01:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676624897; x=1708160897; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Vc5xOeqdDqnSlLrTyhfLk5SSq2C5UlsLZ+03AMgLRE=; b=h/RFzoWe9L9YmNMz0iAUeVfEb0IAn92Wno7WsKnpRzR6kN15ZPRUy1C2 0s5TL3gsYgaYuNaNXaGPeAIxy3YuBe2rlI5OzDAZuNmIyjHuqAC1/M1qs U8+9cTlG1upqdnYE3aoFPmPAr1vcP1VOJ2w9IaejmQAb5BpDT4u5jHdSw wjhBf5Anybk6YsGKc1mXXWLRVOnCVQoq2VFKv+YQZdoMQf/5MXumV9qo4 Q4R0D0Tq1cPcEREoFKCDwO5e9cdqrnXnxn9cOiFuRhQhIbj4p0cyEVEKT oPGFAQy6OCwo6HRlIei0iYBcMdTqyJp5kMMc96HE7JcBlEKwAzu2NvHs9 Q==; X-IronPort-AV: E=Sophos;i="5.97,304,1669071600"; d="scan'208";a="29150118" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 17 Feb 2023 10:08:15 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 17 Feb 2023 10:08:14 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 17 Feb 2023 10:08:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676624895; x=1708160895; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Vc5xOeqdDqnSlLrTyhfLk5SSq2C5UlsLZ+03AMgLRE=; b=MC8ulJkIsyfcExdobJu3K7EBCiY1L6/94Z00QaI2GpeQJTk/pmnNP29N dvTwLdt4gtAeI753j/BL+LaTJ3+92d7cLOq/EQ+BetamAZg+/dBQzMZsL jLYTCJurkRvjLNCytt3ISeLYgGk28jmwmYbLIeOWZfiBCCkX5BxuoFKSc RPShSWDaKEGRwmhmKxve2X6fu7bWTOReoCCCWYZqQvtPz/3FGozVVrkwP h6uHpIjB0k7PzdWoSW/iCaMnoIPmgzVZr4iuk/oHP+o1VfyrqeIwz7uKV 4POLMhkPFVMkp71HX9H/EN1v119xanz0fvg+EKhuvYHxxOTdEiOSRY8Al g==; X-IronPort-AV: E=Sophos;i="5.97,304,1669071600"; d="scan'208";a="29150117" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 17 Feb 2023 10:08:14 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 15FFE280056; Fri, 17 Feb 2023 10:08:14 +0100 (CET) From: Alexander Stein To: linux-media@vger.kernel.org, Laurent Pinchart Cc: Dave Stevenson , Manivannan Sadhasivam , Sakari Ailus , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH v3 00/15] media: i2c: imx290: Mono support, minor fixes, alternate INCK, and more controls Date: Fri, 17 Feb 2023 10:08:12 +0100 Message-ID: <1924202.PYKUYFuaPT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230215223003.30170-1-laurent.pinchart@ideasonboard.com> References: <20230215223003.30170-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, thanks for the wrap-up. I could test this series on my TQMa8MPxL (i.MX8MP) using ISP and libcamera = as=20 well. I think as well that we're good to go. Best regards, Alexander Am Mittwoch, 15. Februar 2023, 23:29:48 CET schrieb Laurent Pinchart: > Hello, >=20 > This patch series combines the "[PATCH v2 0/2] Add support for mono > version of Sony IMX290 sensor" ([1]) and "[PATCH v2 00/13] imx290: Minor > fixes, support for alternate INCK, and more ctrls" ([2]) previously > submitted by Dave into a single series. >=20 > As promised in my review of v2 of both series, I have tested the changes > with my IMX327 camera sensor, connected to the i.MX8MP ISP, with > libcamera. I haven't noticed any regression (but, full disclaimer, I > haven't tested all the newly features). I think we're thus good to go. >=20 > This version handles all review comments from v2, resulting in the > following changes: >=20 > - Deprecate the sony,imx290 compatible > - Update the DT example to use the new sony,imx290lqr compatible > - Drop unneeded pointer cast > - Don't move imx290_of_match table > - Fix typos >=20 > The code has also been rebased on top of the latest media master branch, > with rebase conflicts and rebase-induced compilation breakages fixed. >=20 > The patches are available from >=20 > git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git > next/media/sensors/imx290 >=20 > [1] > https://lore.kernel.org/linux-media/20230203191644.947643-1-dave.stevenso= n@ > raspberrypi.com [2] > https://lore.kernel.org/linux-media/20230203191811.947697-1-dave.stevenso= n@ > raspberrypi.com >=20 > Dave Stevenson (15): > media: dt-bindings: media: i2c: Add mono version to IMX290 bindings > media: i2c: imx290: Add support for the mono sensor variant > media: i2c: imx290: Match kernel coding style on whitespace > media: i2c: imx290: Set the colorspace fields in the format > media: i2c: imx290: Add V4L2_SUBDEV_FL_HAS_EVENTS and subscribe hooks > media: i2c: imx290: Fix the pixel rate at 148.5Mpix/s > media: i2c: imx290: Support 60fps in 2 lane operation > media: i2c: imx290: Use CSI timings as per datasheet > media: i2c: imx290: Convert V4L2_CID_HBLANK to read/write > media: i2c: imx290: Convert V4L2_CID_VBLANK to read/write > media: i2c: imx290: VMAX is mode dependent > media: i2c: imx290: Remove duplicated write to IMX290_CTRL_07 > media: i2c: imx290: Add support for 74.25MHz external clock > media: i2c: imx290: Add support for H & V Flips > media: i2c: imx290: Add the error code to logs in start_streaming >=20 > .../bindings/media/i2c/sony,imx290.yaml | 24 +- > drivers/media/i2c/imx290.c | 537 ++++++++++++++---- > 2 files changed, 442 insertions(+), 119 deletions(-) >=20 >=20 > base-commit: 83e0f265aa8d0e37cc8e15d318b64da0ec03ff41 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/