devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: "Ondřej Jirman" <megi@xff.cz>,
	"Javier Martinez Canillas" <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	"Robert Mader" <robert.mader@collabora.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Kamil Trzciński" <ayufan@ayufan.eu>,
	"Caleb Connolly" <kc@postmarketos.org>,
	"Jarrah Gosbell" <kernel@undef.tools>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support
Date: Mon, 27 Mar 2023 17:57:39 +0200	[thread overview]
Message-ID: <1924921.PYKUYFuaPT@diego> (raw)
In-Reply-To: <87wn32rynm.fsf@minerva.mail-host-address-is-not-set>

Am Montag, 27. März 2023, 17:39:57 CEST schrieb Javier Martinez Canillas:
> Ondřej Jirman <megi@xff.cz> writes:
> 
> Hell Ondřej,
> 
> > Hi Javier,
> >
> > I've tried the patch on top of linus/master and it works as expected. My
> > DRM test app shows 16.669ms between frames. The display output is ok on
> > developer batch pinephone pro, and is corrupted on production version.
> > Display also doesn't come back after blanking. All as expected.
> >
> > Tested-by: Ondrej Jirman <megi@xff.cz>
> >
> 
> Thanks for testing.
> 
> > A few more comments below.
> >
> 
> I'm OK with these comments but I did a git diff with your orange-pi-6.3
> branch just before posting and this was the latest that's in your tree.
> 
> So feel free to either post a v3 addressing the things you are pointing
> out or lets land this and we can post any further cleanups on top IMO.

I would really like to _not_ apply essentially broken code, so really
would prefer the v3-approach.

Thanks
Heiko



  reply	other threads:[~2023-03-27 15:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27  7:41 [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
2023-03-27  7:55 ` Jarrah
2023-03-27  8:16   ` Javier Martinez Canillas
2023-03-27  9:11   ` Heiko Stübner
2023-03-27  9:15     ` Jarrah
2023-03-27  9:47       ` Javier Martinez Canillas
2023-03-27 13:01 ` Ondřej Jirman
2023-03-27 15:39   ` Javier Martinez Canillas
2023-03-27 15:57     ` Heiko Stübner [this message]
2023-03-27 16:05       ` Javier Martinez Canillas
2023-03-27 16:06       ` Javier Martinez Canillas
2023-03-27 16:15       ` Javier Martinez Canillas
2023-03-27 17:48         ` Ondřej Jirman
2023-03-27 18:15           ` Javier Martinez Canillas
2023-03-27 19:45             ` Ondřej Jirman
2023-03-28  3:08               ` Javier Martinez Canillas
2023-03-27 16:50   ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1924921.PYKUYFuaPT@diego \
    --to=heiko@sntech.de \
    --cc=ayufan@ayufan.eu \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=javierm@redhat.com \
    --cc=kc@postmarketos.org \
    --cc=kernel@undef.tools \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=pbrobinson@gmail.com \
    --cc=robert.mader@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).