From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Linn Subject: RE: Xilinx SYSACE driver and 8-bit attachment Date: Wed, 7 Oct 2009 08:42:15 -0600 Message-ID: <192797ad-5dd4-4ebe-8db3-d381bb949e1e@VA3EHSMHS029.ehs.local> References: <1d3f23370910070013u6307bc42hf7ab243b52d007df@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Class: urn:content-classes:message List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: John Linn , Grant Likely , John Williams Cc: David DeBonis , Michal Simek , devicetree-discuss , Linux Kernel list , Stephen Neuendorffer List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: John Linn > Sent: Wednesday, October 07, 2009 8:24 AM > To: 'Grant Likely'; John Williams > Cc: Linux Kernel list; Michal Simek; David DeBonis; Stephen Neuendorffer;= devicetree-discuss > Subject: RE: Xilinx SYSACE driver and 8-bit attachment > = > I'll look to see if something has changed. It's not clear to me if it ha= s ever been right. > = > It look like we normally use 16 bit mode as that's how BSB generates the = system by default. > = > Thanks, > John > = > > -----Original Message----- > > From: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org [mailto:glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org] On Behalf Of G= rant Likely > > Sent: Wednesday, October 07, 2009 7:35 AM > > To: John Williams > > Cc: Linux Kernel list; Michal Simek; John Linn; David DeBonis; Stephen = Neuendorffer; devicetree- > > discuss > > Subject: Re: Xilinx SYSACE driver and 8-bit attachment > > > > [Added devicetree-discuss to cc: list] > > > > On Wed, Oct 7, 2009 at 1:13 AM, John Williams > > wrote: > > > Hi Grant (it's your driver :) and David D ( and your DTS generator :) > > [...] > > > if (of_find_property(op->node, "8-bit", NULL)) > > [...] > > > doesn't match the properties generated by Xilinx's device tree genera= tor: > > [...] > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= xlnx,mem-width =3D <0x8>; Do you know if the 8 bit mode was ever tested with the "8-bit" property in = the tree? I don't see anything in the device tree generator history to say we ever di= d that "8-bit", but maybe I'm missing something. We are just generating the parameters from the h/w and the memory width is = it. We can always put something in there special, but it seems silly if it= was never used anyway. Thanks, John > > > > > > So, the question is, which should change? > > > > Well, obviously its a device tree generator bug, the driver code is > > perfect. :-P > > > > In all seriousness though, the '8-bit' property has been present for a > > while now and needs to be retained to not break existing users. It > > would be okay for the driver to be modified to *also* check for the > > xlnx,mem-width property, but the better solution is to modify the > > device tree generator. Plus, the '8-bit' property is the documented > > binding in Documentation/powerpc/dts-bindings/xilinx.txt > > > > Cheers, > > g. > > > > -- > > Grant Likely, B.Sc., P.Eng. > > Secret Lab Technologies Ltd. This email and any attachments are intended for the sole use of the named r= ecipient(s) and contain(s) confidential information that may be proprietary= , privileged or copyrighted under applicable law. If you are not the intend= ed recipient, do not read, copy, or forward this email message or any attac= hments. Delete this email message and any attachments immediately.