From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB44C433EF for ; Thu, 28 Apr 2022 06:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244019AbiD1Gw5 (ORCPT ); Thu, 28 Apr 2022 02:52:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244366AbiD1Gw4 (ORCPT ); Thu, 28 Apr 2022 02:52:56 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65426985B6 for ; Wed, 27 Apr 2022 23:49:42 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id m20so7558939ejj.10 for ; Wed, 27 Apr 2022 23:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0oqHpJg2cLzeZdnyUgEioYwr2Elv4tK4koYun3ldTLg=; b=eXItrn2OU2AmdngGOLZiy2Icklw+M9+AgUxk8DIq/wuut1ipjlK7FUFgXeQNzRSObw hi/7hCpukEXhpfvr9AsfQGY0eqHLyZ32HUIZiNfzz2kzod9mpEnx71OB3/CuuMQdrJKA dAM7+J8CPchz4RiVfhkib1BdJdeyKVwI1xcYcC4XV5O2pHg2DFLVsG3ikx0YA6aHbi3y FEWjiyeONhNnaCMYu3VLTjPvBitJhGOrBXf1JrsEzLWBT5EVbLeNMn0tK6AWta3zm2xE LkeojgfkER+edmIUY5M9ybfcJCNbuQpHIDXFPVzpKOXU4mSNaz0YFrjwmwEoEAMFQow0 /c0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0oqHpJg2cLzeZdnyUgEioYwr2Elv4tK4koYun3ldTLg=; b=yKWKSNAJ6sJuCANiRcscC0DYorGOROqJvVBkxY1jeZOvZUFyeYPz/zrmWvPL9fqMoZ vrVUBX5VRUBlb5o+xz85ChVMlT/GJZEYV7vz3nlaoOjfWOtsmSQSkDp++x3KYSJInevn 1zzAGas85SvlZeENZT0ce6Zepk4UlXzTJFlHUtWd37ldIaHR7b9kYkk8uztjGDA6Krhe y8vqex3gWGJyTUcISB+hH/YnSfgJp2TKw25AJMe5IWWrp18m85OhGZ4tdEjdazHYfNlX 52Ec3HVSovkPv6facBzUenIWpka/WhSm8iAXymaoOCivBAbA2EHpBRp/oa92LD3/e4XP Xwkg== X-Gm-Message-State: AOAM530DcURflTwvLfNYK5OozBdnjNKytz6LPAhOqXMeJIeFMKEmna2e t4hK0F/YLUlQ7LrCz7BBSI68uA== X-Google-Smtp-Source: ABdhPJzvIPdv11NF3KnCJxQlhxsCp9ZwZ2BaV4Z4RCSByZ+dEKIiXe8ylO0IZl9d5KNXpuAj+rcsPg== X-Received: by 2002:a17:907:3e8b:b0:6ef:a120:4ea6 with SMTP id hs11-20020a1709073e8b00b006efa1204ea6mr30533414ejc.607.1651128580958; Wed, 27 Apr 2022 23:49:40 -0700 (PDT) Received: from [192.168.0.159] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q8-20020aa7cc08000000b0042617ba637esm994220edt.8.2022.04.27.23.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:49:40 -0700 (PDT) Message-ID: <192d76cd-1d4c-c11a-874e-543e86cd7b64@linaro.org> Date: Thu, 28 Apr 2022 08:49:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/6] dt-bindings: power: supply: qcom,pmi8998-charger: add bindings for smb2 driver Content-Language: en-US To: Caleb Connolly , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Amit Pundir , Sumit Semwal References: <20220427184031.2569442-1-caleb.connolly@linaro.org> <20220427184031.2569442-7-caleb.connolly@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220427184031.2569442-7-caleb.connolly@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/04/2022 20:40, Caleb Connolly wrote: > Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger > driver. > > Signed-off-by: Caleb Connolly This should be a v2, because you already sent a patchset. You make it for example with: `git format-patch -6 -v2` and add changelog to cover-letter (which actually you did...). > --- > .../power/supply/qcom,pmi8998-charger.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml > new file mode 100644 > index 000000000000..41b471713364 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/qcom,pmi8998-charger.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PMI8998/PM660 Switch-Mode Battery Charger "2" > + > +maintainers: > + - Caleb Connolly > + > +properties: > + compatible: > + enum: > + - qcom,pmi8998-charger > + - qcom,pm660-charger > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 4 > + maxItems: 4 No need for minItems if it is equal to max. Skip the minItems, please. Best regards, Krzysztof