From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B1F31B82A for ; Mon, 27 Oct 2025 18:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761588107; cv=none; b=ucqgvXgg9iLLlTA3mq0ofcvCknaabH717T6a/k2O8kB/JTMmk2lLScUvx6zjm18K06d79MotiMsLUfChl260cSMIIJH9qCte+vvjMjLiLRhPfBGHFifOh1prP53vFFBqRJHotZc3FOZ1JvdFfmOLvJjpcEQqf73Yp+L6QAl16mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761588107; c=relaxed/simple; bh=LmXKYxgq5l0W1tOnLSE425z4xENAzicgJcfmXTzUxfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K6rOAMWS6wF+bI+pa+GHMXjV7ERJFuWz+HE7r89sVPNFXOioa9u9S0eUzXsOkj62nDUikKKSiJACHCvs1nm9Hsja+vzgHpC/Cx9+XVbcwbpHAYIebrnb5TvaxTjcgMhaOR4fNsHGqilEQkoFscoc9Y4jSXD48Rp+V718B8ZQ42o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tx5moz92; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tx5moz92" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4270a3464bcso3851800f8f.2 for ; Mon, 27 Oct 2025 11:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761588103; x=1762192903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6aYSYqxdTQx1adiba7waOFSEBjrwgCAPGP21S/4z0WQ=; b=Tx5moz92OOoFHoRRXwIYJebf6dF5m3mqO4VQjP59hFXZImi51pdi3e0QbL1AweBYiS VXXooAHpLDwaZSy2zCJ4Rc+gdqDEJcuARq22s/gzusWQRZD8rr3N3xZl3aXg35f84628 VMfqlI9elpdll9HXGvsAXFKSK94dJjVYuplDslwbc3VAVkJurlIBZPSEeJ13vgRrZXY/ 5SA83jgDGcZLzdk0ObBPIUC2yDRKb+rSa4ieKq1KRqj16FFKK5D5o98NICeY2+kN6eDu F53XSetxkp0+s7yZvVgh1SfySBPv0PI+JIUbkG9EwFCLxshx4fwWRQMOvL0l1aUtBbiU 1XEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761588103; x=1762192903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6aYSYqxdTQx1adiba7waOFSEBjrwgCAPGP21S/4z0WQ=; b=UIF/q5EY2lHEm4vjQ9Mmrg9Nkw/HRPbvDFR7C+4efpOKPbVnr1oiR0SRKHQYKoDOtG tDwIhgWDpzh22s4EMixvqJs7yHOXor2d8y+RqaUhyxRXzKpQooMjoOmq798RSkpYyAgq 5PKRndQwppkXYEQv/NNOh1+VBDIYZplDgph4JH7DRo9pvgmVdcAIqn7ZEiOqSHCKpSiG 3Bk/by0FN3q7OT8+V7daApAp5RW0S/eWg0YdwScTVL7ZTvZsn5piba1+ek9EMwsKdl7s TLqKiV3q9YNV+yTQzULC9njzeXAB2hhI6VqfTiptFSFuqwYAroYQ6m/S0t3AEHhogQv6 Q19w== X-Forwarded-Encrypted: i=1; AJvYcCXVMJ8YQaMGxTnkcVVhWQRluTXCLeFkNF/PWkxUfhGc+orU4Hg1LImHmgk1IO3SLsgOHlqaqzEv0YYL@vger.kernel.org X-Gm-Message-State: AOJu0YzGNJSyQ6uBaelkEt2U/kD1KcUVRNar52ihUCLJ2mBHj8FJxCQh qbBlEt6tk5vmYHPXMAe1EaXRkWVx5EHoinbpwBAIMYRsLNGj0wNflc1Y X-Gm-Gg: ASbGncs/xXoJ1/32sqtVfMn3EGjiiasdw9YQeEU1neDMCfYymPa2C+gIQznNF/RCNj0 q3mPQwtphitmE8MJ3chE0PW+PO9d6XWSISlV3BzXk844iqH9ylA6drXXyDSUE3Hgxpqdw3qN4aY SsNTe4VlyteFGyKw7bQIF7r2Wf87Yrf+sDVcOIGzkBjVWbgJkEDSYTIqMCkMtKi4nMGzQIqUfMv /Tx9//2RHQ/Ichvpu2sGqJmPFxQQ6E6KLJDhHW0K3qFs39+gk0rGiXMqwupd1tIhzHX5eNuOXuy 6WYhQF4xle3F44CQEjrBcDhUIDqk9C4s3iyrkre+Im2guySxItMWR7OWm3IZhoR6TpapbBt1eof 44/qirXWV21HVtbY3qfdt1e0JZlRBZBMqEBSJ8xJ7JLTh6h2Oq6RUCS916w9UWAmqRssXPoprQE RjieHwDipE71qEP/n1ZSIYkzw5Z+IIOAq7yvisu5XxUjNEAt16uO2LHyHS+dDpiegtWY+9 X-Google-Smtp-Source: AGHT+IEqakiIVgvkmH1mzvZg1woizmOdLx0SAbkLPTVvCw4c/LMFkRt84r69g+UhZ/bheKm0gmAdSA== X-Received: by 2002:a05:6000:25f4:b0:429:a7f1:bdda with SMTP id ffacd0b85a97d-429a7f1bf31mr546028f8f.47.1761588102726; Mon, 27 Oct 2025 11:01:42 -0700 (PDT) Received: from jernej-laptop.localnet (178-79-73-218.dynamic.telemach.net. [178.79.73.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7b6fsm15648567f8f.1.2025.10.27.11.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 11:01:42 -0700 (PDT) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: iuncuim , Rob Herring Cc: Vasily Khoruzhick , Yangtao Li , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Philipp Zabel , Andre Przywara , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] dt-bindings: thermal: sun8i: Add A523 THS0/1 controllers Date: Mon, 27 Oct 2025 19:01:40 +0100 Message-ID: <1935223.tdWV9SEqCh@jernej-laptop> In-Reply-To: <20251026210905.GA2941518-robh@kernel.org> References: <20251025043129.160454-1-iuncuim@gmail.com> <20251025043129.160454-2-iuncuim@gmail.com> <20251026210905.GA2941518-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, Dne nedelja, 26. oktober 2025 ob 22:09:05 Srednjeevropski standardni =C4=8D= as je Rob Herring napisal(a): > On Sat, Oct 25, 2025 at 12:31:24PM +0800, iuncuim wrote: > > From: Mikhail Kalashnikov > >=20 > > Add a binding for D1/T113s thermal sensor controller. Add dt-bindings > > description of the thermal sensors in the A523 processor. > > The controllers require activation of the additional frequency of the > > associated gpadc controller, so a new clock property has been added. > >=20 > > The calibration data is split into two cells that are in different areas > > of nvmem. Both controllers require access to both memory cell, so a new > > property nvmem-cells has been added. To maintain backward compatibility, > > the name of the old cell remains the same and the new nvmem-cell-names = is > > called calibration-second-part > >=20 > > Signed-off-by: Mikhail Kalashnikov > > --- > > .../thermal/allwinner,sun8i-a83t-ths.yaml | 56 ++++++++++++++++++- > > 1 file changed, 53 insertions(+), 3 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-= a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a= 83t-ths.yaml > > index 3e61689f6..b2f750ef2 100644 > > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-th= s.yaml > > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-th= s.yaml > > @@ -24,18 +24,23 @@ properties: > > - allwinner,sun50i-h5-ths > > - allwinner,sun50i-h6-ths > > - allwinner,sun50i-h616-ths > > + - allwinner,sun55i-a523-ths0 > > + - allwinner,sun55i-a523-ths1 > > =20 > > clocks: > > minItems: 1 > > items: > > - description: Bus Clock > > - description: Module Clock > > + - description: GPADC Clock > > =20 > > clock-names: > > minItems: 1 > > + maxItems: 2 >=20 > How can the max be both 2 and... >=20 > > items: > > - const: bus > > - const: mod > > + - const: gpadc >=20 > ...3 entries? >=20 Because old variant uses "bus" and "mod" and new variant uses "bus" and "gpadc" and none of them uses all 3 entries. Although, I guess we can simplify and just use "mod" in both cases. Best regards, Jernej