From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jung Daehwan <dh10.jung@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] usb: host: xhci-plat: Add support for XHCI_WRITE_64_HI_LO_QUIRK
Date: Tue, 4 Jun 2024 08:20:44 +0200 [thread overview]
Message-ID: <1935a30f-b4fd-4240-93f0-e2baf218223d@kernel.org> (raw)
In-Reply-To: <20240603085111.GF23593@ubuntu>
On 03/06/2024 10:51, Jung Daehwan wrote:
>>>>>
>>>>> + if (device_property_read_bool(tmpdev, "write-64-hi-lo-quirk"))
>>>>> + xhci->quirks |= XHCI_WRITE_64_HI_LO;
>>>>
>>>> Where is any user of this property (DTS)? Just to clarify: your
>>>> downstream does not matter really.
>>>>
>>>
>>> This is set by dwc3 parent node by software node.
>>>
>>> [PATCH v2 1/5] dt-bindings: usb: snps,dwc3: Add 'snps,xhci-write-64-hi-lo-quirk' quirk
>>> https://lore.kernel.org/r/1717135657-120818-2-git-send-email-dh10.jung@samsung.com/
>>
>> This is not a patch to DTS.
>>
>>
>
> This is set by software node from dwc3. That's why I think this patch doesn't
> need DTS patch. I would add DTS patch in dwc3 not xhci if it's needed.
>
What?
I asked you question which upstream SoC (link to DTS) uses it, and you
say that "no need for DTS patch"? That's not an answer.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-04 6:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240531060711epcas2p4ee3987a647f6a49b589b783d14ea25ae@epcas2p4.samsung.com>
2024-05-31 6:07 ` [PATCH v2 0/5] usb: Add quirk for writing high-low order Daehwan Jung
[not found] ` <CGME20240531060728epcas2p358edd115ee217a50712f1ca3b3b22bd7@epcas2p3.samsung.com>
2024-05-31 6:07 ` [PATCH v2 1/5] dt-bindings: usb: snps,dwc3: Add 'snps,xhci-write-64-hi-lo-quirk' quirk Daehwan Jung
2024-05-31 8:10 ` Krzysztof Kozlowski
2024-06-03 3:03 ` Jung Daehwan
2024-06-03 6:57 ` Krzysztof Kozlowski
2024-06-03 8:36 ` Jung Daehwan
2024-06-04 6:19 ` Krzysztof Kozlowski
[not found] ` <CGME20240531060729epcas2p2d895a441b017f1797b1bc1e2558d9e1b@epcas2p2.samsung.com>
2024-05-31 6:07 ` [PATCH v2 2/5] usb: dwc3: Support quirk for writing high-low order Daehwan Jung
2024-06-04 0:16 ` Thinh Nguyen
2024-06-04 1:59 ` Jung Daehwan
[not found] ` <CGME20240531060729epcas2p1df12dd3b14c5fa2fa0716f72010b3dbd@epcas2p1.samsung.com>
2024-05-31 6:07 ` [PATCH v2 3/5] dt-bindings: usb: xhci: Add 'write-64-hi-lo-quirk' quirk Daehwan Jung
2024-05-31 8:12 ` Krzysztof Kozlowski
2024-06-03 3:34 ` Jung Daehwan
2024-06-03 6:58 ` Krzysztof Kozlowski
2024-06-03 8:25 ` Jung Daehwan
2024-06-04 0:30 ` Thinh Nguyen
2024-06-04 2:19 ` Jung Daehwan
[not found] ` <CGME20240531060731epcas2p4d4cb51e9bb30bab4195d2d12567b1391@epcas2p4.samsung.com>
2024-05-31 6:07 ` [PATCH v2 4/5] xhci: Add a quirk for writing ERST in high-low order Daehwan Jung
[not found] ` <CGME20240531060731epcas2p4f14afae9f00a7e71e6bd3863f0a51441@epcas2p4.samsung.com>
2024-05-31 6:07 ` [PATCH v2 5/5] usb: host: xhci-plat: Add support for XHCI_WRITE_64_HI_LO_QUIRK Daehwan Jung
2024-05-31 8:12 ` Krzysztof Kozlowski
2024-06-03 3:44 ` Jung Daehwan
2024-06-03 6:56 ` Krzysztof Kozlowski
2024-06-03 8:51 ` Jung Daehwan
2024-06-04 6:20 ` Krzysztof Kozlowski [this message]
2024-06-05 1:50 ` Jung Daehwan
2024-06-05 6:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1935a30f-b4fd-4240-93f0-e2baf218223d@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dh10.jung@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).