devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-kernel@vger.kernel.org,
	zhangqing <zhangqing@rock-chips.com>,
	Detlev Casanova <detlev.casanova@collabora.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, kernel@collabora.com,
	Finley Xiao <finley.xiao@rock-chips.com>,
	YouMin Chen <cym@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
	Sugar Zhang <sugar.zhang@rock-chips.com>
Subject: Re: [PATCH v2 3/3] clk: rockchip: Add clock controller for the RK3576
Date: Tue, 06 Aug 2024 17:13:30 +0200	[thread overview]
Message-ID: <1936032.MyG8hOvIyE@diego> (raw)
In-Reply-To: <2335430.ElGaqSPkdT@trenzalore>

Hi Detlev,

Am Dienstag, 6. August 2024, 16:15:41 CEST schrieb Detlev Casanova:
> The suggestion from Heiko was that those reset should be managed by the 
> subsystems that use them, because they are on a different offset and therefore 
> seem to be on a different core.
> 
> But I think I will include them here like you suggested because:
>  - That's actually how it is done for rk3588 (which is quite close th rk3576),
>  - According to you and the TRM, those resets are on the same core, just with 
> big offsets.
> 
> Having the same structure for both SoC makes sense for maintening them.

Just without the big offsets between areas please.
Similar to how rk3588 does it already.

And yep most likely they are in the same block. Just that huge block of
space for the cru somehow suggested some algamation of multiple ones,
but looking up the rk3588, you're right that it really seems to be one block.

I did request the rk3576 TRM from Rockchip - hopefully they'll follow up
with that at some point ;-) .


Heiko




      reply	other threads:[~2024-08-06 15:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 21:35 [PATCH v2 0/3] Add CRU support for rk3576 SoC Detlev Casanova
2024-08-02 21:35 ` [PATCH v2 1/3] dt-bindings: clock: add rk3576 cru bindings Detlev Casanova
2024-08-04  9:52   ` Krzysztof Kozlowski
2024-08-06 21:22     ` Detlev Casanova
2024-08-07  5:50       ` Krzysztof Kozlowski
2024-08-02 21:35 ` [PATCH v2 2/3] clk: rockchip: Add dt-binding header for rk3576 Detlev Casanova
2024-08-04  9:53   ` Krzysztof Kozlowski
2024-08-06 15:23     ` Detlev Casanova
2024-08-07  5:49       ` Krzysztof Kozlowski
2024-08-02 21:35 ` [PATCH v2 3/3] clk: rockchip: Add clock controller for the RK3576 Detlev Casanova
2024-08-03  6:53   ` zhangqing
     [not found]   ` <a9a9219d-325c-4afa-b40c-b261ff95263c@rock-chips.com>
2024-08-06 14:15     ` Detlev Casanova
2024-08-06 15:13       ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1936032.MyG8hOvIyE@diego \
    --to=heiko@sntech.de \
    --cc=cl@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=cym@rock-chips.com \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sugar.zhang@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).