From: "Arnd Bergmann" <arnd@arndb.de>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
andi.shyti@kernel.org, "Alim Akhtar" <alim.akhtar@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Sam Protsenko" <semen.protsenko@linaro.org>
Cc: "André Draszik" <andre.draszik@linaro.org>,
saravanak@google.com,
"William McVicker" <willmcvicker@google.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 05/13] tty: serial: samsung: add gs101 earlycon support
Date: Thu, 14 Dec 2023 13:01:21 +0100 [thread overview]
Message-ID: <1938fcf1-eb5d-4723-a6c6-d2fe2c6dd1c0@app.fastmail.com> (raw)
In-Reply-To: <20231214105243.3707730-6-tudor.ambarus@linaro.org>
On Thu, Dec 14, 2023, at 11:52, Tudor Ambarus wrote:
> +static int __init gs101_early_console_setup(struct earlycon_device *device,
> + const char *opt)
> +{
> + /* gs101 always expects MMIO32 register accesses. */
> + device->port.iotype = UPIO_MEM32;
> +
> + return s5pv210_early_console_setup(device, opt);
> +}
> +
> +OF_EARLYCON_DECLARE(gs101, "google,gs101-uart", gs101_early_console_setup);
It looks like this is already done by of_setup_earlycon() based on
the reg-io-width property. Any idea why it doesn't work with the
normal s5pv210_early_console_setup() function?
Arnd
next prev parent reply other threads:[~2023-12-14 12:01 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 10:52 [PATCH 00/13] GS101 Oriole: CMU_PERIC0 support and USI updates Tudor Ambarus
2023-12-14 10:52 ` [PATCH 01/13] dt-bindings: clock: google,gs101: fix CMU_TOP gate clock names Tudor Ambarus
2023-12-14 15:07 ` Sam Protsenko
2023-12-14 15:16 ` Tudor Ambarus
2023-12-14 15:22 ` Sam Protsenko
2023-12-14 16:04 ` Peter Griffin
2023-12-15 8:13 ` Krzysztof Kozlowski
2023-12-15 10:23 ` Tudor Ambarus
2023-12-15 19:24 ` Krzysztof Kozlowski
2023-12-15 19:25 ` Krzysztof Kozlowski
2023-12-18 6:50 ` Tudor Ambarus
2023-12-14 10:52 ` [PATCH 02/13] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit Tudor Ambarus
2023-12-14 15:12 ` Sam Protsenko
2023-12-20 15:07 ` Rob Herring
2023-12-21 7:20 ` Tudor Ambarus
2023-12-22 17:56 ` Peter Griffin
2023-12-27 12:38 ` Tudor Ambarus
2023-12-28 7:30 ` Krzysztof Kozlowski
2023-12-28 7:49 ` Tudor Ambarus
2023-12-14 10:52 ` [PATCH 03/13] dt-bindings: i2c: exynos5: add google,gs101-hsi2c compatible Tudor Ambarus
2023-12-14 13:06 ` Wolfram Sang
2023-12-14 15:12 ` Sam Protsenko
2023-12-15 19:42 ` Rob Herring
2023-12-14 10:52 ` [PATCH 04/13] dt-bindings: serial: samsung: gs101: make reg-io-width required property Tudor Ambarus
2023-12-14 15:14 ` Sam Protsenko
2023-12-15 7:58 ` Krzysztof Kozlowski
2023-12-14 10:52 ` [PATCH 05/13] tty: serial: samsung: add gs101 earlycon support Tudor Ambarus
2023-12-14 12:01 ` Arnd Bergmann [this message]
2023-12-14 13:52 ` Tudor Ambarus
2023-12-14 14:19 ` Arnd Bergmann
2023-12-14 14:31 ` Tudor Ambarus
2023-12-15 8:01 ` Krzysztof Kozlowski
2023-12-21 7:41 ` Tudor Ambarus
2023-12-14 10:52 ` [PATCH 06/13] clk: samsung: gs101: add support for cmu_peric0 Tudor Ambarus
2023-12-14 10:52 ` [PATCH 07/13] clk: samsung: gs101: mark PERIC0 IP TOP gate clock as critical Tudor Ambarus
2023-12-14 15:37 ` Sam Protsenko
2023-12-14 16:01 ` Tudor Ambarus
2023-12-14 16:09 ` Sam Protsenko
2023-12-14 16:15 ` Tudor Ambarus
2023-12-14 16:43 ` Sam Protsenko
2023-12-19 16:47 ` Tudor Ambarus
2023-12-19 17:31 ` Sam Protsenko
2023-12-20 14:22 ` Tudor Ambarus
2023-12-20 15:12 ` Sam Protsenko
2023-12-14 10:52 ` [PATCH 08/13] arm64: dts: exynos: gs101: enable cmu-peric0 clock controller Tudor Ambarus
2023-12-14 15:39 ` Sam Protsenko
2023-12-15 8:02 ` Krzysztof Kozlowski
2023-12-14 10:52 ` [PATCH 09/13] arm64: dts: exynos: gs101: update USI UART to use peric0 clocks Tudor Ambarus
2023-12-14 15:42 ` Sam Protsenko
2023-12-14 10:52 ` [PATCH 10/13] arm64: dts: exynos: gs101: define USI8 with I2C configuration Tudor Ambarus
2023-12-14 15:51 ` Sam Protsenko
2023-12-15 8:04 ` Krzysztof Kozlowski
2023-12-14 10:52 ` [PATCH 11/13] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole Tudor Ambarus
2023-12-14 15:55 ` Sam Protsenko
2023-12-15 8:07 ` Krzysztof Kozlowski
2023-12-14 10:52 ` [PATCH 12/13] arm64: defconfig: sync with savedefconfig Tudor Ambarus
2023-12-14 12:08 ` Arnd Bergmann
2023-12-14 13:19 ` Krzysztof Kozlowski
2023-12-14 14:09 ` Tudor Ambarus
2023-12-14 10:52 ` [PATCH 13/13] arm64: defconfig: make at24 eeprom builtin Tudor Ambarus
2023-12-14 13:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1938fcf1-eb5d-4723-a6c6-d2fe2c6dd1c0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).