* [PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node
@ 2019-02-24 21:52 Jonas Karlman
[not found] ` <AM3PR03MB0966E8AA93CC1B7CA355CECEAC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Jonas Karlman @ 2019-02-24 21:52 UTC (permalink / raw)
To: linux-rockchip@lists.infradead.org
Cc: Heiko Stuebner, Rob Herring, Mark Rutland,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonas Karlman
The following message can be seen during boot:
rockchip-thermal ff280000.tsadc: Missing rockchip,grf property
Fix this by adding rockchip,grf property to tsadc node.
Fixes: b67d6bc38823 ("ARM: dts: rockchip: add main thermal info to rk3288")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
arch/arm/boot/dts/rk3288.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index ca7d52daa8fb..b577f3e41811 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -569,6 +569,7 @@
pinctrl-1 = <&otp_out>;
pinctrl-2 = <&otp_gpio>;
#thermal-sensor-cells = <1>;
+ rockchip,grf = <&grf>;
rockchip,hw-tshut-temp = <95000>;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node
[not found] ` <AM3PR03MB0966E8AA93CC1B7CA355CECEAC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2019-03-12 8:42 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2019-03-12 8:42 UTC (permalink / raw)
To: Jonas Karlman
Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Am Sonntag, 24. Februar 2019, 22:52:00 CET schrieb Jonas Karlman:
> The following message can be seen during boot:
>
> rockchip-thermal ff280000.tsadc: Missing rockchip,grf property
>
> Fix this by adding rockchip,grf property to tsadc node.
>
> Fixes: b67d6bc38823 ("ARM: dts: rockchip: add main thermal info to rk3288")
> Signed-off-by: Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>
applied for 5.2
The warning doesn't affect rk3288 (v2 tsadc) and the grf requirement
only got introduced later on after the rk3288 tsadc node, so I've dropped
the Fixes tag, also reducing the workload of the stable poeple
In general it looks like driver quality of the tsadc deteriorated over time,
as it shouldn't warn about missing GRF references on platforms not
needing it in the first place. And GRF locations should of course also
live in the per-soc data structures as GRF register never are stable
like the constants currently suggest.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-12 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-24 21:52 [PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node Jonas Karlman
[not found] ` <AM3PR03MB0966E8AA93CC1B7CA355CECEAC790-XQTXrJX/giFAc9da7WRX18eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-03-12 8:42 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).