[PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node

[PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node

[Jonas Karlman]

The following message can be seen during boot:

  rockchip-thermal ff280000.tsadc: Missing rockchip,grf property

Fix this by adding rockchip,grf property to tsadc node.

Fixes: b67d6bc38823 ("ARM: dts: rockchip: add main thermal info to rk3288")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 arch/arm/boot/dts/rk3288.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index ca7d52daa8fb..b577f3e41811 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -569,6 +569,7 @@
 		pinctrl-1 = <&otp_out>;
 		pinctrl-2 = <&otp_gpio>;
 		#thermal-sensor-cells = <1>;
+		rockchip,grf = <&grf>;
 		rockchip,hw-tshut-temp = <95000>;
 		status = "disabled";
 	};
-- 
2.17.1

Re: [PATCH] ARM: dts: rockchip: rk3288: fix missing grf reference in tsadc node

[Heiko Stuebner]

Am Sonntag, 24. Februar 2019, 22:52:00 CET schrieb Jonas Karlman:
> The following message can be seen during boot:
> 
>   rockchip-thermal ff280000.tsadc: Missing rockchip,grf property
> 
> Fix this by adding rockchip,grf property to tsadc node.
> 
> Fixes: b67d6bc38823 ("ARM: dts: rockchip: add main thermal info to rk3288")
> Signed-off-by: Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>

applied for 5.2

The warning doesn't affect rk3288 (v2 tsadc) and the grf requirement
only got introduced later on after the rk3288 tsadc node, so I've dropped
the Fixes tag, also reducing the workload of the stable poeple

In general it looks like driver quality of the tsadc deteriorated over time,
as it shouldn't warn about missing GRF references on platforms not
needing it in the first place. And GRF locations should of course also
live in the per-soc data structures as GRF register never are stable
like the constants currently suggest.