From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C352E12E68 for ; Tue, 6 Feb 2024 18:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707244048; cv=none; b=JXZ7DFff1diyfzFVzCE145MrjgzAQtm+e7SMReP8j+PfV7Wxu/95tfSfH9IWK86Fgna13cadQjWsQWcbIXrqDmowL2U6e0CxKQ3rM1QMp/7P4LqILqoAy0kMc40M+NCcQ0s9icBClF/kZnabt35pXUvaobQT2KEHEtcVX2i67fY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707244048; c=relaxed/simple; bh=wnekn1bABAFDmOd1SWT7vofGBAS44WbvE4UnXhsUKFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oi+DNwZlSXjonPCkK6NxXboXgQrfNhBqOzHCERdm1JBDIsbkmHeGOtYHGNbeHwp3rmkEGVbpcKQbnxArCw10PjWhLQWQuyTL/UDYvF2Y+d50D1Ba6S8+yipqZiXYDrKOk0OBtK60aVSQDBAiTMgr1Q8gcw5WtYoQkkODz284AVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lALPf4v+; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lALPf4v+" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40fdc63f4feso19784315e9.3 for ; Tue, 06 Feb 2024 10:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707244044; x=1707848844; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ipPNtjAoCMbPauAQdellneDW30G0UkwQXFB79ZrD6Vc=; b=lALPf4v+q8lQ/iiLAIPCNcA3aP4W00rhJS8s/1BaDRpB4CjQ5nM6Tb6UY228ILuWe1 Zo9z9Xwf8TIMUq69ANhuN6ACVCHpsQuvtm/7J/X98p5rUWcnL++G43maI2HZ6Pgbl/o0 eoPtOxDGlZTqoREUEGclem4tTfm56oJJ0YfXjWOVo2wSEGzgAP/XqCuF+7mi0gX2wjwe BEKIqE6pAtcPzfXzYPUzhnlW5D5hAjyxmPue+DED3C44oDOHYZi1sOfFbZ7CGZpTldWi rU3muMwsfYo7RG5u2zM5Npzo17Fwh/v+JQV6/b0i7XHIhAW8M5O6t8LtUA2AaSA6CSOB D72w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707244044; x=1707848844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ipPNtjAoCMbPauAQdellneDW30G0UkwQXFB79ZrD6Vc=; b=rHcCrnTyvnSgtPTMAhUJFGX/c7vazg+T3XXkUIC/bFU1o+XgH7esrs7GsEPuH0UwxY VIabY1S/AQuCI7VDuuUxFPWWrJY1wiQb6AL6ZWQeQHTzanXy7kQlBjrKkesSoPqDbN2K oGFOi0QV8nCTB7q0V9Jyf+f/FOkEpp0XxJrJvfc+QgBzz7kLByNjAskk9tbj5UqsJYGy 6rUCXl2Wvuz6ZkFef9T6IVJQqaeUXOpUb28g+kcxzby9Kej1DEttRrrdMtZU3spAGJEq 9QnqnubgPnnZHKfwXTVpyKmevyPruPjL2xGtcDPCsL215Kd3RcJv1EjrwaViy0p7QEhD eDqg== X-Gm-Message-State: AOJu0Yx/a8gKrQrKsGmRRz/oZWcsas4YrWUKi9TLPN5iyhSLgXV+broo 6bFmyXb4yAHA2AjPTO/vwOrzQHDB8fbisC55iPP3irVwHaQemWgU X-Google-Smtp-Source: AGHT+IGV9JV4dxZmENMUO4jOIemvup76JYuwphgRFZeXZ6++PKk8E52IfBShTQbBax8tPmZwGp+rIQ== X-Received: by 2002:a05:600c:444a:b0:40f:ddcf:37e9 with SMTP id v10-20020a05600c444a00b0040fddcf37e9mr3031834wmn.9.1707244043798; Tue, 06 Feb 2024 10:27:23 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWWCP1pAdp00/pkYdhnZdQ9Ox5vUBsA73nmgONiHa1tcZtvNBy8hPcXlB3zu8aVI+jtrRU5S7bHD/H4PKA0YPxcae272iY+4TP3zcBVLLjac5VWTIPvkAyN8XNI/Wxe9xciO5ITCEoxp6PDXJPazGcuc7pq8RrGPoQ3bok3b6j8u83QR1Nzh5HC8SXu9yjrVCOabEuGXmo8CyC+WTU8ErDbzjq7g3VxiGjPbLbP2bPkh6gwHNPF+v9LufGT6b48kJNqYP0RqHZY1F04Xi6fzEJ40xGQKYp5FCb658rBycv8NlW3bQ09FN6M5OTKo8R715QtSZcWbDzjpjKNzcfFw1npLw== Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id v8-20020a05600c470800b0040ff583e17csm1059487wmo.9.2024.02.06.10.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:27:23 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andre Przywara Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Alilovic Subject: Re: [PATCH 3/3] arm64: dts: allwinner: Add Jide Remix Mini PC support Date: Tue, 06 Feb 2024 19:27:22 +0100 Message-ID: <1957012.PYKUYFuaPT@jernej-laptop> In-Reply-To: <10413667.nUPlyArG6x@jernej-laptop> References: <20240204094404.149776-1-andre.przywara@arm.com> <8d9d1d7c-8066-4400-8fe4-68aa0e28023d@arm.com> <10413667.nUPlyArG6x@jernej-laptop> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne torek, 06. februar 2024 ob 19:23:35 CET je Jernej =C5=A0krabec napisal(= a): > Dne torek, 06. februar 2024 ob 19:13:46 CET je Andre Przywara napisal(a): > > Hi Jernej, > >=20 > > On 06/02/2024 18:32, Jernej =C5=A0krabec wrote: > > > Dne torek, 06. februar 2024 ob 01:47:05 CET je Andre Przywara napisal= (a): > > >> Hi Jernej, > > >> > > >> thanks for having a look! > > >> > > >> On 05/02/2024 19:20, Jernej =C5=A0krabec wrote: > > >>> Dne ponedeljek, 05. februar 2024 ob 19:12:45 CET je Jernej =C5=A0kr= abec napisal(a): > > >>>> Hi Andre! > > >>>> > > >>>> Dne nedelja, 04. februar 2024 ob 10:44:04 CET je Andre Przywara na= pisal(a): > > >>>>> The Remix Mini PC is a "mini computer" using the Allwinner H64 So= C, > > >>>>> which appears to be just a relabelled A64. It was launched in 201= 5 by > > >>>>> the now defunct company Jide, and shipped with a desktop optimised > > >>>>> version of Android. It features > > >>>>> - Allwinner H64 Soc (4 * Arm Cortex-A53 cores) > > >>>>> - 1 or 2 GB DRAM > > >>>>> - 8 or 16 GB eMMC flash > > >>>>> - 100 MBit Ethernet port (using an X-Powers AC200 PHY) > > >>>>> - RTL8723BS WiFi & Bluetooth chip > > >>>>> - HDMI port > > >>>>> - two USB 2.0 ports > > >>>>> - 3.5mm AV port > > >>>>> - microSD card slot > > >>>>> > > >>>>> The devicetree covers most peripherals, though there is no agreed > > >>>>> binding for the PHY chip yet, so this is left out. > > >>>>> > > >>>>> Signed-off-by: Andre Przywara > > >>>>> --- > > >>>>> arch/arm64/boot/dts/allwinner/Makefile | 1 + > > >>>>> .../allwinner/sun50i-h64-remix-mini-pc.dts | 357 ++++++++++= ++++++++ > > >>>>> 2 files changed, 358 insertions(+) > > >>>>> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h64-re= mix-mini-pc.dts > > >>>>> > > >>>>> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/= boot/dts/allwinner/Makefile > > >>>>> index 91d505b385de..2db3b15ad09f 100644 > > >>>>> --- a/arch/arm64/boot/dts/allwinner/Makefile > > >>>>> +++ b/arch/arm64/boot/dts/allwinner/Makefile > > >>>>> @@ -16,6 +16,7 @@ dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-pineta= b.dtb > > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-pinetab-early-adopter= =2Edtb > > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-sopine-baseboard.dtb > > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a64-teres-i.dtb > > >>>>> +dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h64-remix-mini-pc.dtb > > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-a100-allwinner-perf1.dtb > > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h5-bananapi-m2-plus.dtb > > >>>>> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h5-bananapi-m2-plus-v1.2.= dtb > > >>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h64-remix-mini-= pc.dts b/arch/arm64/boot/dts/allwinner/sun50i-h64-remix-mini-pc.dts > > >>>>> new file mode 100644 > > >>>>> index 000000000000..537923a541a8 > > >>>>> --- /dev/null > > >>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h64-remix-mini-pc.dts > > >>>>> @@ -0,0 +1,357 @@ > > >>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > >>>>> +// Copyright (c) 2018 ARM Ltd. > > >>>> > > >>>> Shouldn't be 2024? > > >> > > >> Well, that just documents that sad fact that I indeed created this f= ile > > >> 6 years ago, but just managed now to actually send this. Is there a > > >> requirement for this being "recent"? > > >=20 > > > Not really, but it's strange looking. Some might incorrectly assume t= hat it's > > > present in the kernel longer than it really is. > >=20 > > OK, I will put in 2023, as this is when I touched this again. > >=20 > > >>>> > > >>>>> + > > >>>>> +/dts-v1/; > > >>>>> + > > >>>>> +#include "sun50i-a64.dtsi" > > >>>>> +#include "sun50i-a64-cpu-opp.dtsi" > > >>>>> + > > >>>>> +#include > > >>>>> + > > >>>>> +/ { > > >>>>> + model =3D "Remix Mini PC"; > > >>>>> + compatible =3D "jide,remix-mini-pc", "allwinner,sun50i-h64", > > >>>>> + "allwinner,sun50i-a64"; > > >>>>> + > > >>>>> + aliases { > > >>>>> + ethernet1 =3D &rtl8723bs; > > >>>>> + serial0 =3D &uart0; > > >>>>> + }; > > >>>>> + > > >>>>> + chosen { > > >>>>> + stdout-path =3D "serial0:115200n8"; > > >>>>> + }; > > >>>>> + > > >>>>> + hdmi-connector { > > >>>>> + compatible =3D "hdmi-connector"; > > >>>>> + type =3D "a"; > > >>>>> + > > >>>>> + port { > > >>>>> + hdmi_con_in: endpoint { > > >>>>> + remote-endpoint =3D <&hdmi_out_con>; > > >>>>> + }; > > >>>>> + }; > > >>>>> + }; > > >>>>> + > > >>>>> + reg_vcc5v: regulator-5v { > > >>>>> + /* board wide 5V supply directly from the DC input */ > > >>>>> + compatible =3D "regulator-fixed"; > > >>>>> + regulator-name =3D "vcc-5v"; > > >>>>> + regulator-min-microvolt =3D <5000000>; > > >>>>> + regulator-max-microvolt =3D <5000000>; > > >>>>> + regulator-always-on; > > >>>>> + }; > > >>>>> + > > >>>>> + wifi_pwrseq: wifi_pwrseq { > > >>>>> + compatible =3D "mmc-pwrseq-simple"; > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + reset-gpios =3D <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ > > >>>>> + post-power-on-delay-ms =3D <200>; > > >>>>> + }; > > >>>>> +}; > > >>>>> + > > >>>>> +&codec { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&codec_analog { > > >>>>> + cpvdd-supply =3D <®_eldo1>; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&cpu0 { > > >>>>> + cpu-supply =3D <®_dcdc2>; > > >>>>> +}; > > >>>>> + > > >>>>> +&cpu1 { > > >>>>> + cpu-supply =3D <®_dcdc2>; > > >>>>> +}; > > >>>>> + > > >>>>> +&cpu2 { > > >>>>> + cpu-supply =3D <®_dcdc2>; > > >>>>> +}; > > >>>>> + > > >>>>> +&cpu3 { > > >>>>> + cpu-supply =3D <®_dcdc2>; > > >>>>> +}; > > >>>>> + > > >>>>> +&dai { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&de { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&ehci0 { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&ehci1 { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&hdmi { > > >>>>> + hvcc-supply =3D <®_dldo1>; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&hdmi_out { > > >>>>> + hdmi_out_con: endpoint { > > >>>>> + remote-endpoint =3D <&hdmi_con_in>; > > >>>>> + }; > > >>>>> +}; > > >>>>> + > > >>>>> +/* Connects to the AC200 chip */ > > >>>>> +&i2c0 { > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + pinctrl-0 =3D <&i2c0_pins>; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&i2c0_pins { > > >>>>> + bias-pull-up; > > >>>>> +}; > > >>>>> + > > >>>>> +&mmc0 { > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + pinctrl-0 =3D <&mmc0_pins>; > > >>>>> + vmmc-supply =3D <®_dcdc1>; > > >>>>> + cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_LOW>; > > >>>>> + disable-wp; > > >>>>> + bus-width =3D <4>; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&mmc1 { > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + pinctrl-0 =3D <&mmc1_pins>; > > >>>>> + vmmc-supply =3D <®_aldo1>; > > >>>>> + vqmmc-supply =3D <®_dldo4>; > > >>>>> + mmc-pwrseq =3D <&wifi_pwrseq>; > > >>>>> + bus-width =3D <4>; > > >>>>> + non-removable; > > >>>>> + status =3D "okay"; > > >>>>> + > > >>>>> + rtl8723bs: wifi@1 { > > >>>>> + reg =3D <1>; > > >>>>> + interrupt-parent =3D <&r_pio>; > > >>>>> + interrupts =3D <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ > > >>>>> + interrupt-names =3D "host-wake"; > > >>>>> + }; > > >>>> > > >>>> Node without compatible doesn't help. Please remove it. > > >> > > >> Huh, but where do I put the the IRQ line then? And every other RTL87= 23BS > > >> user seems to do the same? > > >=20 > > > It's good, sorry for the noise. > >=20 > > Just for the records, and for my own reference: > > Since there is no "ranges" property in the MMC node, the Linux platform= =20 > > bus driver is not automatically traversing any child nodes. So we don't= =20 > > need a compatible string. Instead it's a new addressing scheme (this=20 > > obsolete MMC "bus" address, like SPI or I2C), so it's up to the driver= =20 > > to do the child iteration. And it will match device #1 to reg <1>, and= =20 > > use that node, as Chen-Yu mentioned. > >=20 > > >>>> > > >>>>> +}; > > >>>>> + > > >>>>> +&mmc2 { > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + pinctrl-0 =3D <&mmc2_pins>, <&mmc2_ds_pin>; > > >>>>> + vmmc-supply =3D <®_dcdc1>; > > >>>>> + vqmmc-supply =3D <®_eldo1>; > > >>>>> + bus-width =3D <8>; > > >>>>> + non-removable; > > >>>>> + mmc-ddr-1_8v; > > >>>>> + mmc-hs200-1_8v; > > >>>> > > >>>> Aren't these speed modes enabled by default? > > >> > > >> Enabled by who? Our current sunxi-mmc driver? I cannot find anything= in > > >> the binding that suggests that there would be some default settings. > > >=20 > > > Looking at Linux sunxi mmc driver, mmc-ddr-1_8v is enabled by default= for > > > "new timings" variants except for H5. Anyway... > >=20 > > But this is a Linux implementation detail, which we should not rely on= =20 > > in a DT? And if I remember Maxime correctly back then, the plan was to= =20 > > avoid those driver hacks and just say what we support in the DT, going= =20 > > forward. This might be needed for other OSes, which might not support=20 > > HS-200? > > >>> Sorry, mmc-hs200-1_8v is ok, but mmc-ddr-1_8v should be > > >>> removed. > > >> > > >> Mmh, I am confused: I thought after the H5 eMMC mishap we figured th= at > > >> all speed modes supported by the eMMC chip should be listed in the D= T? > > >=20 > > > I think H5 just has (had?) driver issue. From what I can see, only hi= ghest > > > supported mode by kernel and chip is specified in all Allwinner DTs. > > > mmc-ddr-1_8v is only specified by two recent board addition, where I = missed > > > it while reviewing. > > >=20 > > >> So any driver wouldn't need to make assumptions, and if a particular > > >> mode shows problems on a board, we just remove that mode from the DT. > > >> Actually, thinking about that, I guess I should list HS-400 as well?= The > > >> BSP kernel uses that mode. > > >=20 > > > Sure, but it also calibrates timing for it. If you'll specify HS400, = kernel > > > will try to use it, but it won't work. > >=20 > > But this is also a limitation of the current Linux kernel driver. And=20 > > since we indeed don't support HS-400, we explicitly remove it from the= =20 > > capability list, *after* the call to mmc_of_parse(): > >=20 > > drivers/mmc/host/sunxi-mmc.c:1460 > > /* TODO: This driver doesn't support HS400 mode yet */ > > mmc->caps2 &=3D ~MMC_CAP2_HS400; > >=20 > > So I think this should be safe? >=20 > Right. Can you test it? >=20 > Best regards, > Jernej >=20 > >=20 > > Cheers, > > Andre > >=20 > > >=20 > > >> Or do you mean to say that in particular DDR (@1.8V) is problematic?= I > > >> cannot test at the moment, but could try later to force that mode. > > >=20 > > > No, no need. If we go in new direction, then it would be good to test it. Best regards, Jernej > > >=20 > > > Best regards, > > > Jernej > > >=20 > > >> > > >> Cheers, > > >> Andre > > >> > > >> > > >>>>> + cap-mmc-hw-reset; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&ohci0 { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&ohci1 { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&pio { > > >>>>> + vcc-pb-supply =3D <®_dcdc1>; > > >>>>> + vcc-pc-supply =3D <®_dcdc1>; > > >>>>> + vcc-pd-supply =3D <®_dcdc1>; > > >>>>> + vcc-pe-supply =3D <®_dcdc1>; > > >>>>> + vcc-pf-supply =3D <®_dcdc1>; > > >>>>> + vcc-pg-supply =3D <®_dldo4>; > > >>>>> + vcc-ph-supply =3D <®_dcdc1>; > > >>>>> +}; > > >>>>> + > > >>>>> +&r_ir { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&r_pio { > > >>>>> + /* > > >>>>> + * We cannot add that supply for now since it would create a ci= rcular > > >>>>> + * dependency between pinctrl, the regulator and the RSB Bus. > > >>>>> + * > > >>>>> + * vcc-pl-supply =3D <®_aldo2>; > > >>>>> + */ > > >>>>> +}; > > >>>>> + > > >>>>> +&r_rsb { > > >>>>> + status =3D "okay"; > > >>>>> + > > >>>>> + axp803: pmic@3a3 { > > >>>>> + compatible =3D "x-powers,axp803"; > > >>>>> + reg =3D <0x3a3>; > > >>>>> + interrupt-parent =3D <&r_intc>; > > >>>>> + interrupts =3D ; > > >>>>> + x-powers,drive-vbus-en; > > >>>>> + > > >>>>> + vin1-supply =3D <®_vcc5v>; > > >>>>> + vin2-supply =3D <®_vcc5v>; > > >>>>> + vin3-supply =3D <®_vcc5v>; > > >>>>> + vin5-supply =3D <®_vcc5v>; > > >>>>> + vin6-supply =3D <®_vcc5v>; > > >>>>> + aldoin-supply =3D <®_vcc5v>; > > >>>>> + dldoin-supply =3D <®_vcc5v>; > > >>>>> + eldoin-supply =3D <®_vcc5v>; > > >>>>> + fldoin-supply =3D <®_vcc5v>; > > >>>>> + drivevbus-supply =3D <®_vcc5v>; > > >>>>> + ips-supply =3D <®_vcc5v>; > > >>>>> + > > >>>>> + status =3D "okay"; > > >>>>> + }; > > >>>>> +}; > > >>>>> + > > >>>>> +#include "axp803.dtsi" > > >>>>> + > > >>>>> +&ac_power_supply { > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_dcdc1 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <3300000>; > > >>>>> + regulator-max-microvolt =3D <3300000>; > > >>>>> + regulator-name =3D "vcc-3v3"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_dcdc2 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <1040000>; > > >>>>> + regulator-max-microvolt =3D <1300000>; > > >>>>> + regulator-name =3D "vdd-cpux"; > > >>>>> +}; > > >>>>> + > > >>>>> +/* DCDC3 is polyphased with DCDC2 */ > > >>>>> + > > >>>>> +®_dcdc5 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <1500000>; > > >>>>> + regulator-max-microvolt =3D <1500000>; > > >>>>> + regulator-name =3D "vcc-dram"; > > >>>>> +}; > > >>>>> + > > >>>>> +/* Deviates from the reset default of 1.1V. */ > > >>>>> +®_dcdc6 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <1200000>; > > >>>>> + regulator-max-microvolt =3D <1200000>; > > >>>>> + regulator-name =3D "vdd-sys"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_aldo1 { > > >>>>> + regulator-min-microvolt =3D <3300000>; > > >>>>> + regulator-max-microvolt =3D <3300000>; > > >>>>> + regulator-name =3D "vcc-wifi"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_aldo2 { > > >>>>> + /* Specifying R_PIO consumer would create circular dependency. = */ > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <3300000>; > > >>>>> + regulator-max-microvolt =3D <3300000>; > > >>>>> + regulator-name =3D "vcc-pl"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_aldo3 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <3000000>; > > >>>>> + regulator-max-microvolt =3D <3000000>; > > >>>>> + regulator-name =3D "vcc-pll-avcc"; > > >>>>> +}; > > >>>>> + > > >>>>> +/* AC200 power supply */ > > >>>>> +®_dldo1 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <3300000>; > > >>>>> + regulator-max-microvolt =3D <3300000>; > > >>>>> + regulator-name =3D "vcc-ave-33"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_dldo4 { > > >>>>> + regulator-min-microvolt =3D <3300000>; > > >>>>> + regulator-max-microvolt =3D <3300000>; > > >>>>> + regulator-name =3D "vcc-wifi-io"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_drivevbus { > > >>>>> + regulator-name =3D "usb0-vbus"; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_eldo1 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <1800000>; > > >>>>> + regulator-max-microvolt =3D <1800000>; > > >>>>> + regulator-name =3D "vcc-cpvdd-dram-emmc"; > > >>>>> +}; > > >>>>> + > > >>>>> +/* Supplies the arisc management core, needed by TF-A to power o= ff cores. */ > > >>>>> +®_fldo2 { > > >>>>> + regulator-always-on; > > >>>>> + regulator-min-microvolt =3D <1100000>; > > >>>>> + regulator-max-microvolt =3D <1100000>; > > >>>>> + regulator-name =3D "vdd-cpus"; > > >>>>> +}; > > >>>>> + > > >>>>> +®_rtc_ldo { > > >>>>> + regulator-name =3D "vcc-rtc"; > > >>>>> +}; > > >>>>> + > > >>>>> +&simplefb_hdmi { > > >>>>> + vcc-hdmi-supply =3D <®_dcdc1>; > > >>>>> +}; > > >>>>> + > > >>>>> +&sound { > > >>>>> + simple-audio-card,aux-devs =3D <&codec_analog>; > > >>>>> + simple-audio-card,widgets =3D "Microphone", "Microphone Jack", > > >>>>> + "Headphone", "Headphone Jack"; > > >>>>> + simple-audio-card,routing =3D > > >>>>> + "Left DAC", "DACL", > > >>>>> + "Right DAC", "DACR", > > >>>>> + "Headphone Jack", "HP", > > >>>>> + "ADCL", "Left ADC", > > >>>>> + "ADCR", "Right ADC", > > >>>>> + "MIC2", "Microphone Jack"; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +/* On the (unpopulated) UART pads. */ > > >>>>> +&uart0 { > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + pinctrl-0 =3D <&uart0_pb_pins>; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&uart1 { > > >>>>> + pinctrl-names =3D "default"; > > >>>>> + pinctrl-0 =3D <&uart1_pins>, <&uart1_rts_cts_pins>; > > >>>>> + uart-has-rtscts; > > >>>>> + status =3D "okay"; > > >>>>> + > > >>>>> + bluetooth { > > >>>>> + compatible =3D "realtek,rtl8723bs-bt"; > > >>>>> + enable-gpios =3D <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */ > > >>>>> + max-speed =3D <1500000>; > > >>>>> + }; > > >>>>> +}; > > >>>>> + > > >>>>> +&usb_otg { > > >>>>> + dr_mode =3D "host"; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> + > > >>>>> +&usbphy { > > >>>>> + usb0_vbus-supply =3D <®_drivevbus>; > > >>>>> + usb1_vbus-supply =3D <®_drivevbus>; > > >>>>> + status =3D "okay"; > > >>>>> +}; > > >>>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>> > > >>> > > >>> > > >>> > > >> > > >=20 > > >=20 > > >=20 > > >=20 > >=20 >=20 >=20 >=20 >=20 >=20