From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector Date: Mon, 10 Jul 2017 22:38:21 +0300 Message-ID: <1965721.tJYYb53Zhd@avalon> References: <1499394976-14201-1-git-send-email-vladimir.barinov@cogentembedded.com> <2531734.5WngiEmILA@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vladimir Barinov Cc: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Vladimir, On Monday 10 Jul 2017 19:28:57 Vladimir Barinov wrote: > On 10.07.2017 16:09, Laurent Pinchart wrote: > > On Friday 07 Jul 2017 05:37:36 Vladimir Barinov wrote: > >> From: Vladimir Barinov > >> > >> The ULCB board has one HDMI output connector. > >> > >> This connector is available on both the H3 and M3-W ULCB boards. > >> Add this to the ulcb.dtsi file. > >> > >> Signed-off-by: Vladimir Barinov > >> --- > >> > >> arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi > >> b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 6f0a7ca..fc5408d 100644 > >> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi > >> @@ -34,6 +34,17 @@ > >> > >> clock-frequency = <11289600>; > >> > >> }; > >> > >> + hdmi0-out { > >> + compatible = "hdmi-connector"; > >> + label = "HDMI0 OUT"; > > > > As far as I know there is no "HDMI0 OUT" label on the board or casing. You > > can remove the label property. Apart from that, > > I was thinking that this is a label on schematic. > > ULCB has similar schematic label as first HDMI connector on Salvator-X > "HDMI output(HDMI0)", hence I've just copied label name from Salvator-X > file. > > Right, there is no such name on ULCB pcb or plastic cover. Yes, that's the difference with the Salvator-X, where the plastic cover has a label. > Is it okay If I resend only one patch with label field removed? Sure. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html