From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1020FC7EE25 for ; Thu, 8 Jun 2023 06:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235056AbjFHG5k (ORCPT ); Thu, 8 Jun 2023 02:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234264AbjFHG5k (ORCPT ); Thu, 8 Jun 2023 02:57:40 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30D7A271F for ; Wed, 7 Jun 2023 23:57:32 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5162d2373cdso411068a12.3 for ; Wed, 07 Jun 2023 23:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686207450; x=1688799450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fTEmXWIWLPRlPJbNfDbnj5fFPU6UIwT4EtE9XcJXYpo=; b=fdY8VREWA24ScfdNkwbMYQmKOkhE3ddtHYFvvkL+PHLVH2cqzdZQdNQbwYI4YEYrRm lNzOlQS2dVVyF8PHTvciHPJElyEsM8x0dp19wqDVcjG2r75sZK4GxLDbSkNxfR1uxVrQ bVdNIf5FgMXm6W64CTi62Gpk+gUW1Rfj2296JapH9iybASS0+IjcdnP/QVVtQrUDG7ZA eY1DE3OpXUFCBYO+iC3rbI5P18uQmKgPbzdZ9MGGavZ2kKyR9dTttjSf49wfAFRKyyYv monPxZQ8f75mDGVu6E9IIJvHt/S2dbWLhCOFPnEsWDEKrTLR/FL5AtQKZuspDrJeRjms WVJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686207450; x=1688799450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fTEmXWIWLPRlPJbNfDbnj5fFPU6UIwT4EtE9XcJXYpo=; b=f/EbrPqHyJfzlr0OnJv+kqTIzY+f5/L1pyJasThKYKCKTzLyzbhhhDNjTQcD2D0jnH Tvfb6nAoGNyfgx6ysjkPSVO5zWi4MJpNYw5UOJIfp8RSXW+c2TOYvECpgnLsKJ3Nzh+A uk0Sm+R5605JPDFZpgXkim/hB40k1lmypifPH8euInqabP+W2t2s5B3iNZ598BU2PsuI ueNSwp2Dmq4fTPvcjv60Y2KL86vu/nuZja+WTFpkA2WiEBAL6/qM37xuSMUTPoYoSiOw R8FWVIh+j0pl6G324Y9gNta7JQXW4AfJpNEgCpP0gwzfPsQyaoyJzYLwre9xeTyiWwCU cM1A== X-Gm-Message-State: AC+VfDzMm0Xf1HiJmaMwJZjhQCgxJQ+ODFumIkD2+/HVeMdvFRQ0tV7Q stqt8CNK5DCC3O6jOtEeph3zIw== X-Google-Smtp-Source: ACHHUZ5r72qNrLxouFjT3sMNlUhsJm5r5BSwsuYMBRi74sjTXzE0b/izv01udFnyO2URibDK+fCzsA== X-Received: by 2002:a17:907:1c15:b0:96a:8c13:8dc0 with SMTP id nc21-20020a1709071c1500b0096a8c138dc0mr8865323ejc.37.1686207450589; Wed, 07 Jun 2023 23:57:30 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id r23-20020a170906c29700b0095807ab4b57sm283706ejz.178.2023.06.07.23.57.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 23:57:30 -0700 (PDT) Message-ID: <19710587-533c-f6df-9842-06a8e2db263c@linaro.org> Date: Thu, 8 Jun 2023 08:57:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v6 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml Content-Language: en-US To: Tony Lindgren Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Nishanth Menon , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org References: <20230605095216.18864-1-tony@atomide.com> <20230608063639.GD14287@atomide.com> From: Krzysztof Kozlowski In-Reply-To: <20230608063639.GD14287@atomide.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/06/2023 08:36, Tony Lindgren wrote: > * Krzysztof Kozlowski [230607 18:17]: >> On 05/06/2023 11:52, Tony Lindgren wrote: >>> +title: Pinctrl driver for hardware with a single register for one or more pins >> >> I asked to drop the driver references but it is still here. Bindings are >> not describing drivers. >> >> "Generic Pin Controller with a Single Register for One or More Pins" > > Oh right it's supposed to describe hardware, will update thanks. > >>> +patternProperties: >>> + '-pins$|-pin': >> >> you did not implement my comments fully, probably we misunderstood each >> other. Why do you allow anything after '-pin'? Let's make it pure suffix >> for both cases: '-pins?$' > > I'll check what kind of node renaming that would cause. At least TI > arm64 SoCs use naming like -pins-default and -pins-wakeup. Is your > preference to rename all those nodes to -default-pins and -wakeup-pins? No, pattern matching TI SoC is fine, but your current also doesn't. Or rather - matches by mistake. You do not allow anything after -pins. Best regards, Krzysztof