From: Tomasz Figa <t.figa@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
kgene.kim@samsung.com
Subject: Re: [PATCH v2 2/2] ARM: dts: Update Samsung sysreg binding document
Date: Thu, 31 Oct 2013 15:11:05 +0100 [thread overview]
Message-ID: <1984328.2sa8SvBFda@amdc1227> (raw)
In-Reply-To: <1383194814-18897-2-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On Thursday 31 of October 2013 10:16:54 Sachin Kamat wrote:
> Added a binding example for reference and updated the
> node name.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> .../devicetree/bindings/arm/samsung/sysreg.txt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> index 5039c0a12f55..f165567a9df0 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> @@ -1,7 +1,13 @@
> SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
>
> Properties:
> - - name : should be 'sysreg';
> + - name : should be 'syscon';
I didn't notice this before, but a device binding should not rather
require any specific name of its top level node, so I'd simply remove this
line.
Otherwise the patch looks fine.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-31 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 4:46 [PATCH v2 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Sachin Kamat
2013-10-31 4:46 ` [PATCH v2 2/2] ARM: dts: Update Samsung sysreg binding document Sachin Kamat
2013-10-31 14:11 ` Tomasz Figa [this message]
2013-10-31 12:39 ` [PATCH v2 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1984328.2sa8SvBFda@amdc1227 \
--to=t.figa@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).