From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wu, Songjun" Subject: Re: [PATCH v2 08/18] serial: intel: Get serial id from dts Date: Mon, 6 Aug 2018 17:32:39 +0800 Message-ID: <198e6e8a-cb42-f6b5-b1c0-e3f0bfd3124a@linux.intel.com> References: <20180803030237.3366-1-songjun.wu@linux.intel.com> <20180803030237.3366-9-songjun.wu@linux.intel.com> <20180803054304.GA2214@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180803054304.GA2214@kroah.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: hua.ma@linux.intel.com, yixin.zhu@linux.intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com, linux-mips@linux-mips.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby List-Id: devicetree@vger.kernel.org On 8/3/2018 1:43 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 03, 2018 at 11:02:27AM +0800, Songjun Wu wrote: >> Get serial id from dts. >> >> "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC >> macro is defined in lantiq_soc.h. >> lantiq_soc.h is in arch path for legacy product support. >> >> arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h >> >> If "#ifdef preprocessor" is changed to >> "if (IS_ENABLED(CONFIG_LANTIQ))", when CONFIG_LANTIQ is not enabled, >> code using LTQ_EARLY_ASC is compiled. >> Compilation will fail for no LTQ_EARLY_ASC defined. >> >> Signed-off-by: Songjun Wu >> --- >> >> Changes in v2: None >> >> drivers/tty/serial/lantiq.c | 19 +++++++++++++++---- >> 1 file changed, 15 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c >> index 044128277248..836ca51460f2 100644 >> --- a/drivers/tty/serial/lantiq.c >> +++ b/drivers/tty/serial/lantiq.c >> @@ -6,6 +6,7 @@ >> * Copyright (C) 2007 Felix Fietkau >> * Copyright (C) 2007 John Crispin >> * Copyright (C) 2010 Thomas Langer, >> + * Copyright (C) 2018 Intel Corporation. > Your changes here do not warrent the addition of a copyright line, don't > you agree? If not, please get a signed-off-by from your corporate > lawyer who does this this is warrented when you resend this patch. > > thanks, > > greg k-h > Thanks. The copyright line will be removed when we resend this patch.