From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Iyappan Subramanian <isubramanian@apm.com>,
davem@davemloft.net, netdev@vger.kernel.org,
devicetree@vger.kernel.org, kchudgar@apm.com, patches@apm.com
Subject: Re: [PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default
Date: Thu, 30 Oct 2014 11:13:49 +0100 [thread overview]
Message-ID: <1991367.DGHysZpQVP@wuerfel> (raw)
In-Reply-To: <1414630580-24640-2-git-send-email-isubramanian@apm.com>
On Wednesday 29 October 2014 17:56:19 Iyappan Subramanian wrote:
> @@ -621,7 +621,7 @@
> };
> };
>
> - sgenet0: ethernet@1f210000 {
> + sgenet0: sgenet@1f210000 {
> compatible = "apm,xgene-enet";
> status = "disabled";
> reg = <0x0 0x1f210000 0x0 0x10000>,
>
This looks like you accidentally reverted a bug fix made earlier.
Network devices should always have the name 'ethernet@...'.
Arnd
next prev parent reply other threads:[~2014-10-30 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 0:56 [PATCH v1 0/2] drivers: net: xgene: Fix crash for backward compatibility Iyappan Subramanian
2014-10-30 0:56 ` [PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default Iyappan Subramanian
2014-10-30 10:13 ` Arnd Bergmann [this message]
2014-11-03 19:45 ` Iyappan Subramanian
[not found] ` <CAKh23FkVrPdCuR6dn1S4RvW14_f4Xq8MWaChUh9DyVp44kVtSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-04 9:40 ` Arnd Bergmann
2014-10-30 0:56 ` [PATCH v1 2/2] drivers: net: xgene: fix: Use separate resources Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1991367.DGHysZpQVP@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox